Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix(ui): restore accordion trigger layout (#50114)

Danny White66a748cdd154
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsx
index 13cfcbae2ac..c3c4ae5b85e 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsx
@@ -46,10 +46,10 @@ export const AdvancedSettings = ({
}
return (
- <div className="px-5">
+ <div className="w-full">
<Accordion type="single" collapsible>
<AccordionItem value="item-1" className="border-none">
- <AccordionTrigger className="font-normal gap-2 justify-between text-sm py-3 hover:no-underline">
+ <AccordionTrigger className="font-normal gap-2 justify-between px-5 py-3 text-sm hover:no-underline">
<div className="flex flex-col items-start gap-0.5">
<span className="text-sm font-medium">Advanced settings</span>
<span className="text-sm text-foreground-lighter font-normal">
@@ -57,7 +57,7 @@ export const AdvancedSettings = ({
</span>
</div>
</AccordionTrigger>
- <AccordionContent className="pb-0! pt-3 [&>div]:flex [&>div]:flex-col [&>div]:gap-y-4">
+ <AccordionContent className="pb-0! pt-3 [&>div]:flex [&>div]:flex-col [&>div]:gap-y-4 [&>div]:px-5">
<FormField
control={form.control}
name="maxFillMs"
diff --git a/apps/studio/components/interfaces/Integrations/Integration/IntegrationOverviewTabV2/InstallIntegrationSheet/AdvancedSettings.tsx b/apps/studio/components/interfaces/Integrations/Integration/IntegrationOverviewTabV2/InstallIntegrationSheet/AdvancedSettings.tsx
index a488cf484c9..77b60047ad9 100644
--- a/apps/studio/components/interfaces/Integrations/Integration/IntegrationOverviewTabV2/InstallIntegrationSheet/AdvancedSettings.tsx
+++ b/apps/studio/components/interfaces/Integrations/Integration/IntegrationOverviewTabV2/InstallIntegrationSheet/AdvancedSettings.tsx
@@ -60,13 +60,13 @@ export const AdvancedSettings = ({
)
return (
- <SheetSection>
+ <SheetSection className="px-0">
<Accordion type="single" collapsible>
<AccordionItem value="advanced-settings" className="border-none">
- <AccordionTrigger className="font-normal gap-2 py-0 justify-between text-sm hover:no-underline">
+ <AccordionTrigger className="font-normal gap-2 px-5 py-0 justify-between text-sm hover:no-underline">
Advanced settings
</AccordionTrigger>
- <AccordionContent className="pb-0! pt-3 [&>div]:flex [&>div]:flex-col [&>div]:gap-y-4">
+ <AccordionContent className="pb-0! pt-3 [&>div]:flex [&>div]:flex-col [&>div]:gap-y-4 [&>div]:px-5">
<p className="text-foreground-light">
Select which schemas to install the database extensions under
</p>
diff --git a/packages/ui/src/components/shadcn/ui/accordion.test.tsx b/packages/ui/src/components/shadcn/ui/accordion.test.tsx
index 734c3e813ec..aa9d12bdb9b 100644
--- a/packages/ui/src/components/shadcn/ui/accordion.test.tsx
+++ b/packages/ui/src/components/shadcn/ui/accordion.test.tsx
@@ -4,7 +4,7 @@ import { describe, expect, it } from 'vitest'
import { Accordion, AccordionItem, AccordionTrigger } from './accordion'
describe('AccordionTrigger', () => {
- it('provides rounded geometry and the shared inset focus ring', () => {
+ it('fills its container without adding horizontal padding', () => {
render(
<Accordion type="single" collapsible>
<AccordionItem value="advanced">
@@ -14,7 +14,9 @@ describe('AccordionTrigger', () => {
)
const trigger = screen.getByRole('button', { name: 'Advanced settings' })
- expect(trigger).toHaveClass('px-2', 'relative', 'focus-inset')
+ expect(trigger.parentElement).toHaveClass('flex', 'w-full')
+ expect(trigger).toHaveClass('flex-1', 'relative', 'focus-inset')
+ expect(trigger).not.toHaveClass('px-2')
expect(trigger).not.toHaveClass('rounded-md')
expect(trigger).not.toHaveClass('focus-ring')
expect(trigger).not.toHaveClass('transition-colors')
diff --git a/packages/ui/src/components/shadcn/ui/accordion.tsx b/packages/ui/src/components/shadcn/ui/accordion.tsx
index cbfe1d8bf66..374993d1462 100644
--- a/packages/ui/src/components/shadcn/ui/accordion.tsx
+++ b/packages/ui/src/components/shadcn/ui/accordion.tsx
@@ -32,11 +32,11 @@ const AccordionTrigger = React.forwardRef<
return (
<AccordionPrimitive.Header asChild>
- <div className="flex">
+ <div className="flex w-full">
<AccordionPrimitive.Trigger
ref={ref}
className={cn(
- 'cursor-pointer flex flex-1 gap-2 items-center justify-between px-2 py-4 text-left',
+ 'cursor-pointer flex flex-1 gap-2 items-center justify-between py-4 text-left',
'font-medium hover:underline',
'[&[data-state=open]>svg]:rotate-180',
focusVariant === 'ring' && 'rounded-md',