The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.
TypeScript aialternativeauthdatabasedenoembeddingsexamplefirebasenextjsoauth2pgvectorpostgispostgrespostgresqlpostgrestrealtimesupabasevectorswebsockets
refactor(studio): compose the pipeline data section for wizard reuse (#51572)
Danny White7fa436050a00
diff --git a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataSection.test.tsx b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataSection.test.tsxnew file mode 100644index 00000000000..90e69d6aebf--- /dev/null+++ b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataSection.test.tsx@@ -0,0 +1,119 @@+import { fireEvent, screen, waitFor } from '@testing-library/react'+import type { components } from 'api-types'+import { mockAnimationsApi } from 'jsdom-testing-mocks'+import { HttpResponse } from 'msw'+import { useForm } from 'react-hook-form'+import { Form } from 'ui'+import { describe, expect, it, vi } from 'vitest'++import type { DestinationPanelSchemaType } from '../DestinationPanel/DestinationForm/DestinationForm.schema'+import type { DestinationType } from '../DestinationPanel/DestinationPanel.types'+import { PipelineDataSection } from './PipelineDataSection'+import { customRender } from '@/tests/lib/custom-render'+import { addAPIMock } from '@/tests/lib/msw'++mockAnimationsApi()+type ReplicationSourcesResponse = components['schemas']['SourcesResponse_Output']+type PublicationDetailsResponse = components['schemas']['PublicationDetailsResponse_Output']+type PublicationNamesResponse = components['schemas']['ReadPublicationsResponse_Output']++const mockSources: ReplicationSourcesResponse = {+ sources: [+ {+ id: 1,+ name: 'default',+ tenant_id: 'tenant',+ config: { host: 'db.internal', name: 'main-db', port: 5432, username: 'etl_user' },+ },+ ],+}++const mockPublicationDetails = (publishViaPartitionRoot: boolean): PublicationDetailsResponse => ({+ name: 'analytics',+ config: {+ type: 'tables',+ tables: [],+ operations: ['insert', 'update', 'delete', 'truncate'],+ publish_via_partition_root: publishViaPartitionRoot,+ },+ tables: [],+})++const mockPublicationRequests = (publishViaPartitionRoot: boolean) => {+ addAPIMock({+ method: 'get',+ path: '/platform/replication/:ref/sources',+ response: () => HttpResponse.json<ReplicationSourcesResponse>(mockSources),+ })+ addAPIMock({+ method: 'get',+ path: '/platform/replication/v2/:ref/sources/:source_id/publications',+ response: () =>+ HttpResponse.json<PublicationNamesResponse>({+ publications: [{ name: 'analytics' }],+ }),+ })+ addAPIMock({+ method: 'get',+ path: '/platform/replication/v2/:ref/sources/:source_id/publications/:publication_name',+ response: () =>+ HttpResponse.json<PublicationDetailsResponse>(+ mockPublicationDetails(publishViaPartitionRoot)+ ),+ })+}++const TestSection = ({ type }: { type: DestinationType }) => {+ const form = useForm<DestinationPanelSchemaType>({+ defaultValues: {+ publicationName: 'analytics',+ tableSyncCopyMode: 'include_all_tables',+ tableSyncCopyTableIds: [],+ maxFillMs: 500,+ maxTableSyncWorkers: 4,+ maxCopyConnectionsPerTable: 1,+ invalidatedSlotBehavior: 'error',+ tableOptions: [],+ },+ })+ return (+ <Form {...form}>+ <PipelineDataSection type={type} form={form} onSelectNewPublication={vi.fn()} />+ </Form>+ )+}++describe('PipelineDataSection', () => {+ it.each<DestinationType>(['BigQuery', 'DuckLake', 'Snowflake', 'ClickHouse', 'Analytics Bucket'])(+ 'groups %s publication, initial sync and replication settings without connection fields',+ async (type) => {+ mockPublicationRequests(false)+ customRender(<TestSection type={type} />)+ expect(screen.getByRole('region', { name: 'Data' })).toBeInTheDocument()+ expect(screen.getByText('Initial sync')).toBeInTheDocument()+ await waitFor(() =>+ expect(screen.getByRole('status')).toHaveTextContent(+ 'Each partition is replicated separately.'+ )+ )+ fireEvent.click(screen.getByRole('button', { name: /Advanced settings/ }))+ expect(screen.getByLabelText('Batch wait time')).toHaveValue(500)+ expect(screen.getByLabelText('Table sync workers')).toHaveValue(4)+ expect(screen.queryByText('Table layout') !== null).toBe(type === 'BigQuery')+ for (const label of [+ 'Pipeline name',+ 'Pipeline region',+ 'Connection pool size',+ 'Maximum staleness',+ 'Pool size',+ 'Role',+ ]) {+ expect(screen.queryByText(label)).not.toBeInTheDocument()+ }+ fireEvent.change(screen.getByLabelText('Batch wait time'), { target: { value: '750' } })+ fireEvent.click(screen.getByRole('button', { name: /Advanced settings/ }))+ fireEvent.click(screen.getByRole('button', { name: /Advanced settings/ }))+ expect(screen.getByLabelText('Batch wait time')).toHaveValue(750)+ }+ )+})diff --git a/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataSection.tsx b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataSection.tsxnew file mode 100644index 00000000000..934ec566f3f--- /dev/null+++ b/apps/studio/components/interfaces/Database/Replication/CreatePipeline/PipelineDataSection.tsx@@ -0,0 +1,28 @@+import type { UseFormReturn } from 'react-hook-form'++import { AdvancedSettings } from '../DestinationPanel/DestinationForm/AdvancedSettings'+import type { DestinationPanelSchemaType } from '../DestinationPanel/DestinationForm/DestinationForm.schema'+import { PublicationSelection } from '../DestinationPanel/DestinationForm/PublicationSelection'+import { TableCopySelection } from '../DestinationPanel/DestinationForm/TableCopySelection'+import type { DestinationType } from '../DestinationPanel/DestinationPanel.types'++export const PipelineDataSection = ({+ type,+ form,+ onSelectNewPublication,+}: {+ type: DestinationType+ form: UseFormReturn<DestinationPanelSchemaType>+ onSelectNewPublication: () => void+}) => (+ <section aria-label="Data">+ <div className="p-5 flex flex-col gap-y-6">+ <h3 className="text-sm font-medium text-foreground">Data</h3>+ <div className="flex flex-col gap-y-4">+ <PublicationSelection form={form} onSelectNewPublication={onSelectNewPublication} />+ <TableCopySelection form={form} editMode={false} />+ </div>+ </div>+ <AdvancedSettings type={type} form={form} group="data" />+ </section>+)diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.test.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.test.tsxindex 254ee8371c9..bbfcd09a7c6 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.test.tsx+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.test.tsx@@ -317,6 +317,7 @@ describe('DestinationForm edit submission', () => {onClose={vi.fn()}/>)+ expect(screen.queryByRole('region', { name: 'Data' }) !== null).toBe(shouldShowSection)expect(screen.queryByRole('region', { name: 'Destination connection' }) !== null).toBe(shouldShowSection)diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsxindex b260639232c..88d57dedf69 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx@@ -11,6 +11,7 @@ import { Admonition } from 'ui-patterns/Admonition'import * as z from 'zod'import { PipelineConnectionSection } from '../../CreatePipeline/PipelineConnectionSection'+import { PipelineDataSection } from '../../CreatePipeline/PipelineDataSection'import {useIsETLBigQueryPrivateAlpha,useIsETLClickHousePrivateAlpha,@@ -497,48 +498,44 @@ export const DestinationForm = ({<DialogSectionSeparator /></>)}- <div className="p-5 flex flex-col gap-y-6">- {isErrorExistingConfig && (- <Admonition type="warning">- <p className="leading-normal!">- The existing destination or pipeline settings could not be loaded. Refresh- before applying changes.- </p>- </Admonition>- )}- <p className="text-sm font-medium text-foreground">- {shouldShowConnectionSection ? 'Data' : 'Destination details'}- </p>-- <div className="flex flex-col gap-y-4">- {!shouldShowConnectionSection && (- <DestinationNameInput form={form} destinationType={selectedType} />- )}- <PublicationSelection- form={form}- onSelectNewPublication={() => setPublicationPanelVisible(true)}- />- <TableCopySelection form={form} editMode={editMode} />- {!shouldShowConnectionSection && (- <PipelineRegionField destinationType={selectedType} />- )}- </div>- </div>-- {!shouldShowConnectionSection && (+ {shouldShowConnectionSection ? (+ <PipelineDataSection+ type={selectedType}+ form={form}+ onSelectNewPublication={() => setPublicationPanelVisible(true)}+ />+ ) : (<>+ <div className="p-5 flex flex-col gap-y-6">+ {isErrorExistingConfig && (+ <Admonition type="warning">+ <p className="leading-normal!">+ The existing destination or pipeline settings could not be loaded.+ Refresh before applying changes.+ </p>+ </Admonition>+ )}+ <p className="text-sm font-medium text-foreground">Destination details</p>++ <div className="flex flex-col gap-y-4">+ <DestinationNameInput form={form} destinationType={selectedType} />+ <PublicationSelection+ form={form}+ onSelectNewPublication={() => setPublicationPanelVisible(true)}+ />+ <TableCopySelection form={form} editMode={editMode} />+ <PipelineRegionField destinationType={selectedType} />+ </div>+ </div>+<DialogSectionSeparator />{destinationFields}- </>- )}- {!shouldShowConnectionSection && <DialogSectionSeparator />}+ <DialogSectionSeparator />- <AdvancedSettings- type={selectedType}- form={form}- group={shouldShowConnectionSection ? 'data' : 'all'}- />+ <AdvancedSettings type={selectedType} form={form} group="all" />+ </>+ )}{!editMode && hasRunValidation && !isValidating && (<>