The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.
TypeScript aialternativeauthdatabasedenoembeddingsexamplefirebasenextjsoauth2pgvectorpostgispostgrespostgresqlpostgrestrealtimesupabasevectorswebsockets
fix(notebooks): reset insert offset when anchor cell moves (#49694)
Charis86c813ec03e3
diff --git a/apps/studio/data/content/notebooks/notebook-operations.test.ts b/apps/studio/data/content/notebooks/notebook-operations.test.tsindex 77a5ba0a804..1194884333a 100644--- a/apps/studio/data/content/notebooks/notebook-operations.test.ts+++ b/apps/studio/data/content/notebooks/notebook-operations.test.ts@@ -121,6 +121,41 @@ describe('applyNotebookOperations', () => {])})+ it('resets the insert offset for an anchor cell once it gets moved', () => {+ // cell-1 gets an insert right after it, then cell-1 itself moves after cell-3. A later+ // insert anchored on cell-1 must land right after its *new* position — the first insert+ // stayed behind at cell-1's old spot, so it shouldn't count toward this offset anymore.+ const notebook: NotebookWire = {+ schema_version: 1,+ cells: [+ { _tag: 'markdown_cell', _id: 'cell-1', text: '1' },+ { _tag: 'markdown_cell', _id: 'cell-2', text: '2' },+ { _tag: 'markdown_cell', _id: 'cell-3', text: '3' },+ { _tag: 'markdown_cell', _id: 'cell-4', text: '4' },+ ],+ }+ const ops: NotebookOperation[] = [+ {+ _tag: 'insert_cell',+ after_cell_id: 'cell-1',+ cell: { _tag: 'markdown_cell', text: 'first' },+ },+ { _tag: 'move_cell', cell_id: 'cell-1', after_cell_id: 'cell-3' },+ {+ _tag: 'insert_cell',+ after_cell_id: 'cell-1',+ cell: { _tag: 'markdown_cell', text: 'second' },+ },+ ]++ const result = applyNotebookOperations(notebook, ops)++ expect(result.success).toBe(true)+ if (!result.success) return+ const texts = result.notebook.cells.map((cell) => ('text' in cell ? cell.text : undefined))+ expect(texts).toEqual(['first', '2', '3', '1', 'second', '4'])+ })+it('resolves a move anchored on another moved cell using its new position', () => {// cell-1 moves after cell-3 first, landing at [cell-2, cell-3, cell-1]; cell-2 then moves// after cell-1's *new* position, giving [cell-3, cell-1, cell-2].diff --git a/apps/studio/data/content/notebooks/notebook-operations.ts b/apps/studio/data/content/notebooks/notebook-operations.tsindex 60d2dcb27d2..2a2b0404de4 100644--- a/apps/studio/data/content/notebooks/notebook-operations.ts+++ b/apps/studio/data/content/notebooks/notebook-operations.ts@@ -256,6 +256,9 @@ export function deriveNotebookDiff(}entries.splice(found.index, 1)+ // Cells already inserted after this anchor stay behind at its old position, so a+ // later insert anchored on it should start counting from its new position again.+ insertedAfter.delete(operation.cell_id)const error = insertAfter(operation.after_cell_id, {_tag: 'moved',cell: found.cell,