Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix(self-hosted): suppress requests to non-existent apis (#46177)

Andrey A.8719bb6dad11
diff --git a/apps/studio/components/layouts/AppLayout/AdvisorButton.self-hosted.test.tsx b/apps/studio/components/layouts/AppLayout/AdvisorButton.self-hosted.test.tsx
new file mode 100644
index 00000000000..9b575085b84
--- /dev/null
+++ b/apps/studio/components/layouts/AppLayout/AdvisorButton.self-hosted.test.tsx
@@ -0,0 +1,70 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+
+import { AdvisorButton } from '@/components/layouts/AppLayout/AdvisorButton'
+import { render } from '@/tests/helpers'
+
+const {
+ mockUseProjectLintsQuery,
+ mockUseNotificationsV2Query,
+ mockUseAdvisorSignals,
+ mockToggleSidebar,
+} = vi.hoisted(() => ({
+ mockUseProjectLintsQuery: vi.fn(),
+ mockUseNotificationsV2Query: vi.fn(),
+ mockUseAdvisorSignals: vi.fn(),
+ mockToggleSidebar: vi.fn(),
+}))
+
+vi.mock('@/data/lint/lint-query', () => ({
+ useProjectLintsQuery: mockUseProjectLintsQuery,
+}))
+
+vi.mock('@/data/notifications/notifications-v2-query', () => ({
+ useNotificationsV2Query: mockUseNotificationsV2Query,
+}))
+
+vi.mock('@/components/ui/AdvisorPanel/useAdvisorSignals', () => ({
+ useAdvisorSignals: mockUseAdvisorSignals,
+}))
+
+vi.mock('@/lib/constants', async (importOriginal) => ({
+ ...(await importOriginal<typeof import('@/lib/constants')>()),
+ IS_PLATFORM: false,
+}))
+
+vi.mock('@/state/sidebar-manager-state', () => ({
+ useSidebarManagerSnapshot: () => ({
+ toggleSidebar: mockToggleSidebar,
+ activeSidebar: undefined,
+ }),
+}))
+
+describe('AdvisorButton on self-hosted', () => {
+ beforeEach(() => {
+ mockUseProjectLintsQuery.mockReturnValue({ data: [], isPending: false, isError: false })
+ mockUseNotificationsV2Query.mockReturnValue({
+ data: { pages: [[]] },
+ isPending: false,
+ isError: false,
+ })
+ mockUseAdvisorSignals.mockReturnValue({
+ data: [],
+ isPending: false,
+ isError: false,
+ dismissSignal: vi.fn(),
+ })
+ })
+
+ afterEach(() => {
+ vi.clearAllMocks()
+ })
+
+ it('disables the notifications query so no request is made to the platform endpoint', () => {
+ render(<AdvisorButton projectRef="project-ref" />)
+
+ expect(mockUseNotificationsV2Query).toHaveBeenCalledWith(
+ { filters: {}, limit: 20 },
+ { enabled: false }
+ )
+ })
+})
diff --git a/apps/studio/components/layouts/AppLayout/AdvisorButton.tsx b/apps/studio/components/layouts/AppLayout/AdvisorButton.tsx
index d9a1cb532f4..65cf75c02c0 100644
--- a/apps/studio/components/layouts/AppLayout/AdvisorButton.tsx
+++ b/apps/studio/components/layouts/AppLayout/AdvisorButton.tsx
@@ -7,6 +7,7 @@ import { useAdvisorSignals } from '@/components/ui/AdvisorPanel/useAdvisorSignal
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
import { useProjectLintsQuery } from '@/data/lint/lint-query'
import { useNotificationsV2Query } from '@/data/notifications/notifications-v2-query'
+import { IS_PLATFORM } from '@/lib/constants'
import { useTrack } from '@/lib/telemetry/track'
import { useSidebarManagerSnapshot } from '@/state/sidebar-manager-state'
@@ -17,10 +18,10 @@ export const AdvisorButton = ({ projectRef }: { projectRef?: string }) => {
const { data: lints } = useProjectLintsQuery({ projectRef })
const { data: signalItems } = useAdvisorSignals({ projectRef })
- const { data: notificationsData } = useNotificationsV2Query({
- filters: {},
- limit: 20,
- })
+ const { data: notificationsData } = useNotificationsV2Query(
+ { filters: {}, limit: 20 },
+ { enabled: IS_PLATFORM }
+ )
const notifications = useMemo(() => {
return notificationsData?.pages.flatMap((page) => page) ?? []
}, [notificationsData?.pages])
diff --git a/apps/studio/components/layouts/AppLayout/FlyDeprecationBanner.tsx b/apps/studio/components/layouts/AppLayout/FlyDeprecationBanner.tsx
index b4517d5447c..3ee91192d73 100644
--- a/apps/studio/components/layouts/AppLayout/FlyDeprecationBanner.tsx
+++ b/apps/studio/components/layouts/AppLayout/FlyDeprecationBanner.tsx
@@ -1,4 +1,4 @@
-import { LOCAL_STORAGE_KEYS } from 'common'
+import { IS_PLATFORM, LOCAL_STORAGE_KEYS } from 'common'
import { useRouter } from 'next/router'
import { useEffect, useRef, type ReactNode } from 'react'
import {
@@ -44,7 +44,7 @@ export const FlyDeprecationBanner = () => {
const isExpired = Date.now() >= BANNER_EXPIRES_AT.getTime()
const onSignIn = router.pathname.startsWith('/sign-in')
- const shouldEvaluate = !isExpired && !onSignIn && isSuccess && !acknowledged
+ const shouldEvaluate = IS_PLATFORM && !isExpired && !onSignIn && isSuccess && !acknowledged
const { isReady, primaries, branches } = useFlyDeprecationProjects({ enabled: shouldEvaluate })