Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix(studio): focus state for buttons with dropdown (#49055)

kemal.earth88e916a4c08b
diff --git a/apps/studio/components/interfaces/Account/AccessTokens/Classic/ExperimentalTokenDropdown.tsx b/apps/studio/components/interfaces/Account/AccessTokens/Classic/ExperimentalTokenDropdown.tsx
index 07efe992006..04452562840 100644
--- a/apps/studio/components/interfaces/Account/AccessTokens/Classic/ExperimentalTokenDropdown.tsx
+++ b/apps/studio/components/interfaces/Account/AccessTokens/Classic/ExperimentalTokenDropdown.tsx
@@ -35,7 +35,7 @@ export const ExperimentalTokenDropdown = ({ onCreateToken }: ExperimentalTokenDr
<Button
variant="primary"
aria-label="Choose token scope"
- className="rounded-l-none px-[4px] py-[5px]"
+ className="-ml-px rounded-l-none px-[4px] py-[5px] focus-visible:z-10"
icon={<ChevronDown />}
/>
</DropdownMenuTrigger>
diff --git a/apps/studio/components/interfaces/Account/AccessTokens/Classic/NewTokenButton.tsx b/apps/studio/components/interfaces/Account/AccessTokens/Classic/NewTokenButton.tsx
index d2473c0a0ad..540840b08b8 100644
--- a/apps/studio/components/interfaces/Account/AccessTokens/Classic/NewTokenButton.tsx
+++ b/apps/studio/components/interfaces/Account/AccessTokens/Classic/NewTokenButton.tsx
@@ -15,7 +15,10 @@ export const NewTokenButton = ({ onCreateToken }: NewAccessTokenButtonProps) =>
return (
<>
<div className="flex items-center">
- <Button className="rounded-r-none px-3" onClick={() => setVisible(true)}>
+ <Button
+ className="rounded-r-none px-3 hover:z-10 focus-visible:z-10"
+ onClick={() => setVisible(true)}
+ >
Generate new token
</Button>
<ExperimentalTokenDropdown onCreateToken={onCreateToken} />
diff --git a/apps/studio/components/interfaces/Account/AccessTokens/Scoped/NewScopedTokenSheet.tsx b/apps/studio/components/interfaces/Account/AccessTokens/Scoped/NewScopedTokenSheet.tsx
index e7a70677a58..7caf6a1190d 100644
--- a/apps/studio/components/interfaces/Account/AccessTokens/Scoped/NewScopedTokenSheet.tsx
+++ b/apps/studio/components/interfaces/Account/AccessTokens/Scoped/NewScopedTokenSheet.tsx
@@ -109,7 +109,7 @@ export const NewScopedTokenSheet = ({ onCreateExperimentalToken }: NewScopedToke
<Sheet open={isOpen} onOpenChange={handleOpenChange}>
<div className="flex items-center">
<SheetTrigger asChild>
- <Button variant="primary" className="rounded-r-none px-3">
+ <Button variant="primary" className="rounded-r-none px-3 hover:z-10 focus-visible:z-10">
Generate new token
</Button>
</SheetTrigger>
diff --git a/apps/studio/components/interfaces/Auth/EmailTemplates/CustomEmailTemplateRestrictionAdmonition.tsx b/apps/studio/components/interfaces/Auth/EmailTemplates/CustomEmailTemplateRestrictionAdmonition.tsx
index 63a04b6ced9..23c6ba82701 100644
--- a/apps/studio/components/interfaces/Auth/EmailTemplates/CustomEmailTemplateRestrictionAdmonition.tsx
+++ b/apps/studio/components/interfaces/Auth/EmailTemplates/CustomEmailTemplateRestrictionAdmonition.tsx
@@ -28,7 +28,7 @@ export const CustomEmailTemplateRestrictionAdmonition = () => {
<Button
asChild
variant="default"
- className="flex-1 rounded-r-none px-3 @lg:flex-none hover:z-10"
+ className="flex-1 rounded-r-none px-3 @lg:flex-none hover:z-10 focus-visible:z-10"
>
<Link href={`/project/${projectRef}/auth/smtp`}>Set up SMTP</Link>
</Button>
@@ -37,7 +37,7 @@ export const CustomEmailTemplateRestrictionAdmonition = () => {
<Button
variant="default"
aria-label="More email template editing options"
- className="shrink-0 rounded-l-none px-[4px] py-[5px] -ml-px"
+ className="shrink-0 rounded-l-none px-[4px] py-[5px] -ml-px focus-visible:z-10"
icon={<ChevronDown />}
/>
</DropdownMenuTrigger>
diff --git a/apps/studio/components/interfaces/Database/Replication/ReplicationPipelineStatus/ReplicationPipelineStatus.tsx b/apps/studio/components/interfaces/Database/Replication/ReplicationPipelineStatus/ReplicationPipelineStatus.tsx
index a670c455cf2..866975ddd27 100644
--- a/apps/studio/components/interfaces/Database/Replication/ReplicationPipelineStatus/ReplicationPipelineStatus.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/ReplicationPipelineStatus/ReplicationPipelineStatus.tsx
@@ -419,7 +419,7 @@ export const ReplicationPipelineStatus = () => {
<Button
size="tiny"
variant="default"
- className="rounded-r-none hover:z-2"
+ className="rounded-r-none hover:z-10 focus-visible:z-10"
icon={<RotateCcw />}
disabled={isAnyRestartInProgress || showDisabledState || isPipelineError}
loading={isAnyRestartInProgress}
@@ -435,7 +435,7 @@ export const ReplicationPipelineStatus = () => {
<Button
variant="default"
icon={<ChevronDown />}
- className="w-7 rounded-l-none -ml-px"
+ className="w-7 rounded-l-none -ml-px focus-visible:z-10"
disabled={showDisabledState || isPipelineError}
/>
</DropdownMenuTrigger>
diff --git a/apps/studio/components/interfaces/LogDrains/OrgAuditLogDrains.tsx b/apps/studio/components/interfaces/LogDrains/OrgAuditLogDrains.tsx
index aa728dc7936..2ea83e97751 100644
--- a/apps/studio/components/interfaces/LogDrains/OrgAuditLogDrains.tsx
+++ b/apps/studio/components/interfaces/LogDrains/OrgAuditLogDrains.tsx
@@ -157,7 +157,7 @@ export function OrgAuditLogDrains() {
disabled={!canManageLogDrains}
onClick={handleAddDestinationClick}
variant="primary"
- className="rounded-r-none px-3"
+ className="rounded-r-none px-3 hover:z-10 focus-visible:z-10"
>
Add destination
</Button>
@@ -167,7 +167,7 @@ export function OrgAuditLogDrains() {
<Button
variant="primary"
title="Choose destination type"
- className="rounded-l-none px-[4px] py-[5px]"
+ className="-ml-px rounded-l-none px-[4px] py-[5px] focus-visible:z-10"
icon={<ChevronDown />}
/>
</DropdownMenuTrigger>
diff --git a/apps/studio/components/interfaces/QueryInsights/hooks/useQueryInsightsTableColumns.tsx b/apps/studio/components/interfaces/QueryInsights/hooks/useQueryInsightsTableColumns.tsx
index fa7eb460936..cacfee532a1 100644
--- a/apps/studio/components/interfaces/QueryInsights/hooks/useQueryInsightsTableColumns.tsx
+++ b/apps/studio/components/interfaces/QueryInsights/hooks/useQueryInsightsTableColumns.tsx
@@ -511,7 +511,7 @@ export function useQueryInsightsTableColumns({
<Button
variant="primary"
size="tiny"
- className="rounded-r-none border-r-0"
+ className="rounded-r-none border-r-0 focus-visible:z-10"
onClick={() => {
setSelectedTriageRow(props.rowIdx)
setSheetView('indexes')
@@ -524,7 +524,7 @@ export function useQueryInsightsTableColumns({
<Button
variant="primary"
size="tiny"
- className="rounded-l-none px-1"
+ className="rounded-l-none px-1 focus-visible:z-10"
icon={<ChevronDown size={12} />}
/>
</DropdownMenuTrigger>
diff --git a/apps/studio/components/interfaces/Settings/General/Infrastructure/RestartServerButton.tsx b/apps/studio/components/interfaces/Settings/General/Infrastructure/RestartServerButton.tsx
index 72bf674119f..28399700880 100644
--- a/apps/studio/components/interfaces/Settings/General/Infrastructure/RestartServerButton.tsx
+++ b/apps/studio/components/interfaces/Settings/General/Infrastructure/RestartServerButton.tsx
@@ -109,7 +109,7 @@ export const RestartServerButton = () => {
<ButtonTooltip
variant="default"
className={cn(
- 'flex-1 px-3 hover:z-10 @lg:flex-none',
+ 'flex-1 px-3 hover:z-10 focus-visible:z-10 @lg:flex-none',
canRestartProject && canRestart ? 'rounded-r-none' : ''
)}
disabled={
@@ -143,7 +143,7 @@ export const RestartServerButton = () => {
<Button
variant="default"
aria-label={`Restart ${entityLabel}`}
- className="shrink-0 rounded-l-none px-[4px] py-[5px] -ml-px"
+ className="shrink-0 rounded-l-none px-[4px] py-[5px] -ml-px focus-visible:z-10"
icon={<ChevronDown />}
disabled={!canRestartProject}
/>
diff --git a/apps/studio/components/interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/CreateTable/CreateTableInstructionsDialog.tsx b/apps/studio/components/interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/CreateTable/CreateTableInstructionsDialog.tsx
index 482887de332..69faefbe298 100644
--- a/apps/studio/components/interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/CreateTable/CreateTableInstructionsDialog.tsx
+++ b/apps/studio/components/interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/CreateTable/CreateTableInstructionsDialog.tsx
@@ -30,7 +30,9 @@ export const CreateTableInstructionsDialog = () => {
<Button
variant="primary"
icon={<Plus />}
- className={cn(enableCreationOfTablesFromDashboard && 'rounded-r-none hover:z-10')}
+ className={cn(
+ enableCreationOfTablesFromDashboard && 'rounded-r-none hover:z-10 focus-visible:z-10'
+ )}
onClick={() => {
if (enableCreationOfTablesFromDashboard) setShowSheet(true)
else setShowModal(true)
@@ -43,7 +45,7 @@ export const CreateTableInstructionsDialog = () => {
<DropdownMenuTrigger asChild>
<Button
variant="primary"
- className="w-7 rounded-l-none -ml-px"
+ className="w-7 rounded-l-none -ml-px focus-visible:z-10"
icon={<ChevronDown />}
/>
</DropdownMenuTrigger>
diff --git a/apps/studio/components/ui/AiAssistantDropdown.tsx b/apps/studio/components/ui/AiAssistantDropdown.tsx
index 10acb318719..c62dc113108 100644
--- a/apps/studio/components/ui/AiAssistantDropdown.tsx
+++ b/apps/studio/components/ui/AiAssistantDropdown.tsx
@@ -133,7 +133,11 @@ export function AiAssistantDropdown({
disabled={disabled}
onClick={handleOpenAssistant}
icon={<AiIconAnimation size={iconOnly ? 16 : 14} loading={loading} />}
- className={cn('rounded-r-none border-r-0', iconOnly && 'px-1.5', className)}
+ className={cn(
+ 'rounded-r-none border-r-0 focus-visible:z-10',
+ iconOnly && 'px-1.5',
+ className
+ )}
>
{!iconOnly && label}
</Button>
@@ -146,7 +150,7 @@ export function AiAssistantDropdown({
variant={variant}
size={size}
disabled={disabled}
- className={cn('rounded-l-none px-1', iconOnly && 'px-1')}
+ className={cn('rounded-l-none px-1 focus-visible:z-10', iconOnly && 'px-1')}
icon={<ChevronDown size={12} />}
/>
</DropdownMenuTrigger>
diff --git a/apps/studio/pages/project/[ref]/settings/log-drains.tsx b/apps/studio/pages/project/[ref]/settings/log-drains.tsx
index 3dac9cc99be..d92f7971b5e 100644
--- a/apps/studio/pages/project/[ref]/settings/log-drains.tsx
+++ b/apps/studio/pages/project/[ref]/settings/log-drains.tsx
@@ -215,7 +215,7 @@ const LogDrainsSettings: NextPageWithLayout = () => {
disabled={!hasAccessToLogDrains || !canManageLogDrains}
onClick={handleAddDestinationClick}
variant="primary"
- className="rounded-r-none px-3"
+ className="rounded-r-none px-3 hover:z-10 focus-visible:z-10"
>
Add destination
</Button>
@@ -225,7 +225,7 @@ const LogDrainsSettings: NextPageWithLayout = () => {
<Button
variant="primary"
title="Choose token scope"
- className="rounded-l-none px-[4px] py-[5px]"
+ className="-ml-px rounded-l-none px-[4px] py-[5px] focus-visible:z-10"
icon={<ChevronDown />}
/>
</DropdownMenuTrigger>