The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.
TypeScript aialternativeauthdatabasedenoembeddingsexamplefirebasenextjsoauth2pgvectorpostgispostgrespostgresqlpostgrestrealtimesupabasevectorswebsockets
fix(studio): coerce index advisor cost values to numbers (#44397)
Ali Waseema70264c8adc9
diff --git a/apps/studio/components/interfaces/QueryPerformance/IndexAdvisor/index-advisor.utils.ts b/apps/studio/components/interfaces/QueryPerformance/IndexAdvisor/index-advisor.utils.tsindex e0b80a3d5ad..723129f64b2 100644--- a/apps/studio/components/interfaces/QueryPerformance/IndexAdvisor/index-advisor.utils.ts+++ b/apps/studio/components/interfaces/QueryPerformance/IndexAdvisor/index-advisor.utils.ts@@ -27,16 +27,18 @@ export function calculateImprovement(costBefore: number | undefined,costAfter: number | undefined): number {- if (- costBefore === undefined ||- costAfter === undefined ||- costBefore <= 0 ||- costBefore <= costAfter- ) {+ if (costBefore === undefined || costAfter === undefined) {return 0}- return ((costBefore - costAfter) / costBefore) * 100+ const before = Number(costBefore)+ const after = Number(costAfter)++ if (before <= 0 || before <= after) {+ return 0+ }++ return ((before - after) / before) * 100}interface CreateIndexParams {diff --git a/apps/studio/components/interfaces/QueryPerformance/QueryPanel.tsx b/apps/studio/components/interfaces/QueryPerformance/QueryPanel.tsxindex 7c700952fa2..d052c10c2c5 100644--- a/apps/studio/components/interfaces/QueryPerformance/QueryPanel.tsx+++ b/apps/studio/components/interfaces/QueryPerformance/QueryPanel.tsx@@ -21,8 +21,8 @@ export const QueryPanelScoreSection = ({className,name,description,- before,- after,+ before: rawBefore,+ after: rawAfter,hideArrowMarkers = false,}: {className?: string@@ -31,58 +31,63 @@ export const QueryPanelScoreSection = ({before?: numberafter?: numberhideArrowMarkers?: boolean-}) => (- <div className={cn('py-4 px-4 flex', className)}>- <div className="flex gap-x-2 w-48">- <span className="text-sm">{name}</span>- <Tooltip>- <TooltipTrigger asChild className="mt-1">- <InformationCircleIcon className="transition text-foreground-muted w-3 h-3 data-[state=delayed-open]:text-foreground-light" />- </TooltipTrigger>- <TooltipContent side="top" className="w-52 text-center">- {description}- </TooltipContent>- </Tooltip>- </div>- <div className="flex flex-col gap-y-1">- <div className="flex gap-x-2 text-sm">- <span className="text-foreground-light w-20">Currently:</span>- <span- className={cn(- 'font-mono',- before !== undefined && after !== undefined && before !== after- ? 'text-foreground-light'- : ''- )}- >- {before}- </span>+}) => {+ const before = rawBefore !== undefined ? Number(rawBefore) : undefined+ const after = rawAfter !== undefined ? Number(rawAfter) : undefined++ return (+ <div className={cn('py-4 px-4 flex', className)}>+ <div className="flex gap-x-2 w-48">+ <span className="text-sm">{name}</span>+ <Tooltip>+ <TooltipTrigger asChild className="mt-1">+ <InformationCircleIcon className="transition text-foreground-muted w-3 h-3 data-[state=delayed-open]:text-foreground-light" />+ </TooltipTrigger>+ <TooltipContent side="top" className="w-52 text-center">+ {description}+ </TooltipContent>+ </Tooltip></div>- {before !== undefined && after !== undefined && before !== after && (- <div className="flex items-center gap-x-2 text-sm">- <span className="text-foreground-light w-20">With index:</span>- <span className="font-mono">{after}</span>- {before !== undefined && !hideArrowMarkers && (- <div className="flex items-center gap-x-1">- {after > before ? (- <ArrowUp size={14} className="text-warning" />- ) : (- <ArrowDown size={14} className="text-brand" />- )}- {typeof before === 'number' && before !== 0 && !isNaN(before) && isFinite(before) && (- <span- className={cn(- 'font-mono tracking-tighter',- after > before ? 'text-warning' : 'text-brand'- )}- >- {(((before - after) / before) * 100).toFixed(2)}%- </span>- )}- </div>- )}+ <div className="flex flex-col gap-y-1">+ <div className="flex gap-x-2 text-sm">+ <span className="text-foreground-light w-20">Currently:</span>+ <span+ className={cn(+ 'font-mono',+ before !== undefined && after !== undefined && before !== after+ ? 'text-foreground-light'+ : ''+ )}+ >+ {before}+ </span></div>- )}+ {before !== undefined && after !== undefined && before !== after && (+ <div className="flex items-center gap-x-2 text-sm">+ <span className="text-foreground-light w-20">With index:</span>+ <span className="font-mono">{after}</span>+ {before !== undefined && !hideArrowMarkers && (+ <div className="flex items-center gap-x-1">+ {after > before ? (+ <ArrowUp size={14} className="text-warning" />+ ) : (+ <ArrowDown size={14} className="text-brand" />+ )}+ {before !== 0 && !isNaN(before) && isFinite(before) && (+ <span+ className={cn(+ 'font-mono tracking-tighter',+ after > before ? 'text-warning' : 'text-brand'+ )}+ >+ {(((before - after) / before) * 100).toFixed(2)}%+ </span>+ )}+ </div>+ )}+ </div>+ )}+ </div></div>- </div>-)+ )+}