Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix(studio): prevent infinite render loop in new-project form (#46131)

Alaister Youngb28323be98af
diff --git a/apps/studio/pages/new/[slug].tsx b/apps/studio/pages/new/[slug].tsx
index 501f42a143d..fc4287d2b50 100644
--- a/apps/studio/pages/new/[slug].tsx
+++ b/apps/studio/pages/new/[slug].tsx
@@ -163,13 +163,21 @@ const Wizard: NextPageWithLayout = () => {
highAvailability,
} = useWatch({ control: form.control })
+ // Read dirty state during render rather than depending on form.formState in the
+ // effect — form.formState is a Proxy that gets a new reference every render, which
+ // would re-fire this effect after each setValue and trigger an infinite loop.
+ const isDataApiDefaultPrivilegesDirty = getFieldState(
+ 'dataApiDefaultPrivileges',
+ form.formState
+ ).isDirty
+
useEffect(() => {
if (dataApiRevokeOnCreateDefaultFlag === undefined) return
- if (getFieldState('dataApiDefaultPrivileges', form.formState).isDirty) return
+ if (isDataApiDefaultPrivilegesDirty) return
setValue('dataApiDefaultPrivileges', !dataApiRevokeOnCreateDefaultFlag, {
shouldDirty: false,
})
- }, [dataApiRevokeOnCreateDefaultFlag, getFieldState, setValue, form.formState])
+ }, [dataApiRevokeOnCreateDefaultFlag, isDataApiDefaultPrivilegesDirty, setValue])
// [Charis] Since the form is updated in a useEffect, there is an edge case
// when switching from free to paid, where canChooseInstanceSize is true for