The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.
TypeScript aialternativeauthdatabasedenoembeddingsexamplefirebasenextjsoauth2pgvectorpostgispostgrespostgresqlpostgrestrealtimesupabasevectorswebsockets
feat(studio): warn on dirty notebook assistant proposals (#49536)
Charisb686a72d89bc
diff --git a/apps/studio/components/ui/AIAssistantPanel/NotebookProposalRenderer.test.tsx b/apps/studio/components/ui/AIAssistantPanel/NotebookProposalRenderer.test.tsxindex 78682c3dcfa..7c0bf592dae 100644--- a/apps/studio/components/ui/AIAssistantPanel/NotebookProposalRenderer.test.tsx+++ b/apps/studio/components/ui/AIAssistantPanel/NotebookProposalRenderer.test.tsx@@ -1,10 +1,12 @@-import { screen } from '@testing-library/react'+import { cleanup, screen } from '@testing-library/react'import userEvent from '@testing-library/user-event'import { HttpResponse } from 'msw'-import { describe, expect, it, vi } from 'vitest'+import { afterEach, describe, expect, it, vi } from 'vitest'import { NotebookProposalRenderer } from './NotebookProposalRenderer'import type { components } from '@/data/api'+import type { SnippetStatus } from '@/data/content/snippet-status'+import { notebooksState } from '@/state/notebooks/notebooks-state'import { customRender as render } from '@/tests/lib/custom-render'import { addAPIMock } from '@/tests/lib/msw'@@ -12,21 +14,21 @@ const NOTEBOOK_ID = 'd3aadd77-7c3c-4de7-aa5c-5aa8ac270b44'const mockNotebookRow = (overrides: Partial<Record<string, unknown>> = {}) => ({id: NOTEBOOK_ID,- type: 'notebook',+ type: 'notebook' as const,name: 'Signup funnel',description: '',favorite: false,folder_id: null,inserted_at: '2024-01-01T00:00:00.000Z',updated_at: '2024-01-01T00:00:00.000Z',- visibility: 'project',+ visibility: 'project' as const,owner_id: 1,project_id: 1,content: {- schema_version: 1,+ schema_version: 1 as const,cells: [- { _tag: 'markdown_cell', _id: 'cell-1', text: 'hello' },- { _tag: 'markdown_cell', _id: 'cell-2', text: 'world' },+ { _tag: 'markdown_cell' as const, _id: 'cell-1', text: 'hello' },+ { _tag: 'markdown_cell' as const, _id: 'cell-2', text: 'world' },],},...overrides,@@ -42,6 +44,19 @@ const mockContentItem = (row: ReturnType<typeof mockNotebookRow>) =>),})+const setLocalNotebook = (status: SnippetStatus) => {+ notebooksState.notebooks[NOTEBOOK_ID] = {+ projectRef: 'default',+ notebook: mockNotebookRow(),+ status,+ }+}++afterEach(() => {+ cleanup()+ notebooksState.notebooks = {}+})+describe('NotebookProposalRenderer', () => {it('renders the create-mode preview and approves on confirm', async () => {const user = userEvent.setup()@@ -98,6 +113,70 @@ describe('NotebookProposalRenderer', () => {expect(onApprove).toHaveBeenCalledTimes(1)})+ it('warns about unsaved local changes without disabling update approval', async () => {+ const user = userEvent.setup()+ const onApprove = vi.fn()+ setLocalNotebook('unsaved')+ mockContentItem(mockNotebookRow())++ render(+ <NotebookProposalRenderer+ mode="update"+ state="approval-requested"+ confirmState="approval-requested"+ input={{+ id: NOTEBOOK_ID,+ expected_updated_at: '2024-01-01T00:00:00.000Z',+ operations: [{ _tag: 'delete_cell', cell_id: 'cell-1' }],+ }}+ output={undefined}+ onApprove={onApprove}+ onDeny={vi.fn()}+ />+ )++ expect(+ await screen.findByText(+ "This notebook has unsaved local changes that aren't reflected in this preview. Approving will overwrite them on save."+ )+ ).toBeInTheDocument()++ const approveButton = screen.getByRole('button', { name: 'Apply changes' })+ expect(approveButton).toBeEnabled()+ await user.click(approveButton)+ expect(onApprove).toHaveBeenCalledTimes(1)+ })++ it.each([+ ['saved', true],+ ['absent', false],+ ])(+ 'does not warn about unsaved changes when local notebook state is %s',+ async (_, hasLocalNotebook) => {+ if (hasLocalNotebook) setLocalNotebook('saved')+ mockContentItem(mockNotebookRow())++ render(+ <NotebookProposalRenderer+ mode="update"+ state="approval-requested"+ confirmState="approval-requested"+ input={{+ id: NOTEBOOK_ID,+ expected_updated_at: '2024-01-01T00:00:00.000Z',+ operations: [{ _tag: 'delete_cell', cell_id: 'cell-1' }],+ }}+ output={undefined}+ onApprove={vi.fn()}+ onDeny={vi.fn()}+ />+ )++ expect(await screen.findByText('−1')).toBeInTheDocument()+ expect(screen.queryByText('Unsaved local changes')).not.toBeInTheDocument()+ }+ )+it('falls back to a raw-input admonition without dropping the confirm footer on a parse failure', async () => {const user = userEvent.setup()const onApprove = vi.fn()@@ -532,6 +611,30 @@ describe('NotebookProposalRenderer', () => {expect(onApprove).toHaveBeenCalledTimes(1)})+ it('shows a delete-specific warning for unsaved local changes', async () => {+ setLocalNotebook('unsaved')+ mockContentItem(mockNotebookRow())++ render(+ <NotebookProposalRenderer+ mode="delete"+ state="approval-requested"+ confirmState="approval-requested"+ input={{ id: NOTEBOOK_ID }}+ output={undefined}+ onApprove={vi.fn()}+ onDeny={vi.fn()}+ />+ )++ expect(+ await screen.findByText(+ "This notebook has unsaved local changes that aren't reflected in this preview. Approving will permanently delete them."+ )+ ).toBeInTheDocument()+ expect(screen.getByRole('button', { name: 'Delete' })).toBeEnabled()+ })+it('denies the delete proposal on skip', async () => {const user = userEvent.setup()const onDeny = vi.fn()diff --git a/apps/studio/components/ui/AIAssistantPanel/NotebookProposalRenderer.tsx b/apps/studio/components/ui/AIAssistantPanel/NotebookProposalRenderer.tsxindex 48d3a47615d..72901332b1a 100644--- a/apps/studio/components/ui/AIAssistantPanel/NotebookProposalRenderer.tsx+++ b/apps/studio/components/ui/AIAssistantPanel/NotebookProposalRenderer.tsx@@ -17,6 +17,7 @@ import {updateNotebookToolOutputSchema,} from './Message.utils'import { AlertError } from '@/components/ui/AlertError'+import { hasDiscardableChanges } from '@/data/content/notebooks/notebook-cache'import {deriveNotebookDiff,describeNotebookOperationError,@@ -24,6 +25,7 @@ import {} from '@/data/content/notebooks/notebook-operations'import { useNotebookQuery } from '@/data/content/notebooks/notebook-query'import { toWireNotebook } from '@/data/content/notebooks/notebook-schema'+import { useNotebooksStateSnapshot } from '@/state/notebooks/notebooks-state'export type NotebookProposalMode = 'create' | 'update' | 'delete'@@ -383,8 +385,13 @@ function UpdateNotebookProposal({denyWithReason,}: NotebookProposalStepPropsWithOutput) {const { ref } = useParams()+ const notebooksSnap = useNotebooksStateSnapshot()const parsedInput = updateNotebookInputSchema.safeParse(input)const isCompleted = state === 'output-available'+ const hasUnsavedLocalChanges =+ confirmState === 'approval-requested' &&+ parsedInput.success &&+ hasDiscardableChanges(notebooksSnap.notebooks[parsedInput.data.id])const {data: notebook,@@ -501,6 +508,7 @@ function UpdateNotebookProposal({onApprove={onApprove}onDeny={onDeny}>+ {hasUnsavedLocalChanges && <UnsavedLocalChangesWarning mode="update" />}<AssistantNotebookPreview entries={diff.entries} mode="update" title={notebook.name} /></NotebookConfirm>)@@ -515,8 +523,13 @@ function DeleteNotebookProposal({onDeny,}: NotebookProposalStepPropsWithOutput) {const { ref } = useParams()+ const notebooksSnap = useNotebooksStateSnapshot()const parsedInput = deleteNotebookInputSchema.safeParse(input)const isCompleted = state === 'output-available'+ const hasUnsavedLocalChanges =+ confirmState === 'approval-requested' &&+ parsedInput.success &&+ hasDiscardableChanges(notebooksSnap.notebooks[parsedInput.data.id])const {data: notebook,@@ -593,6 +606,7 @@ function DeleteNotebookProposal({onApprove={onApprove}onDeny={onDeny}>+ {hasUnsavedLocalChanges && <UnsavedLocalChangesWarning mode="delete" />}<div className="p-3"><Admonitiontype="destructive"@@ -603,3 +617,19 @@ function DeleteNotebookProposal({</NotebookConfirm>)}++function UnsavedLocalChangesWarning({ mode }: { mode: 'update' | 'delete' }) {+ return (+ <div className="px-2 pt-2">+ <Admonition+ type="warning"+ title="Unsaved local changes"+ description={+ mode === 'update'+ ? "This notebook has unsaved local changes that aren't reflected in this preview. Approving will overwrite them on save."+ : "This notebook has unsaved local changes that aren't reflected in this preview. Approving will permanently delete them."+ }+ />+ </div>+ )+}