Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

chore(billing): remove billing address modal and tax id banner (#46210)

Kanishk Dudejaba77d15d419d
diff --git a/apps/studio/components/interfaces/App/AppBannerWrapper.tsx b/apps/studio/components/interfaces/App/AppBannerWrapper.tsx
index 617db464b69..a2e00299285 100644
--- a/apps/studio/components/interfaces/App/AppBannerWrapper.tsx
+++ b/apps/studio/components/interfaces/App/AppBannerWrapper.tsx
@@ -18,8 +18,6 @@ export const AppBannerWrapper = ({ children }: PropsWithChildren<{}>) => {
{showNoticeBanner && <NoticeBanner />}
<FlyDeprecationBanner />
<OrganizationResourceBanner />
- {/* Disabled until reintroduced or removed altogether. */}
- {/* <TaxIdBanner /> */}
{clockSkewBanner && <ClockSkewBanner />}
</div>
{children}
diff --git a/apps/studio/components/interfaces/App/UpdateBillingAddressModal.tsx b/apps/studio/components/interfaces/App/UpdateBillingAddressModal.tsx
deleted file mode 100644
index 920fd85fe53..00000000000
--- a/apps/studio/components/interfaces/App/UpdateBillingAddressModal.tsx
+++ /dev/null
@@ -1,245 +0,0 @@
-import { Elements } from '@stripe/react-stripe-js'
-import { loadStripe, StripeAddressElement, StripeElementsOptions } from '@stripe/stripe-js'
-import { PermissionAction } from '@supabase/shared-types/out/constants'
-import { useQueryClient } from '@tanstack/react-query'
-import { useFlag } from 'common'
-import { useTheme } from 'next-themes'
-import { useEffect, useMemo, useRef, useState } from 'react'
-import { toast } from 'sonner'
-import {
- Button,
- Dialog,
- DialogContent,
- DialogDescription,
- DialogFooter,
- DialogHeader,
- DialogSection,
- DialogTitle,
- Form,
-} from 'ui'
-import { ShimmeringLoader } from 'ui-patterns/ShimmeringLoader'
-
-import {
- getAddressElementAppearanceOptions,
- STRIPE_ELEMENT_FONTS,
-} from '@/components/interfaces/Billing/Payment/Payment.utils'
-import { BillingCustomerDataForm } from '@/components/interfaces/Organization/BillingSettings/BillingCustomerData/BillingCustomerDataForm'
-import { useBillingCustomerDataForm } from '@/components/interfaces/Organization/BillingSettings/BillingCustomerData/useBillingCustomerDataForm'
-import { useOrganizationCustomerProfileQuery } from '@/data/organizations/organization-customer-profile-query'
-import { useOrganizationCustomerProfileUpdateMutation } from '@/data/organizations/organization-customer-profile-update-mutation'
-import { useOrganizationTaxIdQuery } from '@/data/organizations/organization-tax-id-query'
-import { invalidateOrganizationsQuery } from '@/data/organizations/organizations-query'
-import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
-import { useSelectedOrganizationQuery } from '@/hooks/misc/useSelectedOrganization'
-import { IS_PLATFORM, STRIPE_PUBLIC_KEY } from '@/lib/constants'
-
-const stripePromise = loadStripe(STRIPE_PUBLIC_KEY)
-
-export function UpdateBillingAddressModal() {
- const queryClient = useQueryClient()
- const { resolvedTheme } = useTheme()
-
- const [dismissed, setDismissed] = useState(false)
- const [isSubmitting, setIsSubmitting] = useState(false)
- const addressElementRef = useRef<StripeAddressElement | null>(null)
-
- const showMissingAddressModal = useFlag('enableBillingAddressModal')
- const { data: org } = useSelectedOrganizationQuery()
- const slug = org?.slug
-
- const { can: canBillingRead, isSuccess: billingReadLoaded } = useAsyncCheckPermissions(
- PermissionAction.BILLING_READ,
- 'stripe.customer'
- )
- const { can: canBillingWrite, isSuccess: billingWriteLoaded } = useAsyncCheckPermissions(
- PermissionAction.BILLING_WRITE,
- 'stripe.customer'
- )
-
- const permissionsLoaded = billingReadLoaded && billingWriteLoaded
- const canViewModal = canBillingRead || canBillingWrite
- const canManageBillingAddress = canBillingWrite
-
- const shouldShow = Boolean(
- IS_PLATFORM &&
- showMissingAddressModal &&
- org &&
- org.plan.id !== 'free' &&
- org.organization_missing_address &&
- !org.billing_partner &&
- permissionsLoaded &&
- canViewModal
- )
-
- const {
- data: customerProfile,
- isSuccess: profileLoaded,
- isError: profileError,
- } = useOrganizationCustomerProfileQuery(
- { slug },
- { enabled: shouldShow && !dismissed && !!slug && canManageBillingAddress }
- )
-
- const {
- data: taxId,
- isSuccess: taxIdLoaded,
- isError: taxIdError,
- } = useOrganizationTaxIdQuery(
- { slug },
- { enabled: shouldShow && !dismissed && !!slug && canManageBillingAddress }
- )
-
- const open =
- shouldShow && !dismissed && (!canManageBillingAddress || (!profileError && !taxIdError))
-
- const { mutateAsync: updateCustomerProfile } = useOrganizationCustomerProfileUpdateMutation({
- onError: () => {},
- })
-
- const {
- form,
- handleSubmit,
- isDirty,
- resetKey,
- onAddressChange,
- applyAddressElementValue,
- markCurrentValuesAsSaved,
- addressCountry,
- addressOptions,
- } = useBillingCustomerDataForm({
- customerProfile,
- taxId,
- onCustomerDataChange: async (data) => {
- if (!slug) return
- setIsSubmitting(true)
-
- try {
- await updateCustomerProfile({
- slug,
- address: data.address,
- billing_name: data.billing_name,
- tax_id: data.tax_id,
- })
- setDismissed(true)
- await invalidateOrganizationsQuery(queryClient)
-
- toast.success('Successfully updated billing address')
- } catch (error: any) {
- toast.error(`Failed to update billing address: ${error.message}`)
- throw error
- } finally {
- setIsSubmitting(false)
- }
- },
- })
-
- useEffect(() => {
- addressElementRef.current = null
- }, [resetKey])
-
- const onFormSubmit = async (e: React.FormEvent) => {
- e.preventDefault()
- try {
- if (addressElementRef.current) {
- const addressResult = await addressElementRef.current.getValue()
- applyAddressElementValue(addressResult)
- }
- const result = await handleSubmit()
- if (result.status === 'error') {
- toast.error(result.message)
- return
- }
- markCurrentValuesAsSaved(
- result.submittedState.addressValue,
- result.submittedState.taxIdValues
- )
- } catch {
- // Save failure toasts are handled inside onCustomerDataChange.
- }
- }
-
- const stripeElementsOptions: StripeElementsOptions = useMemo(
- () =>
- ({
- mode: 'setup',
- currency: 'usd',
- appearance: getAddressElementAppearanceOptions(resolvedTheme),
- fonts: STRIPE_ELEMENT_FONTS,
- }) as any,
- [resolvedTheme]
- )
-
- return (
- <Dialog
- open={open}
- onOpenChange={(value) => {
- if (!value) setDismissed(true)
- }}
- >
- <DialogContent
- size="medium"
- hideClose={canManageBillingAddress}
- onInteractOutside={(e) => e.preventDefault()}
- onEscapeKeyDown={(e) => e.preventDefault()}
- >
- <DialogHeader>
- <DialogTitle>Billing address required</DialogTitle>
- <DialogDescription>
- {canManageBillingAddress ? (
- 'Please provide a billing address for your organization. If you are a registered business and have a Tax ID, please add your Tax ID too.'
- ) : (
- <>
- Your organization requires a billing address. If you are a registered business, a
- Tax ID is also required.
- <br />
- <br />
- Please ask an organization administrator or owner to update it as soon as possible
- to avoid service restrictions.
- </>
- )}
- </DialogDescription>
- </DialogHeader>
-
- {canManageBillingAddress &&
- (!profileLoaded || !taxIdLoaded ? (
- <DialogSection>
- <div className="space-y-2">
- <ShimmeringLoader />
- <ShimmeringLoader className="w-3/4" />
- <ShimmeringLoader className="w-1/2" />
- </div>
- </DialogSection>
- ) : (
- <Elements stripe={stripePromise} options={stripeElementsOptions}>
- <Form {...form}>
- <form onSubmit={onFormSubmit}>
- <DialogSection className="max-h-[60vh] overflow-y-auto">
- <BillingCustomerDataForm
- form={form}
- addressOptions={addressOptions}
- resetKey={resetKey}
- onAddressChange={onAddressChange}
- onAddressReady={(element) => {
- addressElementRef.current = element
- }}
- addressCountry={addressCountry}
- />
- </DialogSection>
- <DialogFooter>
- <Button
- type="primary"
- htmlType="submit"
- loading={isSubmitting}
- disabled={!isDirty || isSubmitting}
- >
- Save address
- </Button>
- </DialogFooter>
- </form>
- </Form>
- </Elements>
- ))}
- </DialogContent>
- </Dialog>
- )
-}
diff --git a/apps/studio/components/layouts/AppLayout/TaxIdBanner.tsx b/apps/studio/components/layouts/AppLayout/TaxIdBanner.tsx
deleted file mode 100644
index 346b257f501..00000000000
--- a/apps/studio/components/layouts/AppLayout/TaxIdBanner.tsx
+++ /dev/null
@@ -1,66 +0,0 @@
-import { LOCAL_STORAGE_KEYS } from 'common'
-import { useRouter } from 'next/router'
-
-import { TAX_IDS } from '@/components/interfaces/Organization/BillingSettings/BillingCustomerData/TaxID.constants'
-import { HeaderBanner } from '@/components/interfaces/Organization/HeaderBanner'
-import { InlineLink } from '@/components/ui/InlineLink'
-import { useOrganizationCustomerProfileQuery } from '@/data/organizations/organization-customer-profile-query'
-import { useLocalStorageQuery } from '@/hooks/misc/useLocalStorage'
-import { useSelectedOrganizationQuery } from '@/hooks/misc/useSelectedOrganization'
-
-const SUPPORTED_TAX_ID_COUNTRIES = new Set(TAX_IDS.map((t) => t.countryIso2))
-
-export const TaxIdBanner = () => {
- const router = useRouter()
- const { data: org } = useSelectedOrganizationQuery()
- const slug = org?.slug
-
- const [isDismissed, setIsDismissed, { isSuccess: isDismissLoaded }] = useLocalStorageQuery(
- LOCAL_STORAGE_KEYS.TAX_ID_BANNER_DISMISSED(slug ?? ''),
- false
- )
-
- const shouldFetch = Boolean(
- !!slug &&
- org?.plan?.id !== 'free' &&
- !org?.billing_partner &&
- isDismissLoaded &&
- !isDismissed &&
- !!org?.organization_missing_tax_id
- )
- const { data: customerProfile } = useOrganizationCustomerProfileQuery(
- { slug },
- { enabled: shouldFetch, staleTime: 1000 * 60 * 30 }
- )
-
- const billingCountry = customerProfile?.address?.country
- const hasSupportedTaxId = !!billingCountry && SUPPORTED_TAX_ID_COUNTRIES.has(billingCountry)
-
- if (
- router.pathname.includes('sign-in') ||
- !org ||
- org.plan?.id === 'free' ||
- org.billing_partner ||
- !isDismissLoaded ||
- isDismissed ||
- !org.organization_missing_tax_id ||
- !hasSupportedTaxId
- ) {
- return null
- }
-
- return (
- <HeaderBanner
- variant="note"
- title="Missing tax ID"
- description={
- <>
- Registered businesses must{' '}
- <InlineLink href={`/org/${slug}/billing#address`}>add a tax ID</InlineLink> to their
- billing details
- </>
- }
- onDismiss={() => setIsDismissed(true)}
- />
- )
-}
diff --git a/apps/studio/pages/_app.tsx b/apps/studio/pages/_app.tsx
index a9ee00e875d..54513f66191 100644
--- a/apps/studio/pages/_app.tsx
+++ b/apps/studio/pages/_app.tsx
@@ -47,7 +47,6 @@ import { FeaturePreviewContextProvider } from '@/components/interfaces/App/Featu
import { FeaturePreviewModal } from '@/components/interfaces/App/FeaturePreview/FeaturePreviewModal'
import { MonacoThemeProvider } from '@/components/interfaces/App/MonacoThemeProvider'
import { RouteValidationWrapper } from '@/components/interfaces/App/RouteValidationWrapper'
-import { UpdateBillingAddressModal } from '@/components/interfaces/App/UpdateBillingAddressModal'
import { MainScrollContainerProvider } from '@/components/layouts/MainScrollContainerContext'
import { BannerStackProvider } from '@/components/ui/BannerStack/BannerStackProvider'
import { GlobalErrorBoundaryState } from '@/components/ui/ErrorBoundary/GlobalErrorBoundaryState'
@@ -222,7 +221,6 @@ function CustomApp({ Component, pageProps }: AppPropsWithLayout) {
<GlobalShortcuts />
<StudioCommandMenu />
<FeaturePreviewModal />
- <UpdateBillingAddressModal />
</FeaturePreviewContextProvider>
</BannerStackProvider>
<Toaster />
diff --git a/apps/studio/tests/components/Billing/UpdateBillingAddressModal.test.tsx b/apps/studio/tests/components/Billing/UpdateBillingAddressModal.test.tsx
deleted file mode 100644
index 447979241a9..00000000000
--- a/apps/studio/tests/components/Billing/UpdateBillingAddressModal.test.tsx
+++ /dev/null
@@ -1,401 +0,0 @@
-import type {
- StripeAddressElement,
- StripeAddressElementChangeEvent,
- StripeAddressElementOptions,
-} from '@stripe/stripe-js'
-import { PermissionAction } from '@supabase/shared-types/out/constants'
-import { screen, waitFor } from '@testing-library/react'
-import userEvent from '@testing-library/user-event'
-import { useEffect, type ReactNode } from 'react'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
-
-import { UpdateBillingAddressModal } from '@/components/interfaces/App/UpdateBillingAddressModal'
-import { createMockOrganization, render } from '@/tests/helpers'
-
-type MockAddressElementProps = {
- onChange?: (event: StripeAddressElementChangeEvent) => void
- onReady?: (element: StripeAddressElement) => void
- options?: StripeAddressElementOptions
-}
-
-const EMPTY_ADDRESS_VALUE: StripeAddressElementChangeEvent['value'] = {
- name: '',
- address: {
- line1: '',
- line2: '',
- city: '',
- state: '',
- postal_code: '',
- country: '',
- },
-}
-
-let currentAddressValue: StripeAddressElementChangeEvent['value'] = EMPTY_ADDRESS_VALUE
-let currentAddressComplete = false
-
-const emitAddressEvent = (
- props: MockAddressElementProps,
- event: Pick<StripeAddressElementChangeEvent, 'complete' | 'value'>
-) => {
- currentAddressValue = event.value
- currentAddressComplete = event.complete
- props.onChange?.({
- elementType: 'address',
- elementMode: 'billing',
- empty: false,
- isNewAddress: false,
- ...event,
- })
-}
-
-vi.mock('@stripe/react-stripe-js', () => ({
- Elements: ({ children }: { children: ReactNode }) => <div>{children}</div>,
- AddressElement: (props: MockAddressElementProps) => {
- useEffect(() => {
- props.onReady?.({
- getValue: vi.fn(async () => ({
- complete: currentAddressComplete,
- isNewAddress: false,
- value: currentAddressValue,
- })),
- } as unknown as StripeAddressElement)
- }, [props])
-
- return (
- <div>
- <div data-testid="stripe-address-element" />
- <button
- type="button"
- onClick={() =>
- emitAddressEvent(props, {
- complete: true,
- value: {
- name: 'Updated Company',
- address: {
- line1: '500 Market St',
- line2: '',
- city: 'San Francisco',
- state: 'CA',
- postal_code: '94105',
- country: 'US',
- },
- },
- })
- }
- >
- Emit valid US address
- </button>
- <button
- type="button"
- onClick={() =>
- emitAddressEvent(props, {
- complete: false,
- value: {
- name: 'Updated Company',
- address: {
- line1: '500 Market St',
- line2: '',
- city: 'San Francisco',
- state: 'CA',
- postal_code: '',
- country: 'US',
- },
- },
- })
- }
- >
- Emit invalid address
- </button>
- <button
- type="button"
- onClick={() =>
- emitAddressEvent(props, {
- complete: true,
- value: {
- name: 'Updated GmbH',
- address: {
- line1: 'Stephansplatz 1',
- line2: '',
- city: 'Vienna',
- state: 'Vienna',
- postal_code: '1010',
- country: 'AT',
- },
- },
- })
- }
- >
- Emit valid AT address
- </button>
- <button
- type="button"
- onClick={() => {
- currentAddressValue = {
- name: 'Updated Company',
- address: {
- line1: '500 Market St',
- line2: '',
- city: '',
- state: 'CA',
- postal_code: '94105',
- country: 'US',
- },
- }
- currentAddressComplete = false
- }}
- >
- Make submit validation fail
- </button>
- </div>
- )
- },
- useElements: () => null,
- useStripe: () => null,
-}))
-vi.mock('@stripe/stripe-js', () => ({
- loadStripe: vi.fn(() => Promise.resolve(null)),
-}))
-
-vi.mock('@/lib/constants', async (importOriginal) => {
- const original = (await importOriginal()) as typeof import('@/lib/constants')
- return { ...original, IS_PLATFORM: true }
-})
-
-const mockFlag = vi.fn(() => true)
-vi.mock('common', async (importOriginal) => {
- const original = (await importOriginal()) as typeof import('common')
- return {
- ...original,
- useFlag: (_name: string) => mockFlag(),
- useParams: () => ({ slug: 'test-org' }),
- }
-})
-
-const mockOrg = vi.fn<() => ReturnType<typeof createMockOrganization> | undefined>(() =>
- createMockOrganization({
- slug: 'test-org',
- organization_missing_address: true,
- billing_partner: null,
- })
-)
-vi.mock('@/hooks/misc/useSelectedOrganization', () => ({
- useSelectedOrganizationQuery: () => ({ data: mockOrg() }),
-}))
-
-const mockCanRead = vi.fn(() => true)
-const mockCanWrite = vi.fn(() => true)
-const mockBillingReadLoaded = vi.fn(() => true)
-const mockBillingWriteLoaded = vi.fn(() => true)
-vi.mock('@/hooks/misc/useCheckPermissions', () => ({
- useAsyncCheckPermissions: (action: PermissionAction) =>
- action === PermissionAction.BILLING_READ
- ? {
- can: mockCanRead(),
- isSuccess: mockBillingReadLoaded(),
- }
- : {
- can: mockCanWrite(),
- isSuccess: mockBillingWriteLoaded(),
- },
-}))
-
-const mockCustomerProfile = vi.fn(() => ({
- address: { line1: '', line2: '', city: '', state: '', postal_code: '', country: '' },
- billing_name: '',
-}))
-const mockProfileLoaded = vi.fn(() => true)
-const mockProfileError = vi.fn(() => false)
-vi.mock('@/data/organizations/organization-customer-profile-query', () => ({
- useOrganizationCustomerProfileQuery: () => ({
- data: mockCustomerProfile(),
- isSuccess: mockProfileLoaded(),
- isError: mockProfileError(),
- }),
-}))
-
-const mockTaxId = vi.fn(() => null)
-const mockTaxIdLoaded = vi.fn(() => true)
-const mockTaxIdError = vi.fn(() => false)
-vi.mock('@/data/organizations/organization-tax-id-query', () => ({
- useOrganizationTaxIdQuery: () => ({
- data: mockTaxId(),
- isSuccess: mockTaxIdLoaded(),
- isError: mockTaxIdError(),
- }),
-}))
-
-const mockUpdateCustomerProfile = vi.fn(() => Promise.resolve())
-vi.mock('@/data/organizations/organization-customer-profile-update-mutation', () => ({
- useOrganizationCustomerProfileUpdateMutation: () => ({
- mutateAsync: mockUpdateCustomerProfile,
- }),
-}))
-
-vi.mock('@/data/organizations/organizations-query', () => ({
- invalidateOrganizationsQuery: vi.fn(() => Promise.resolve()),
-}))
-
-describe('UpdateBillingAddressModal', () => {
- beforeEach(() => {
- vi.clearAllMocks()
- currentAddressValue = EMPTY_ADDRESS_VALUE
- currentAddressComplete = false
- mockFlag.mockReturnValue(true)
- mockOrg.mockReturnValue(
- createMockOrganization({
- slug: 'test-org',
- organization_missing_address: true,
- billing_partner: null,
- plan: { id: 'pro', name: 'Pro' },
- })
- )
- mockCanRead.mockReturnValue(true)
- mockCanWrite.mockReturnValue(true)
- mockBillingReadLoaded.mockReturnValue(true)
- mockBillingWriteLoaded.mockReturnValue(true)
- mockProfileLoaded.mockReturnValue(true)
- mockTaxIdLoaded.mockReturnValue(true)
- mockCustomerProfile.mockReturnValue({
- address: { line1: '', line2: '', city: '', state: '', postal_code: '', country: '' },
- billing_name: '',
- })
- mockTaxId.mockReturnValue(null)
- mockProfileError.mockReturnValue(false)
- mockTaxIdError.mockReturnValue(false)
- })
-
- it('renders when all conditions are met', async () => {
- render(<UpdateBillingAddressModal />)
- expect(await screen.findByText('Billing address required')).toBeInTheDocument()
- })
-
- it('does not render when feature flag is off', () => {
- mockFlag.mockReturnValue(false)
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
-
- it('does not render when org has no missing address', () => {
- mockOrg.mockReturnValue(createMockOrganization({ organization_missing_address: false }))
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
-
- it('does not render for free orgs', () => {
- mockOrg.mockReturnValue(
- createMockOrganization({
- organization_missing_address: true,
- plan: { id: 'free', name: 'Free' },
- })
- )
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
-
- it('does not render for partner-managed orgs', () => {
- mockOrg.mockReturnValue(
- createMockOrganization({
- organization_missing_address: true,
- billing_partner: 'vercel_marketplace',
- })
- )
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
-
- it('renders an informational modal when user has read access but no write access', async () => {
- mockCanRead.mockReturnValue(true)
- mockCanWrite.mockReturnValue(false)
- render(<UpdateBillingAddressModal />)
-
- expect(await screen.findByText('Billing address required')).toBeInTheDocument()
- expect(
- screen.getByText(/please ask an organization administrator or owner/i)
- ).toBeInTheDocument()
- expect(screen.queryByRole('button', { name: 'Save address' })).not.toBeInTheDocument()
- })
-
- it('does not render when user lacks both billing read and write permission', () => {
- mockCanRead.mockReturnValue(false)
- mockCanWrite.mockReturnValue(false)
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
-
- it('does not render when no org is selected', () => {
- mockOrg.mockReturnValue(undefined)
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
-
- it('does not render when customer profile query errors', () => {
- mockProfileError.mockReturnValue(true)
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
-
- it('does not render when tax id query errors', () => {
- mockTaxIdError.mockReturnValue(true)
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
-
- it('shows loading shimmer while customer data loads', () => {
- mockProfileLoaded.mockReturnValue(false)
- render(<UpdateBillingAddressModal />)
- expect(screen.queryByText('Save address')).not.toBeInTheDocument()
- })
- it('dismisses on close button click', async () => {
- mockCanRead.mockReturnValue(true)
- mockCanWrite.mockReturnValue(false)
- render(<UpdateBillingAddressModal />)
- expect(await screen.findByText('Billing address required')).toBeInTheDocument()
-
- const closeButton = screen.getByRole('button', { name: /close/i })
- await userEvent.click(closeButton)
-
- await waitFor(() => {
- expect(screen.queryByText('Billing address required')).not.toBeInTheDocument()
- })
- })
-
- it('enables submit after the address element reports a valid change', async () => {
- render(<UpdateBillingAddressModal />)
-
- expect(await screen.findByText('Billing address required')).toBeInTheDocument()
-
- expect(screen.getByRole('button', { name: 'Save address' })).toBeDisabled()
-
- await userEvent.click(screen.getByRole('button', { name: 'Emit valid US address' }))
-
- await waitFor(() => expect(screen.getByRole('button', { name: 'Save address' })).toBeEnabled())
- })
-
- it('filters tax ID options using the current address country', async () => {
- render(<UpdateBillingAddressModal />)
-
- expect(await screen.findByText('Billing address required')).toBeInTheDocument()
-
- await userEvent.click(screen.getByRole('button', { name: 'Emit valid AT address' }))
- await userEvent.click(screen.getByRole('combobox'))
-
- expect(await screen.findByText('Austria - AT VAT')).toBeInTheDocument()
- expect(screen.queryByText('United States - US EIN')).not.toBeInTheDocument()
- })
-
- it('uses getValue on submit to block saving when Stripe validation becomes incomplete', async () => {
- render(<UpdateBillingAddressModal />)
-
- expect(await screen.findByText('Billing address required')).toBeInTheDocument()
-
- await userEvent.click(screen.getByRole('button', { name: 'Emit valid US address' }))
- await waitFor(() => expect(screen.getByRole('button', { name: 'Save address' })).toBeEnabled())
-
- await userEvent.click(screen.getByRole('button', { name: 'Make submit validation fail' }))
- await userEvent.click(screen.getByRole('button', { name: 'Save address' }))
-
- await waitFor(() => {
- expect(mockUpdateCustomerProfile).not.toHaveBeenCalled()
- })
- })
-})
diff --git a/packages/common/constants/local-storage.ts b/packages/common/constants/local-storage.ts
index 66f6f7761aa..0ba915243d4 100644
--- a/packages/common/constants/local-storage.ts
+++ b/packages/common/constants/local-storage.ts
@@ -113,9 +113,6 @@ export const LOCAL_STORAGE_KEYS = {
PROJECT_INTEGRATION_BANNER_DISMISSED: (ref: string, integrationSource: string) =>
`project-integration-banner-dismissed-${ref}-${integrationSource}`,
- // Tax ID banner dismissed
- TAX_ID_BANNER_DISMISSED: (slug: string) => `tax-id-banner-dismissed-${slug}`,
-
TABLE_EDITOR_QUEUE_OPERATIONS_BANNER_DISMISSED: (ref: string) =>
`table-editor-queue-operations-banner-dismissed-${ref}`,
FREE_MICRO_UPGRADE_BANNER_DISMISSED: (ref: string) =>