Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

ref(pipelines): Align handling of credentials (#48896)

Riccardo Busettic3742ba07fd7
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ClickHouse/Fields.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ClickHouse/Fields.tsx
index c1b10977361..429f092eb53 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ClickHouse/Fields.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ClickHouse/Fields.tsx
@@ -19,10 +19,10 @@ import type { DestinationPanelSchemaType } from '../DestinationForm.schema'
export const ClickHouseFields = ({
form,
- hasStoredPassword,
+ editMode,
}: {
form: UseFormReturn<DestinationPanelSchemaType>
- hasStoredPassword: boolean
+ editMode: boolean
}) => {
const [showPassword, setShowPassword] = useState(false)
@@ -75,7 +75,7 @@ export const ClickHouseFields = ({
layout="horizontal"
label="Password"
description={
- hasStoredPassword
+ editMode
? 'Stored password is hidden. Enter a new password to replace it.'
: 'Omit for passwordless access'
}
@@ -84,7 +84,7 @@ export const ClickHouseFields = ({
<PasswordInput
value={field.value ?? ''}
type={showPassword ? 'text' : 'password'}
- placeholder={hasStoredPassword ? STORED_SECRET_PLACEHOLDER : 'Optional'}
+ placeholder={editMode ? STORED_SECRET_PLACEHOLDER : 'Optional'}
onChange={(event) => field.onChange(event.target.value)}
actions={
<div className="flex items-center justify-center">
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/Snowflake/Fields.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/Snowflake/Fields.tsx
index f77d1af4796..40ddcf20bce 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/Snowflake/Fields.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/Snowflake/Fields.tsx
@@ -11,11 +11,9 @@ import type { DestinationPanelSchemaType } from '../DestinationForm.schema'
export const SnowflakeFields = ({
form,
editMode,
- hasStoredPrivateKeyPassphrase,
}: {
form: UseFormReturn<DestinationPanelSchemaType>
editMode: boolean
- hasStoredPrivateKeyPassphrase: boolean
}) => {
const [showPrivateKeyPassphrase, setShowPrivateKeyPassphrase] = useState(false)
@@ -159,7 +157,7 @@ export const SnowflakeFields = ({
layout="horizontal"
label="Private key passphrase"
description={
- hasStoredPrivateKeyPassphrase
+ editMode
? 'Stored passphrase setting is hidden. Enter a new passphrase to replace it.'
: 'Optional passphrase for encrypted private keys'
}
@@ -168,9 +166,7 @@ export const SnowflakeFields = ({
<PasswordInput
value={field.value ?? ''}
type={showPrivateKeyPassphrase ? 'text' : 'password'}
- placeholder={
- hasStoredPrivateKeyPassphrase ? STORED_SECRET_PLACEHOLDER : 'Optional'
- }
+ placeholder={editMode ? STORED_SECRET_PLACEHOLDER : 'Optional'}
onChange={(event) => field.onChange(event.target.value)}
actions={
<div className="flex items-center justify-center">
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx
index 69b6b7b1e8f..5795973fd9f 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx
@@ -524,18 +524,9 @@ export const DestinationForm = ({
) : selectedType === 'DuckLake' && etlEnableDucklake ? (
<DuckLakeFields form={form} editMode={editMode} />
) : selectedType === 'Snowflake' && etlEnableSnowflake ? (
- <SnowflakeFields
- form={form}
- editMode={editMode}
- hasStoredPrivateKeyPassphrase={
- editMode && !!defaultValues.snowflakePrivateKeyPassphrase
- }
- />
+ <SnowflakeFields form={form} editMode={editMode} />
) : selectedType === 'ClickHouse' && etlEnableClickHouse ? (
- <ClickHouseFields
- form={form}
- hasStoredPassword={editMode && !!defaultValues.clickhousePassword}
- />
+ <ClickHouseFields form={form} editMode={editMode} />
) : null}
<DialogSectionSeparator />