Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

chore: add ratchet rules to stop nesting components (#42962)

Ali Waseemc57c341244b2
diff --git a/apps/studio/.github/eslint-rule-baselines.json b/apps/studio/.github/eslint-rule-baselines.json
index 2fa5dbaf55a..c18c10191a8 100644
--- a/apps/studio/.github/eslint-rule-baselines.json
+++ b/apps/studio/.github/eslint-rule-baselines.json
@@ -4,8 +4,9 @@
"import/no-anonymous-default-export": 57,
"@tanstack/query/exhaustive-deps": 13,
"@typescript-eslint/no-explicit-any": 1215,
- "no-restricted-exports": 301,
- "no-restricted-imports": 59
+ "no-restricted-imports": 59,
+ "no-restricted-exports": 300,
+ "react/no-unstable-nested-components": 69
},
"ruleFiles": {
"react-hooks/exhaustive-deps": {
@@ -737,6 +738,65 @@
"types/next.ts": 2,
"types/ui.ts": 2
},
+ "no-restricted-imports": {
+ "components/grid/SupabaseGrid.tsx": 1,
+ "components/grid/SupabaseGrid.utils.ts": 1,
+ "components/grid/components/common/Shortcuts.tsx": 1,
+ "components/grid/components/editor/BooleanEditor.tsx": 1,
+ "components/grid/components/editor/DateTimeEditor.tsx": 1,
+ "components/grid/components/editor/JsonEditor.tsx": 1,
+ "components/grid/components/editor/NumberEditor.tsx": 1,
+ "components/grid/components/editor/SelectEditor.tsx": 1,
+ "components/grid/components/editor/TextEditor.tsx": 1,
+ "components/grid/components/editor/TimeEditor.tsx": 1,
+ "components/grid/components/formatter/BinaryFormatter.tsx": 1,
+ "components/grid/components/formatter/BooleanFormatter.tsx": 1,
+ "components/grid/components/formatter/DefaultFormatter.tsx": 1,
+ "components/grid/components/formatter/ForeignKeyFormatter.tsx": 1,
+ "components/grid/components/formatter/JsonFormatter.tsx": 1,
+ "components/grid/components/formatter/ReferenceRecordPeek.tsx": 1,
+ "components/grid/components/grid/AddColumn.tsx": 1,
+ "components/grid/components/grid/Grid.tsx": 1,
+ "components/grid/components/grid/Grid.utils.tsx": 1,
+ "components/grid/components/grid/RowRenderer.tsx": 2,
+ "components/grid/components/grid/SelectColumn.tsx": 1,
+ "components/grid/components/menu/ColumnMenu.tsx": 1,
+ "components/grid/components/menu/RowContextMenu.tsx": 1,
+ "components/grid/types/base.ts": 1,
+ "components/grid/utils/column.ts": 1,
+ "components/grid/utils/gridColumns.tsx": 1,
+ "components/interfaces/Auth/Users/Users.utils.tsx": 1,
+ "components/interfaces/Auth/Users/UsersGridComponents.tsx": 1,
+ "components/interfaces/Auth/Users/UsersV2.tsx": 1,
+ "components/interfaces/Integrations/CronJobs/CronJobs.utils.tsx": 1,
+ "components/interfaces/Integrations/CronJobs/CronJobsTab.DataGrid.tsx": 1,
+ "components/interfaces/Integrations/CronJobs/PreviousRunsTab.tsx": 1,
+ "components/interfaces/Integrations/Queues/Queues.utils.tsx": 1,
+ "components/interfaces/Integrations/Queues/QueuesTab.tsx": 1,
+ "components/interfaces/Integrations/Queues/SingleQueue/QueueDataGrid.tsx": 1,
+ "components/interfaces/Integrations/Vault/Secrets/Secrets.utils.tsx": 1,
+ "components/interfaces/Integrations/Vault/Secrets/SecretsManagement.tsx": 1,
+ "components/interfaces/Linter/LinterDataGrid.tsx": 1,
+ "components/interfaces/QueryPerformance/QueryPerformanceGrid.tsx": 1,
+ "components/interfaces/Realtime/Inspector/MessagesTable.tsx": 1,
+ "components/interfaces/Realtime/Inspector/RealtimeMessageColumnRenderer.tsx": 1,
+ "components/interfaces/SQLEditor/UtilityPanel/Results.tsx": 1,
+ "components/interfaces/Settings/Logs/LogColumnRenderers/AuthColumnRenderer.tsx": 1,
+ "components/interfaces/Settings/Logs/LogColumnRenderers/DatabaseApiColumnRender.tsx": 1,
+ "components/interfaces/Settings/Logs/LogColumnRenderers/DatabasePostgresColumnRender.tsx": 1,
+ "components/interfaces/Settings/Logs/LogColumnRenderers/DefaultPreviewColumnRenderer.tsx": 1,
+ "components/interfaces/Settings/Logs/LogColumnRenderers/FunctionsEdgeColumnRender.tsx": 1,
+ "components/interfaces/Settings/Logs/LogColumnRenderers/FunctionsLogsColumnRender.tsx": 1,
+ "components/interfaces/Settings/Logs/LogTable.tsx": 2,
+ "components/interfaces/Storage/StorageExplorer/ColumnContextMenu.tsx": 1,
+ "components/interfaces/Storage/StorageExplorer/FileExplorerColumn.tsx": 1,
+ "components/interfaces/Storage/StorageExplorer/FileExplorerRow.tsx": 1,
+ "components/interfaces/Storage/StorageExplorer/FolderContextMenu.tsx": 1,
+ "components/interfaces/Storage/StorageExplorer/ItemContextMenu.tsx": 1,
+ "components/interfaces/TableGridEditor/SidePanelEditor/RowEditor/ForeignRowSelector/SelectorGrid.tsx": 1,
+ "components/interfaces/TableGridEditor/SidePanelEditor/SpreadsheetImport/SpreadsheetPreviewGrid.tsx": 1,
+ "state/table-editor-table.tsx": 1
+ },
"no-restricted-exports": {
"__mocks__/hooks/analytics/useFillTimeseriesSorted.ts": 1,
"__mocks__/hooks/analytics/useLogsQuery.ts": 1,
@@ -1037,67 +1097,55 @@
"hooks/misc/useLatest.ts": 1,
"lib/api/apiWrapper.ts": 1,
"lib/pingPostgrest.ts": 1,
- "scripts/codegen.ts": 1,
- "vitest.config.ts": 1
+ "scripts/codegen.ts": 1
},
- "no-restricted-imports": {
- "components/grid/SupabaseGrid.tsx": 1,
- "components/grid/SupabaseGrid.utils.ts": 1,
- "components/grid/components/common/Shortcuts.tsx": 1,
- "components/grid/components/editor/BooleanEditor.tsx": 1,
- "components/grid/components/editor/DateTimeEditor.tsx": 1,
- "components/grid/components/editor/JsonEditor.tsx": 1,
- "components/grid/components/editor/NumberEditor.tsx": 1,
- "components/grid/components/editor/SelectEditor.tsx": 1,
- "components/grid/components/editor/TextEditor.tsx": 1,
- "components/grid/components/editor/TimeEditor.tsx": 1,
- "components/grid/components/formatter/BinaryFormatter.tsx": 1,
- "components/grid/components/formatter/BooleanFormatter.tsx": 1,
- "components/grid/components/formatter/DefaultFormatter.tsx": 1,
- "components/grid/components/formatter/ForeignKeyFormatter.tsx": 1,
- "components/grid/components/formatter/JsonFormatter.tsx": 1,
- "components/grid/components/formatter/ReferenceRecordPeek.tsx": 1,
- "components/grid/components/grid/AddColumn.tsx": 1,
- "components/grid/components/grid/Grid.tsx": 1,
- "components/grid/components/grid/Grid.utils.tsx": 1,
- "components/grid/components/grid/RowRenderer.tsx": 2,
- "components/grid/components/grid/SelectColumn.tsx": 1,
- "components/grid/components/menu/ColumnMenu.tsx": 1,
- "components/grid/components/menu/RowContextMenu.tsx": 1,
- "components/grid/types/base.ts": 1,
- "components/grid/utils/column.ts": 1,
- "components/grid/utils/gridColumns.tsx": 1,
- "components/interfaces/Auth/Users/Users.utils.tsx": 1,
- "components/interfaces/Auth/Users/UsersGridComponents.tsx": 1,
- "components/interfaces/Auth/Users/UsersV2.tsx": 1,
- "components/interfaces/Integrations/CronJobs/CronJobs.utils.tsx": 1,
- "components/interfaces/Integrations/CronJobs/CronJobsTab.DataGrid.tsx": 1,
- "components/interfaces/Integrations/CronJobs/PreviousRunsTab.tsx": 1,
- "components/interfaces/Integrations/Queues/Queues.utils.tsx": 1,
- "components/interfaces/Integrations/Queues/QueuesTab.tsx": 1,
- "components/interfaces/Integrations/Queues/SingleQueue/QueueDataGrid.tsx": 1,
- "components/interfaces/Integrations/Vault/Secrets/Secrets.utils.tsx": 1,
- "components/interfaces/Integrations/Vault/Secrets/SecretsManagement.tsx": 1,
- "components/interfaces/Linter/LinterDataGrid.tsx": 1,
- "components/interfaces/QueryPerformance/QueryPerformanceGrid.tsx": 1,
- "components/interfaces/Realtime/Inspector/MessagesTable.tsx": 1,
- "components/interfaces/Realtime/Inspector/RealtimeMessageColumnRenderer.tsx": 1,
- "components/interfaces/SQLEditor/UtilityPanel/Results.tsx": 1,
- "components/interfaces/Settings/Logs/LogColumnRenderers/AuthColumnRenderer.tsx": 1,
- "components/interfaces/Settings/Logs/LogColumnRenderers/DatabaseApiColumnRender.tsx": 1,
- "components/interfaces/Settings/Logs/LogColumnRenderers/DatabasePostgresColumnRender.tsx": 1,
- "components/interfaces/Settings/Logs/LogColumnRenderers/DefaultPreviewColumnRenderer.tsx": 1,
- "components/interfaces/Settings/Logs/LogColumnRenderers/FunctionsEdgeColumnRender.tsx": 1,
- "components/interfaces/Settings/Logs/LogColumnRenderers/FunctionsLogsColumnRender.tsx": 1,
- "components/interfaces/Settings/Logs/LogTable.tsx": 2,
- "components/interfaces/Storage/StorageExplorer/ColumnContextMenu.tsx": 1,
+ "react/no-unstable-nested-components": {
+ "components/grid/components/header/filter/FilterPopoverNew.tsx": 1,
+ "components/interfaces/Account/Preferences/ThemeSettings.tsx": 1,
+ "components/interfaces/App/CommandMenu/ContextSearchResults.shared.tsx": 1,
+ "components/interfaces/Auth/AuthProvidersForm/FormField.tsx": 1,
+ "components/interfaces/Connect/ConnectTabContent.tsx": 1,
+ "components/interfaces/ConnectSheet/ConnectStepsSection.tsx": 1,
+ "components/interfaces/Database/Migrations/MigrationsEmptyState.tsx": 3,
+ "components/interfaces/Functions/EdgeFunctionDetails/EdgeFunctionDetails.tsx": 1,
+ "components/interfaces/Functions/TerminalInstructions.tsx": 3,
+ "components/interfaces/Integrations/VercelGithub/IntegrationPanels.tsx": 1,
+ "components/interfaces/Integrations/VercelGithub/ProjectLinker.tsx": 1,
+ "components/interfaces/Integrations/Wrappers/WrapperTableEditor.tsx": 2,
+ "components/interfaces/Linter/LintPageTabs.tsx": 1,
+ "components/interfaces/Linter/LinterDataGrid.tsx": 3,
+ "components/interfaces/Markdown.tsx": 3,
+ "components/interfaces/Organization/BillingSettings/Subscription/PaymentMethodSelection.tsx": 1,
+ "components/interfaces/Organization/IntegrationSettings/IntegrationSettings.tsx": 1,
+ "components/interfaces/Organization/Usage/UsageBarChart.tsx": 1,
+ "components/interfaces/ProjectAPIDocs/FirstLevelNav.tsx": 1,
+ "components/interfaces/Settings/General/TransferProjectPanel/TransferProjectButton.tsx": 1,
+ "components/interfaces/Settings/Infrastructure/InfrastructureConfiguration/DeployNewReplicaPanel.tsx": 1,
+ "components/interfaces/Settings/Logs/LogSelection.tsx": 1,
+ "components/interfaces/Settings/Logs/LogTable.tsx": 3,
+ "components/interfaces/Settings/Logs/LogsFormatters.tsx": 2,
+ "components/interfaces/Settings/Logs/PreviewFilterPanelWithUniversal.tsx": 1,
"components/interfaces/Storage/StorageExplorer/FileExplorerColumn.tsx": 1,
- "components/interfaces/Storage/StorageExplorer/FileExplorerRow.tsx": 1,
- "components/interfaces/Storage/StorageExplorer/FolderContextMenu.tsx": 1,
- "components/interfaces/Storage/StorageExplorer/ItemContextMenu.tsx": 1,
- "components/interfaces/TableGridEditor/SidePanelEditor/RowEditor/ForeignRowSelector/SelectorGrid.tsx": 1,
- "components/interfaces/TableGridEditor/SidePanelEditor/SpreadsheetImport/SpreadsheetPreviewGrid.tsx": 1,
- "state/table-editor-table.tsx": 1
+ "components/interfaces/Storage/StoragePolicies/StoragePoliciesEditPolicyModal.tsx": 1,
+ "components/interfaces/TableGridEditor/SidePanelEditor/ForeignKeySelector/ForeignKeySelector.tsx": 2,
+ "components/interfaces/UnifiedLogs/components/LogTypeIcon.tsx": 5,
+ "components/layouts/ProjectLayout/LayoutHeader/FeedbackDropdown/FeedbackWidget.tsx": 1,
+ "components/layouts/ProjectLayout/NavigationBar/NavigationIconLink.tsx": 1,
+ "components/layouts/SQLEditorLayout/SQLEditorNavV2/SQLEditorNav.tsx": 3,
+ "components/layouts/SQLEditorLayout/SQLEditorNavV2/SearchList.tsx": 1,
+ "components/ui/AIAssistantPanel/MessageMarkdown.tsx": 1,
+ "components/ui/CardButton.tsx": 1,
+ "components/ui/Charts/AreaChart.tsx": 1,
+ "components/ui/Charts/BarChart.tsx": 1,
+ "components/ui/Charts/ComposedChart.tsx": 2,
+ "components/ui/Charts/ComposedChart.utils.tsx": 3,
+ "components/ui/ErrorBoundary/ErrorBoundary.tsx": 1,
+ "components/ui/FileExplorerAndEditor/index.tsx": 1,
+ "components/ui/NoPermission.tsx": 1,
+ "components/ui/SqlEditor.tsx": 1,
+ "pages/integrations/vercel/[slug]/deploy-button/new-project.tsx": 1,
+ "pages/project/[ref]/integrations/index.tsx": 2,
+ "pages/project/[ref]/observability/database.tsx": 1
}
}
}
diff --git a/apps/studio/components/interfaces/Auth/AuthProvidersForm/FormField.tsx b/apps/studio/components/interfaces/Auth/AuthProvidersForm/FormField.tsx
index 2058ae821f7..3baabe74351 100644
--- a/apps/studio/components/interfaces/Auth/AuthProvidersForm/FormField.tsx
+++ b/apps/studio/components/interfaces/Auth/AuthProvidersForm/FormField.tsx
@@ -1,13 +1,13 @@
+import { Markdown } from 'components/interfaces/Markdown'
+import { DatePicker } from 'components/ui/DatePicker'
import dayjs from 'dayjs'
+import { BASE_PATH } from 'lib/constants'
import { Eye, EyeOff } from 'lucide-react'
import { useEffect, useState } from 'react'
import ReactMarkdown from 'react-markdown'
-
-import { Markdown } from 'components/interfaces/Markdown'
-import { DatePicker } from 'components/ui/DatePicker'
-import { BASE_PATH } from 'lib/constants'
import { Button, Input, InputNumber, Listbox, Toggle } from 'ui'
import { InfoTooltip } from 'ui-patterns/info-tooltip'
+
import type { Enum } from './AuthProvidersForm.types'
interface FormFieldProps {
@@ -269,7 +269,11 @@ const FormField = ({
value={option.value}
addOnBefore={() => {
return option.icon ? (
- <img className="h-6 w-6" src={`${BASE_PATH}/img/icons/${option.icon}`} />
+ <img
+ alt={`${option.label} icon`}
+ className="h-6 w-6"
+ src={`${BASE_PATH}/img/icons/${option.icon}`}
+ />
) : null
}}
>
diff --git a/apps/studio/eslint.config.cjs b/apps/studio/eslint.config.cjs
index e393c047942..64ced45988d 100644
--- a/apps/studio/eslint.config.cjs
+++ b/apps/studio/eslint.config.cjs
@@ -15,8 +15,10 @@ module.exports = defineConfig([
'@next/next/no-img-element': 'off',
'react/no-unescaped-entities': 'off',
'react/display-name': 'warn',
+ 'react/no-unstable-nested-components': 'warn',
'react/jsx-key': 'error',
'barrel-files/avoid-re-export-all': 'error',
+ 'jsx-a11y/alt-text': 'warn',
'jsx-a11y/role-has-required-aria-props': 'error',
},
},
diff --git a/apps/studio/package.json b/apps/studio/package.json
index 6fb012a63d3..90bf696ee9d 100644
--- a/apps/studio/package.json
+++ b/apps/studio/package.json
@@ -8,7 +8,7 @@
"build": "next build && if [ \"$SKIP_ASSET_UPLOAD\" != \"1\" ]; then ./../../scripts/upload-static-assets.sh; fi",
"start": "next start -p 8082",
"lint": "eslint .",
- "lint:ratchet": "tsx scripts/ratchet-eslint-rules.ts --rule react-hooks/exhaustive-deps --rule import/no-anonymous-default-export --rule @tanstack/query/exhaustive-deps --rule @typescript-eslint/no-explicit-any --rule no-restricted-imports --rule no-restricted-exports",
+ "lint:ratchet": "tsx scripts/ratchet-eslint-rules.ts --rule react-hooks/exhaustive-deps --rule import/no-anonymous-default-export --rule @tanstack/query/exhaustive-deps --rule @typescript-eslint/no-explicit-any --rule no-restricted-imports --rule no-restricted-exports --rule react/no-unstable-nested-components",
"clean": "rimraf node_modules tsconfig.tsbuildinfo .next .turbo",
"test": "vitest --run --coverage",
"test:watch": "vitest watch",