Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

Add skeleton loader for unified logs chart (#46460)

Joshen Limcbdd8b9b80c1
diff --git a/apps/studio/components/interfaces/UnifiedLogs/UnifiedLogs.tsx b/apps/studio/components/interfaces/UnifiedLogs/UnifiedLogs.tsx
index 18096f8d8f6..80d10eadce4 100644
--- a/apps/studio/components/interfaces/UnifiedLogs/UnifiedLogs.tsx
+++ b/apps/studio/components/interfaces/UnifiedLogs/UnifiedLogs.tsx
@@ -14,7 +14,7 @@ import {
VisibilityState,
} from '@tanstack/react-table'
import { LOCAL_STORAGE_KEYS, useDebounce, useParams } from 'common'
-import { PanelLeftClose, PanelLeftOpen } from 'lucide-react'
+import { Loader2, PanelLeftClose, PanelLeftOpen } from 'lucide-react'
import { useQueryStates } from 'nuqs'
import { useEffect, useMemo, useRef, useState } from 'react'
import {
@@ -426,16 +426,22 @@ export const UnifiedLogs = () => {
</div>
</div>
- <TimelineChart
- data={unifiedLogsChart}
- className={cn(
- '-mb-1.5 mt-1.5',
- isFetchingCharts && 'opacity-60 transition-opacity duration-150'
- )}
- columnId="timestamp"
- filterColumnId="date"
- chartConfig={filteredChartConfig}
- />
+ {isLoading ? (
+ <div className="h-[60px] flex items-center justify-center">
+ <Loader2 size={14} className="animate-spin text-foreground-lighter" />
+ </div>
+ ) : (
+ <TimelineChart
+ data={unifiedLogsChart}
+ className={cn(
+ '-mb-1.5 mt-1.5',
+ isFetchingCharts && 'opacity-60 transition-opacity duration-150'
+ )}
+ columnId="timestamp"
+ filterColumnId="date"
+ chartConfig={filteredChartConfig}
+ />
+ )}
</div>
<RowSelectionHeader />
diff --git a/apps/studio/components/ui/DataTable/DataTableInfinite.tsx b/apps/studio/components/ui/DataTable/DataTableInfinite.tsx
index 2656050405f..d25c4fa3ba2 100644
--- a/apps/studio/components/ui/DataTable/DataTableInfinite.tsx
+++ b/apps/studio/components/ui/DataTable/DataTableInfinite.tsx
@@ -21,8 +21,6 @@ export interface DataTableInfiniteProps<TData, TValue, _TMeta> {
totalRows?: number
filterRows?: number
totalRowsFetched?: number
- isFetching?: boolean
- isLoading?: boolean
hasNextPage?: boolean
fetchNextPage: (options?: FetchNextPageOptions | undefined) => Promise<unknown>
setColumnOrder: (columnOrder: string[]) => void