Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix: ESLint errors relating to accessibility (alt attribute and tableEditor components) (#48186)

ChloeGarciaMillerandda847254d56c
diff --git a/apps/studio/compat/next/image.tsx b/apps/studio/compat/next/image.tsx
index c0a931a7041..254c15d1750 100644
--- a/apps/studio/compat/next/image.tsx
+++ b/apps/studio/compat/next/image.tsx
@@ -135,6 +135,8 @@ const Image = forwardRef(function Image(
: style
return (
+ // alt is spread with rest
+ // eslint-disable-next-line jsx-a11y/alt-text
<img
{...rest}
ref={(node) => {
diff --git a/apps/studio/compat/next/legacy/image.tsx b/apps/studio/compat/next/legacy/image.tsx
index da45e196ca3..e5d657cdd8e 100644
--- a/apps/studio/compat/next/legacy/image.tsx
+++ b/apps/studio/compat/next/legacy/image.tsx
@@ -140,6 +140,8 @@ const Image = forwardRef(function Image(
: undefined
return (
+ // alt is spread with rest
+ // eslint-disable-next-line jsx-a11y/alt-text
<img
{...rest}
ref={(node) => {
diff --git a/apps/studio/components/grid/components/editor/DateTimeEditor.tsx b/apps/studio/components/grid/components/editor/DateTimeEditor.tsx
index 741bd38c464..ba286d13537 100644
--- a/apps/studio/components/grid/components/editor/DateTimeEditor.tsx
+++ b/apps/studio/components/grid/components/editor/DateTimeEditor.tsx
@@ -12,6 +12,9 @@ import {
Popover,
PopoverContent,
PopoverTrigger,
+ Tooltip,
+ TooltipContent,
+ TooltipTrigger,
} from 'ui'
import { Input } from 'ui-patterns/DataInputs/Input'
import { TimestampInfo, timestampLocalFormatter } from 'ui-patterns/TimestampInfo'
@@ -149,13 +152,19 @@ function BaseEditor<TRow, TSummaryRow = unknown>({
Set NULL
</Button>
<DropdownMenu>
- <DropdownMenuTrigger asChild>
- <Button
- variant="default"
- icon={<ChevronDown />}
- className="px-1 rounded-l-none border-l-0"
- />
- </DropdownMenuTrigger>
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <DropdownMenuTrigger asChild>
+ <Button
+ aria-label="Date options"
+ variant="default"
+ icon={<ChevronDown />}
+ className="px-1 rounded-l-none border-l-0"
+ />
+ </DropdownMenuTrigger>
+ </TooltipTrigger>
+ <TooltipContent side="bottom">Date options</TooltipContent>
+ </Tooltip>
<DropdownMenuContent className="w-20" align="end">
<DropdownMenuItem onClick={setToNow}>Set to NOW</DropdownMenuItem>
</DropdownMenuContent>
diff --git a/apps/studio/components/grid/components/editor/NumberEditor.tsx b/apps/studio/components/grid/components/editor/NumberEditor.tsx
index 3d5ed3866f1..3ea19bf9b75 100644
--- a/apps/studio/components/grid/components/editor/NumberEditor.tsx
+++ b/apps/studio/components/grid/components/editor/NumberEditor.tsx
@@ -31,6 +31,7 @@ export function NumberEditor<TRow, TSummaryRow = unknown>({
onChange={onChange}
onBlur={onBlur}
type="number"
+ aria-label={`${column.name} value`}
/>
)
}
diff --git a/apps/studio/components/grid/components/footer/pagination/Pagination.tsx b/apps/studio/components/grid/components/footer/pagination/Pagination.tsx
index 49933019828..cd905fdeb60 100644
--- a/apps/studio/components/grid/components/footer/pagination/Pagination.tsx
+++ b/apps/studio/components/grid/components/footer/pagination/Pagination.tsx
@@ -1,7 +1,7 @@
import { THRESHOLD_COUNT } from '@supabase/pg-meta'
import { keepPreviousData } from '@tanstack/react-query'
import { useParams } from 'common'
-import { AlertCircle, ArrowLeft, ArrowRight, HelpCircle, Loader2 } from 'lucide-react'
+import { AlertCircle, ArrowLeft, ArrowRight, HelpCircle } from 'lucide-react'
import { useEffect, useRef, useState } from 'react'
import { Button, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
import { Input } from 'ui-patterns/DataInputs/Input'
@@ -295,11 +295,7 @@ export const Pagination = ({ enableForeignRowsQuery = true }: PaginationProps) =
</div>
{isLoading ? (
- <Button
- variant="text"
- className="w-7"
- icon={<Loader2 size={12} className="animate-spin" />}
- />
+ <Button variant="text" className="w-7" loading aria-label="Get exact row count" />
) : isError ? (
<Tooltip>
<TooltipTrigger asChild>
@@ -309,6 +305,8 @@ export const Pagination = ({ enableForeignRowsQuery = true }: PaginationProps) =
className="w-7"
loading={isFetching}
icon={<AlertCircle />}
+ aria-label="Get exact row count"
+ disabled
/>
</TooltipTrigger>
<TooltipContent side="top">Failed to retrieve count: {error?.message}</TooltipContent>
@@ -331,6 +329,7 @@ export const Pagination = ({ enableForeignRowsQuery = true }: PaginationProps) =
className="w-7"
loading={isFetching}
icon={<HelpCircle />}
+ aria-label="Get exact row count"
onClick={() => {
// Show warning if either NOT a table entity, or table rows estimate is beyond threshold
if (rowsCountEstimate === null || count === -1 || count > THRESHOLD_COUNT) {