Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix: ESLint errors relating to accessibility in table editor, API Key and Access Token (#48479)

ChloeGarciaMillerande241a21a9ac4
diff --git a/apps/studio/components/grid/components/header/filter/FilterRow.tsx b/apps/studio/components/grid/components/header/filter/FilterRow.tsx
index 6881a292dd0..09283e041ed 100644
--- a/apps/studio/components/grid/components/header/filter/FilterRow.tsx
+++ b/apps/studio/components/grid/components/header/filter/FilterRow.tsx
@@ -1,6 +1,6 @@
import { ChevronDown, X } from 'lucide-react'
import { KeyboardEvent, memo } from 'react'
-import { Button, Input } from 'ui'
+import { Button, Input, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
import { FilterOperatorOptions } from './Filter.constants'
import { DropdownControl } from '@/components/grid/components/common/DropdownControl'
@@ -93,12 +93,18 @@ const FilterRow = ({ filter, filterIdx, onChange, onDelete, onKeyDown }: FilterR
}
onKeyDown={onKeyDown}
/>
- <Button
- variant="text"
- className="px-1"
- icon={<X strokeWidth={1.5} />}
- onClick={() => onDelete(filterIdx)}
- />
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <Button
+ variant="text"
+ className="px-1"
+ icon={<X strokeWidth={1.5} />}
+ onClick={() => onDelete(filterIdx)}
+ aria-label="Remove filter"
+ />
+ </TooltipTrigger>
+ <TooltipContent side="bottom">Remove filter</TooltipContent>
+ </Tooltip>
</div>
)
}
diff --git a/apps/studio/components/grid/components/header/sort/SortRow.tsx b/apps/studio/components/grid/components/header/sort/SortRow.tsx
index 61642b4de27..23a737c3bd8 100644
--- a/apps/studio/components/grid/components/header/sort/SortRow.tsx
+++ b/apps/studio/components/grid/components/header/sort/SortRow.tsx
@@ -2,7 +2,7 @@ import { useSortable } from '@dnd-kit/sortable'
import { CSS } from '@dnd-kit/utilities'
import { GripVertical, X } from 'lucide-react'
import { memo } from 'react'
-import { Button, Switch } from 'ui'
+import { Button, Switch, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
import type { Sort } from '@/components/grid/types'
import { useTableEditorTableStateSnapshot } from '@/state/table-editor-table'
@@ -53,19 +53,26 @@ const SortRow = ({ index, columnName, sort, onDelete, onToggle }: SortRowProps)
</span>
</div>
<div className="flex items-center gap-x-1.5">
- <label className="text-xs text-foreground-lighter">ascending:</label>
+ <span className="text-xs text-foreground-lighter">ascending:</span>
<Switch
defaultChecked={sort.ascending}
onCheckedChange={(e: boolean) => onToggle(columnName, e)}
+ aria-label={`Sort ${column.name} in ascending order`}
/>
</div>
- <Button
- icon={<X strokeWidth={1.5} />}
- size="tiny"
- variant="text"
- className="w-7"
- onClick={() => onDelete(columnName)}
- />
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <Button
+ icon={<X strokeWidth={1.5} />}
+ size="tiny"
+ variant="text"
+ className="w-7"
+ onClick={() => onDelete(columnName)}
+ aria-label={`Remove sort for ${column.name}`}
+ />
+ </TooltipTrigger>
+ <TooltipContent side="bottom">Remove sort</TooltipContent>
+ </Tooltip>
</div>
)
}
diff --git a/apps/studio/components/interfaces/APIKeys/APIKeyRow.tsx b/apps/studio/components/interfaces/APIKeys/APIKeyRow.tsx
index 6ba579816b0..ad6ed5b11c3 100644
--- a/apps/studio/components/interfaces/APIKeys/APIKeyRow.tsx
+++ b/apps/studio/components/interfaces/APIKeys/APIKeyRow.tsx
@@ -8,6 +8,9 @@ import {
DropdownMenuTrigger,
TableCell,
TableRow,
+ Tooltip,
+ TooltipContent,
+ TooltipTrigger,
} from 'ui'
import { APIKeyDeleteDialog } from './APIKeyDeleteDialog'
@@ -63,18 +66,24 @@ export const APIKeyRow = ({
<TableCell className="py-2">
<div className="flex justify-end">
<DropdownMenu>
- <DropdownMenuTrigger className="px-1 focus-visible:outline-hidden" asChild>
- <Button
- variant="text"
- size="tiny"
- icon={
- <MoreVertical
- size="14"
- className="text-foreground-light hover:text-foreground"
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <DropdownMenuTrigger className="px-1 focus-visible:outline-hidden" asChild>
+ <Button
+ aria-label={`More actions for API key ${apiKey.name}`}
+ variant="text"
+ size="tiny"
+ icon={
+ <MoreVertical
+ size="14"
+ className="text-foreground-light hover:text-foreground"
+ />
+ }
/>
- }
- />
- </DropdownMenuTrigger>
+ </DropdownMenuTrigger>
+ </TooltipTrigger>
+ <TooltipContent side="bottom">More actions for API key</TooltipContent>
+ </Tooltip>
<DropdownMenuContent className="max-w-40" align="end">
<APIKeyDeleteDialog apiKey={apiKey} setKeyToDelete={setKeyToDelete} />
</DropdownMenuContent>
diff --git a/apps/studio/components/interfaces/Account/AccessTokens/AccessTokenNewBanner/AccessTokenNewBanner.tsx b/apps/studio/components/interfaces/Account/AccessTokens/AccessTokenNewBanner/AccessTokenNewBanner.tsx
index 5bdf04db702..a90349a49cd 100644
--- a/apps/studio/components/interfaces/Account/AccessTokens/AccessTokenNewBanner/AccessTokenNewBanner.tsx
+++ b/apps/studio/components/interfaces/Account/AccessTokens/AccessTokenNewBanner/AccessTokenNewBanner.tsx
@@ -1,6 +1,6 @@
import { X } from 'lucide-react'
import { toast } from 'sonner'
-import { Button } from 'ui'
+import { Button, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
import { Admonition } from 'ui-patterns/Admonition'
import { Input } from 'ui-patterns/DataInputs/Input'
@@ -33,12 +33,18 @@ export const AccessTokenNewBanner = <T,>({
title={title}
className="mb-6 relative"
actions={
- <Button
- variant="text"
- icon={<X />}
- className="w-7 h-7 absolute top-2.5 right-2.5"
- onClick={onClose}
- />
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <Button
+ variant="text"
+ aria-label="Close token banner"
+ icon={<X />}
+ className="w-7 h-7 absolute top-2.5 right-2.5"
+ onClick={onClose}
+ />
+ </TooltipTrigger>
+ <TooltipContent side="bottom">Close token banner</TooltipContent>
+ </Tooltip>
}
>
<div className="space-y-4">
diff --git a/apps/studio/components/interfaces/Account/AccessTokens/Classic/NewTokenButton.tsx b/apps/studio/components/interfaces/Account/AccessTokens/Classic/NewTokenButton.tsx
index 15c8a674e96..3d3322f7989 100644
--- a/apps/studio/components/interfaces/Account/AccessTokens/Classic/NewTokenButton.tsx
+++ b/apps/studio/components/interfaces/Account/AccessTokens/Classic/NewTokenButton.tsx
@@ -6,6 +6,9 @@ import {
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
+ Tooltip,
+ TooltipContent,
+ TooltipTrigger,
} from 'ui'
import { NewTokenDialog } from './NewTokenDialog'
@@ -32,14 +35,19 @@ export const NewTokenButton = ({ onCreateToken }: NewAccessTokenButtonProps) =>
Generate new token
</Button>
<DropdownMenu>
- <DropdownMenuTrigger asChild>
- <Button
- variant="primary"
- title="Choose token scope"
- className="rounded-l-none px-[4px] py-[5px]"
- icon={<ChevronDown />}
- />
- </DropdownMenuTrigger>
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <DropdownMenuTrigger asChild>
+ <Button
+ variant="primary"
+ aria-label="Choose token scope"
+ className="rounded-l-none px-[4px] py-[5px]"
+ icon={<ChevronDown />}
+ />
+ </DropdownMenuTrigger>
+ </TooltipTrigger>
+ <TooltipContent side="bottom">Choose token scope</TooltipContent>
+ </Tooltip>
<DropdownMenuContent align="end" side="bottom">
<DropdownMenuItem
key="experimental-token"
diff --git a/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/RowEditor/ForeignRowSelector/ForeignRowSelector.tsx b/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/RowEditor/ForeignRowSelector/ForeignRowSelector.tsx
index 25d3c723184..a91f061177f 100644
--- a/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/RowEditor/ForeignRowSelector/ForeignRowSelector.tsx
+++ b/apps/studio/components/interfaces/TableGridEditor/SidePanelEditor/RowEditor/ForeignRowSelector/ForeignRowSelector.tsx
@@ -2,7 +2,7 @@ import { keepPreviousData } from '@tanstack/react-query'
import { useParams } from 'common'
import { Loader2, X } from 'lucide-react'
import { useEffect, useState } from 'react'
-import { Button, SidePanel } from 'ui'
+import { Button, SidePanel, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
import { ForeignKey } from '../../ForeignKeySelector/ForeignKeySelector.types'
import { convertByteaToHex } from '../RowEditor.utils'
@@ -175,7 +175,18 @@ export const ForeignRowSelector = ({
<p className="text-xs text-foreground-light">Saving</p>
</div>
)}
- <Button variant="text" icon={<X />} className="w-7" onClick={closePanel} />
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <Button
+ variant="text"
+ icon={<X />}
+ className="w-7"
+ onClick={closePanel}
+ aria-label="Close panel"
+ />
+ </TooltipTrigger>
+ <TooltipContent side="bottom">Close panel</TooltipContent>
+ </Tooltip>
</div>
</div>
}