Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

Joshen/debug 76 fix sticky hover state on log rows (#45933)

Joshen Limeb915e99f830
diff --git a/apps/studio/components/interfaces/UnifiedLogs/ServiceFlowPanel.tsx b/apps/studio/components/interfaces/UnifiedLogs/ServiceFlowPanel.tsx
index 2c9414f3336..3029481f7b1 100644
--- a/apps/studio/components/interfaces/UnifiedLogs/ServiceFlowPanel.tsx
+++ b/apps/studio/components/interfaces/UnifiedLogs/ServiceFlowPanel.tsx
@@ -113,7 +113,7 @@ export function ServiceFlowPanel({
<ResizablePanel
id="log-sidepanel"
defaultSize={400}
- minSize={300}
+ minSize={dock === 'bottom' ? 300 : 400}
className="bg-dash-sidebar"
>
<div className="flex h-full flex-col overflow-hidden">
diff --git a/apps/studio/components/interfaces/UnifiedLogs/UnifiedLogs.utils.ts b/apps/studio/components/interfaces/UnifiedLogs/UnifiedLogs.utils.ts
index b839237a946..7cd29dbc9ec 100644
--- a/apps/studio/components/interfaces/UnifiedLogs/UnifiedLogs.utils.ts
+++ b/apps/studio/components/interfaces/UnifiedLogs/UnifiedLogs.utils.ts
@@ -81,13 +81,13 @@ export function getLevelRowClassName(value: (typeof LEVELS)[number]): string {
return ''
case 'warning':
return cn(
- 'bg-warning/5 [&>td]:group-hover:bg-warning/10',
+ 'bg-warning/5 hover:bg-warning/10',
'data-[state=selected]:bg-warning/20 focus-visible:bg-warning/10',
'dark:bg-warning/10 dark:hover:bg-warning/20 dark:data-[state=selected]:bg-warning/30 dark:focus-visible:bg-warning/20'
)
case 'error':
return cn(
- 'bg-destructive/5 [&>td]:group-hover:bg-destructive/10',
+ 'bg-destructive/5 hover:bg-destructive/10',
'data-[state=selected]:bg-destructive/20 focus-visible:bg-destructive/10',
'dark:bg-error/10 dark:hover:bg-destructive/20 dark:data-[state=selected]:bg-destructive/30 dark:focus-visible:bg-destructive/20'
)
diff --git a/apps/studio/components/ui/DataTable/DataTableInfinite.tsx b/apps/studio/components/ui/DataTable/DataTableInfinite.tsx
index c9154c7dafd..d67f89ddef2 100644
--- a/apps/studio/components/ui/DataTable/DataTableInfinite.tsx
+++ b/apps/studio/components/ui/DataTable/DataTableInfinite.tsx
@@ -3,7 +3,7 @@ import type { ColumnDef, Row, Table as TTable, VisibilityState } from '@tanstack
import { flexRender } from '@tanstack/react-table'
import { LoaderCircle } from 'lucide-react'
import { useQueryState } from 'nuqs'
-import { Fragment, ReactNode, UIEvent, useCallback, useRef } from 'react'
+import { Fragment, UIEvent, useCallback, useRef } from 'react'
import { Button, cn } from 'ui'
import { ShimmeringLoader } from 'ui-patterns'
@@ -24,7 +24,6 @@ export interface DataTableInfiniteProps<TData, TValue, _TMeta> {
isLoading?: boolean
hasNextPage?: boolean
fetchNextPage: (options?: FetchNextPageOptions | undefined) => Promise<unknown>
- renderLiveRow?: (props?: { row: Row<TData> }) => ReactNode
setColumnOrder: (columnOrder: string[]) => void
setColumnVisibility: (columnVisibility: VisibilityState) => void
@@ -41,7 +40,6 @@ export function DataTableInfinite<TData, TValue, TMeta>({
totalRows = 0,
filterRows = 0,
totalRowsFetched = 0,
- renderLiveRow,
setColumnOrder,
setColumnVisibility,
searchParamsParser,
@@ -123,15 +121,13 @@ export function DataTableInfinite<TData, TValue, TMeta>({
{rows.length ? (
rows.map((row) => (
// REMINDER: if we want to add arrow navigation https://github.com/TanStack/table/discussions/2752#discussioncomment-192558
- <Fragment key={row.id}>
- {renderLiveRow?.({ row: row as any })}
- <DataTableRow
- row={row}
- table={table}
- searchParamsParser={searchParamsParser}
- selected={row.getIsSelected()}
- />
- </Fragment>
+ <DataTableRow
+ key={row.id}
+ row={row}
+ table={table}
+ searchParamsParser={searchParamsParser}
+ selected={row.getIsSelected()}
+ />
))
) : isLoading ? (
<Fragment>
diff --git a/packages/ui/src/components/shadcn/ui/table.tsx b/packages/ui/src/components/shadcn/ui/table.tsx
index d4841181f87..54d442def0e 100644
--- a/packages/ui/src/components/shadcn/ui/table.tsx
+++ b/packages/ui/src/components/shadcn/ui/table.tsx
@@ -148,10 +148,7 @@ const TableCell = React.forwardRef<
>(({ className, ...props }, ref) => (
<td
ref={ref}
- className={cn(
- 'transition-colors p-4 align-middle group-hover:bg-surface-200 [&:has([role=checkbox])]:pr-0',
- className
- )}
+ className={cn('transition-colors p-4 align-middle [&:has([role=checkbox])]:pr-0', className)}
{...props}
/>
))