Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix(studio): escape SQL identifiers in index create/delete mutations (#44589)

oniani1ebf9bc495530
diff --git a/apps/studio/data/database-indexes/index-create-mutation.ts b/apps/studio/data/database-indexes/index-create-mutation.ts
index cfe66156552..199749b9d78 100644
--- a/apps/studio/data/database-indexes/index-create-mutation.ts
+++ b/apps/studio/data/database-indexes/index-create-mutation.ts
@@ -1,3 +1,4 @@
+import { ident } from '@supabase/pg-meta/src/pg-format'
import { useMutation, useQueryClient } from '@tanstack/react-query'
import { toast } from 'sonner'
@@ -24,8 +25,8 @@ export async function createDatabaseIndex({
const { schema, entity, type, columns } = payload
const sql = `
- CREATE INDEX ON "${schema}"."${entity}" USING ${type} (${columns
- .map((column) => `"${column}"`)
+ CREATE INDEX ON ${ident(schema)}.${ident(entity)} USING ${type} (${columns
+ .map((column) => ident(column))
.join(', ')});
`.trim()
diff --git a/apps/studio/data/database-indexes/index-delete-mutation.ts b/apps/studio/data/database-indexes/index-delete-mutation.ts
index 6540d8b0562..4f2ff441b4b 100644
--- a/apps/studio/data/database-indexes/index-delete-mutation.ts
+++ b/apps/studio/data/database-indexes/index-delete-mutation.ts
@@ -1,3 +1,4 @@
+import { ident } from '@supabase/pg-meta/src/pg-format'
import { useMutation, useQueryClient } from '@tanstack/react-query'
import { toast } from 'sonner'
@@ -18,7 +19,7 @@ export async function deleteDatabaseIndex({
name,
schema,
}: DatabaseIndexDeleteVariables) {
- const sql = `drop index if exists "${schema}"."${name}"`
+ const sql = `drop index if exists ${ident(schema)}.${ident(name)}`
const { result } = await executeSql({
projectRef,