Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

chore: make FeaturePreviewModal more responsive (#43710)

Francesco Sansalvadoreed5a54aa51a6
diff --git a/apps/studio/components/interfaces/App/FeaturePreview/FeaturePreviewModal.tsx b/apps/studio/components/interfaces/App/FeaturePreview/FeaturePreviewModal.tsx
index 793a740533d..c4830f225fd 100644
--- a/apps/studio/components/interfaces/App/FeaturePreview/FeaturePreviewModal.tsx
+++ b/apps/studio/components/interfaces/App/FeaturePreview/FeaturePreviewModal.tsx
@@ -18,17 +18,23 @@ import {
DialogTitle,
ScrollArea,
} from 'ui'
+import {
+ Select,
+ SelectContent,
+ SelectItem,
+ SelectTrigger,
+} from 'ui/src/components/shadcn/ui/select'
import { AdvisorRulesPreview } from './AdvisorRulesPreview'
import { Branching2Preview } from './Branching2Preview'
import { CLSPreview } from './CLSPreview'
import { useFeaturePreviewContext, useFeaturePreviewModal } from './FeaturePreviewContext'
-import { PlatformWebhooksPreview } from './PlatformWebhooksPreview'
import { PgDeltaDiffPreview } from './PgDeltaDiffPreview'
+import { PlatformWebhooksPreview } from './PlatformWebhooksPreview'
import { QueueOperationsPreview } from './QueueOperationsPreview'
import { TableFilterBarPreview } from './TableFilterBarPreview'
import { UnifiedLogsPreview } from './UnifiedLogsPreview'
-import { useFeaturePreviews } from './useFeaturePreviews'
+import { FeaturePreview, useFeaturePreviews } from './useFeaturePreviews'
import { useLocalStorageQuery } from '@/hooks/misc/useLocalStorage'
const FEATURE_PREVIEW_KEY_TO_CONTENT: {
@@ -91,7 +97,7 @@ export const FeaturePreviewModal = () => {
return (
<Dialog open={showFeaturePreviewModal} onOpenChange={toggleFeaturePreviewModal}>
- <DialogContent size="xlarge" className="!max-w-4xl">
+ <DialogContent size="xlarge" className="flex flex-col !max-w-4xl h-[90dvh] md:h-auto">
<DialogHeader>
<DialogTitle>Dashboard feature previews</DialogTitle>
<DialogDescription>Get early access to new features and give feedback</DialogDescription>
@@ -99,41 +105,58 @@ export const FeaturePreviewModal = () => {
<DialogSectionSeparator />
- <DialogSection className="!p-0">
+ <DialogSection className="!p-0 flex-1 min-h-0 h-full">
{allFeaturePreviews.length > 0 ? (
- <div className="flex">
+ <div className="max-h-full flex-1 min-h-0 h-full flex flex-col gap-y-1 md:gap-y-4 md:flex-row">
<div>
- <ScrollArea className="h-[550px] w-[280px] border-r">
- {allFeaturePreviews.map((feature) => {
- const isEnabled = flags[feature.key] ?? false
-
- return (
- <div
+ <ScrollArea className="hidden md:block h-[550px] w-[280px] border-r">
+ {allFeaturePreviews.map((feature) => (
+ <FeaturePreviewItem
+ key={feature.key}
+ feature={feature}
+ selectedFeature={selectedFeature}
+ selectFeaturePreview={selectFeaturePreview}
+ />
+ ))}
+ </ScrollArea>
+ </div>
+ <div className="block md:hidden px-4 pt-4">
+ <Select
+ value={selectedFeature.key}
+ onValueChange={selectFeaturePreview}
+ defaultValue={selectedFeature.name}
+ >
+ <SelectTrigger id="feature-preview-select">
+ <div className="flex items-center gap-x-2">
+ {flags[selectedFeature.key] ?? false ? (
+ <Eye size={14} strokeWidth={2} className="text-brand" />
+ ) : (
+ <EyeOff size={14} strokeWidth={1.5} className="text-foreground-light" />
+ )}
+ <p>{selectedFeature.name}</p>
+ {selectedFeature.isNew && <Badge variant="success">New</Badge>}
+ </div>
+ </SelectTrigger>
+ <SelectContent className="!p-0 [&>div]:!w-full [&>div]:!p-0 [&>div]:!flex [&>div]:!flex-col w-full flex">
+ {allFeaturePreviews.map((feature) => (
+ <SelectItem
key={feature.key}
- onClick={() => selectFeaturePreview(feature.key)}
- className={cn(
- 'flex items-center justify-between p-4 border-b cursor-pointer bg transition',
- selectedFeature?.key === feature.key ? 'bg-surface-300' : 'bg-surface-100'
- )}
+ value={feature.key}
+ className="p-0 [&>span:nth-child(2)]:w-full [&>span:nth-child(1)]:left-3"
>
- <div className="flex items-center gap-x-3">
- {isEnabled ? (
- <Eye size={14} strokeWidth={2} className="text-brand" />
- ) : (
- <EyeOff size={14} strokeWidth={1.5} className="text-foreground-light" />
- )}
- <p className="text-sm truncate" title={feature.name}>
- {feature.name}
- </p>
- </div>
- {feature.isNew && <Badge variant="success">New</Badge>}
- </div>
- )
- })}
- </ScrollArea>
+ <FeaturePreviewItem
+ feature={feature}
+ selectedFeature={selectedFeature}
+ selectFeaturePreview={selectFeaturePreview}
+ className="pl-10 py-3 bg-transparent"
+ />
+ </SelectItem>
+ ))}
+ </SelectContent>
+ </Select>
</div>
- <div className="flex-grow max-h-[550px] p-4 space-y-3 overflow-y-auto">
- <div className="flex items-center justify-between">
+ <div className="h-auto min-h-0 max-h-auto md:max-h-[550px] p-4 pb-0 flex flex-col">
+ <div className="flex items-center justify-between border-b gap-2 pb-3">
<p>{selectedFeature?.name}</p>
<div className="flex items-center gap-x-2">
{selectedFeature?.discussionsUrl !== undefined && (
@@ -152,7 +175,9 @@ export const FeaturePreviewModal = () => {
</Button>
</div>
</div>
- {FEATURE_PREVIEW_KEY_TO_CONTENT[selectedFeature?.key ?? '']}
+ <div className="overflow-y-scroll pt-3 pb-4">
+ {FEATURE_PREVIEW_KEY_TO_CONTENT[selectedFeature?.key ?? '']}
+ </div>
</div>
</div>
) : (
@@ -180,3 +205,44 @@ export const FeaturePreviewModal = () => {
</Dialog>
)
}
+
+const FeaturePreviewItem = ({
+ feature,
+ selectedFeature,
+ selectFeaturePreview,
+ className,
+}: {
+ feature: FeaturePreview
+ selectedFeature: FeaturePreview
+ selectFeaturePreview: (key: string) => void
+ className?: string
+}) => {
+ const featurePreviewContext = useFeaturePreviewContext()
+ const { flags } = featurePreviewContext
+ const isEnabled = flags[feature.key] ?? false
+
+ return (
+ <button
+ type="button"
+ key={feature.key}
+ onClick={() => selectFeaturePreview(feature.key)}
+ className={cn(
+ '!w-full flex-1 flex items-center justify-between p-4 border-b cursor-pointer bg transition',
+ selectedFeature?.key === feature.key ? 'bg-surface-300' : 'bg-surface-100',
+ className
+ )}
+ >
+ <div className="flex items-center gap-x-3">
+ {isEnabled ? (
+ <Eye size={14} strokeWidth={2} className="text-brand" />
+ ) : (
+ <EyeOff size={14} strokeWidth={1.5} className="text-foreground-light" />
+ )}
+ <p className="text-sm truncate" title={feature.name}>
+ {feature.name}
+ </p>
+ </div>
+ {feature.isNew && <Badge variant="success">New</Badge>}
+ </button>
+ )
+}
diff --git a/apps/studio/components/interfaces/App/FeaturePreview/useFeaturePreviews.ts b/apps/studio/components/interfaces/App/FeaturePreview/useFeaturePreviews.ts
index df3f9535d6c..84cc22c3f23 100644
--- a/apps/studio/components/interfaces/App/FeaturePreview/useFeaturePreviews.ts
+++ b/apps/studio/components/interfaces/App/FeaturePreview/useFeaturePreviews.ts
@@ -1,6 +1,6 @@
import { LOCAL_STORAGE_KEYS, useFlag } from 'common'
-type FeaturePreview = {
+export type FeaturePreview = {
key: string
name: string
discussionsUrl?: string