Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

fix(studio): register pitr_archiving_stale in the advisor lintInfoMap (#48044)

Douglas J Hunleyeea39cc3163b
diff --git a/apps/studio/components/interfaces/Linter/Linter.utils.test.tsx b/apps/studio/components/interfaces/Linter/Linter.utils.test.tsx
index b60ef3e36cc..054c0d01c66 100644
--- a/apps/studio/components/interfaces/Linter/Linter.utils.test.tsx
+++ b/apps/studio/components/interfaces/Linter/Linter.utils.test.tsx
@@ -1,3 +1,5 @@
+import { Ruler } from 'lucide-react'
+import { isValidElement } from 'react'
import { describe, expect, it } from 'vitest'
import { lintInfoMap } from './Linter.utils'
@@ -66,3 +68,18 @@ describe('Linter.utils lintInfoMap link encoding', () => {
expect(url).toBe('/project/abc/storage/files/buckets/a%2Fb%20c')
})
})
+
+describe('Linter.utils lintInfoMap pitr_archiving_stale entry', () => {
+ it('registers a security entry linking to the PITR settings page', () => {
+ const info = lintInfoMap.find((entry) => entry.name === 'pitr_archiving_stale')
+ expect(info, 'expected pitr_archiving_stale in lintInfoMap').toBeDefined()
+
+ expect(info!.title).toBe('PITR archiving may be broken')
+ expect(isValidElement(info!.icon) && info!.icon.type).toBe(Ruler)
+ expect(info!.category).toBe('security')
+ expect(info!.linkText).toBe('View settings')
+ // metadata is unused by this entry's link(), and every field on Lint['metadata'] is optional, so {} needs no cast
+ expect(info!.link({ projectRef, metadata: {} })).toBe('/project/abc/database/backups/pitr')
+ expect(info!.docsLink).toContain('/guides/platform/backups#point-in-time-recovery')
+ })
+})
diff --git a/apps/studio/components/interfaces/Linter/Linter.utils.tsx b/apps/studio/components/interfaces/Linter/Linter.utils.tsx
index 2e8a7b0c11c..bc373167d90 100644
--- a/apps/studio/components/interfaces/Linter/Linter.utils.tsx
+++ b/apps/studio/components/interfaces/Linter/Linter.utils.tsx
@@ -257,6 +257,16 @@ export const lintInfoMap: LintInfo[] = [
docsLink: `${DOCS_URL}/guides/platform/backups#point-in-time-recovery`,
category: 'security',
},
+ {
+ name: 'pitr_archiving_stale',
+ title: 'PITR archiving may be broken',
+ icon: <Ruler className="text-foreground-muted" size={15} strokeWidth={1} />,
+ link: ({ projectRef }) => `/project/${projectRef}/database/backups/pitr`,
+ linkText: 'View settings',
+ // anchor explains what PITR is, not how to fix a stale archive; PITR-archiving-specific docs tracked in TODO: INDATA-1149
+ docsLink: `${DOCS_URL}/guides/platform/backups#point-in-time-recovery`,
+ category: 'security',
+ },
{
name: 'auth_leaked_password_protection',
title: 'Leaked Password Protection Disabled',