Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

feat(replication): Render errors as markdown and improve publication loading (#47037)

Riccardo Busettif162190be858
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.utils.ts b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.utils.ts
index 8f7d3a53e1b..34c2405027c 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.utils.ts
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.utils.ts
@@ -15,11 +15,12 @@ import {
IcebergDestinationConfig,
SnowflakeDestinationConfig,
} from '@/data/replication/create-destination-pipeline-mutation'
+import { type ValidationFailure } from '@/data/replication/validate-destination-mutation'
import {
type CreateS3AccessKeyCredentialVariables,
type S3AccessKeyCreateData,
} from '@/data/storage/s3-access-key-create-mutation'
-import { ResponseError } from '@/types'
+import { type ResponseError } from '@/types'
const normalizeOptionalString = (value?: string) => {
const trimmed = value?.trim()
@@ -335,3 +336,22 @@ export const buildDestinationConfig = async ({
return destinationConfig
}
+
+const getValidationFailureKey = (failure: ValidationFailure) =>
+ JSON.stringify([failure.failure_type, failure.name, failure.reason])
+
+const getSortedValidationFailureKeys = (failures: ValidationFailure[]) =>
+ failures.map(getValidationFailureKey).sort((a, b) => a.localeCompare(b))
+
+export const areValidationFailuresEqual = (
+ previousFailures: ValidationFailure[],
+ nextFailures: ValidationFailure[]
+) => {
+ const previousKeys = getSortedValidationFailureKeys(previousFailures)
+ const nextKeys = getSortedValidationFailureKeys(nextFailures)
+
+ return (
+ previousKeys.length === nextKeys.length &&
+ previousKeys.every((key, index) => key === nextKeys[index])
+ )
+}
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationPanelFields.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationPanelFields.tsx
index 40b87c79514..547e52a9a74 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationPanelFields.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationPanelFields.tsx
@@ -883,7 +883,7 @@ export const AnalyticsBucketFields = ({
<Button
variant="default"
icon={showSecretAccessKey ? <Eye /> : <EyeOff />}
- className="w-7 absolute right-6 top-[4px]"
+ className="w-7 absolute right-1 top-[4px]"
onClick={() => setShowSecretAccessKey(!showSecretAccessKey)}
/>
</FormItemLayout>
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/PublicationSelection.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/PublicationSelection.tsx
index 903cd14daa1..050921886cf 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/PublicationSelection.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/PublicationSelection.tsx
@@ -24,11 +24,10 @@ export const PublicationSelection = ({
const { ref: projectRef } = useParams()
const { publicationName } = form.watch()
- const {
- data: publications = [],
- isPending: isLoadingPublications,
- isSuccess: isSuccessPublications,
- } = useReplicationPublicationsQuery({ projectRef, sourceId })
+ const { data: publications, isSuccess: isSuccessPublications } = useReplicationPublicationsQuery({
+ projectRef,
+ sourceId,
+ })
const publicationNames = useMemo(() => publications?.map((pub) => pub.name) ?? [], [publications])
const isSelectedPublicationMissing =
@@ -46,9 +45,8 @@ export const PublicationSelection = ({
>
<FormControl>
<PublicationsComboBox
- publications={publications}
- isLoadingPublications={isLoadingPublications}
field={field}
+ sourceId={sourceId}
onNewPublicationClick={() => onSelectNewPublication()}
/>
</FormControl>
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/PublicationsComboBox.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/PublicationsComboBox.tsx
index 77302e3d44f..4a9cc645b66 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/PublicationsComboBox.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/PublicationsComboBox.tsx
@@ -1,3 +1,4 @@
+import { useParams } from 'common'
import { Check, ChevronsUpDown, Loader2, Plus } from 'lucide-react'
import { useEffect, useState } from 'react'
import { ControllerRenderProps } from 'react-hook-form'
@@ -18,24 +19,34 @@ import {
ScrollArea,
} from 'ui'
-import type { ReplicationPublication } from '@/data/replication/publications-query'
+import type { DestinationPanelSchemaType } from './DestinationForm.schema'
+import { useReplicationPublicationsQuery } from '@/data/replication/publications-query'
interface PublicationsComboBoxProps {
- publications: ReplicationPublication[]
- isLoadingPublications: boolean
+ sourceId?: number
+ field: ControllerRenderProps<DestinationPanelSchemaType, 'publicationName'>
onNewPublicationClick: () => void
- field: ControllerRenderProps<any, 'publicationName'>
}
export const PublicationsComboBox = ({
- publications,
- isLoadingPublications,
- onNewPublicationClick,
+ sourceId,
field,
+ onNewPublicationClick,
}: PublicationsComboBoxProps) => {
+ const { ref: projectRef } = useParams()
+
+ const [searchTerm, setSearchTerm] = useState('')
const [dropdownOpen, setDropdownOpen] = useState(false)
const [selectedPublication, setSelectedPublication] = useState<string>(field?.value || '')
- const [searchTerm, setSearchTerm] = useState('')
+
+ const {
+ data: publications = [],
+ isPending,
+ isFetching,
+ refetch: refetchPublications,
+ } = useReplicationPublicationsQuery({ projectRef, sourceId })
+ const isLoadingPublications = isPending || isFetching
+ const showLoadingState = isLoadingPublications && publications.length === 0
function handlePublicationSelect(pub: string) {
setSelectedPublication(pub)
@@ -53,6 +64,12 @@ export const PublicationsComboBox = ({
open={dropdownOpen}
onOpenChange={(open) => {
setDropdownOpen(open)
+ if (open) {
+ if (typeof projectRef !== 'undefined' && typeof sourceId !== 'undefined') {
+ refetchPublications()
+ }
+ }
+
if (!open && field?.onBlur) {
field.onBlur()
}
@@ -66,7 +83,13 @@ export const PublicationsComboBox = ({
'w-full [&>span]:w-full text-left',
!selectedPublication && 'text-foreground-muted'
)}
- iconRight={<ChevronsUpDown className="text-foreground-muted" strokeWidth={2} size={14} />}
+ iconRight={
+ showLoadingState ? (
+ <Loader2 className="text-foreground-muted animate-spin" strokeWidth={2} size={14} />
+ ) : (
+ <ChevronsUpDown className="text-foreground-muted" strokeWidth={2} size={14} />
+ )
+ }
name={field.name}
onBlur={field.onBlur}
>
@@ -83,7 +106,7 @@ export const PublicationsComboBox = ({
/>
<CommandList>
<CommandEmpty>
- {isLoadingPublications ? (
+ {showLoadingState ? (
<div className="flex items-center gap-2 text-center justify-center">
<Loader2 size={12} className="animate-spin" />
Loading...
@@ -94,7 +117,7 @@ export const PublicationsComboBox = ({
</CommandEmpty>
<CommandGroup>
- {publications.length === 0 && (
+ {publications.length === 0 && !showLoadingState && (
<div className="text-foreground-lighter text-xs py-3 px-2 space-y-0.5">
<p>No publications available</p>
<p className="text-foreground-muted">Publications with no tables are hidden</p>
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ValidationFailuresSection.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ValidationFailuresSection.tsx
index 5389e1d2b4a..868cbfb6678 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ValidationFailuresSection.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ValidationFailuresSection.tsx
@@ -1,6 +1,7 @@
import { Accordion, AccordionContent, AccordionItem, AccordionTrigger, Badge, Card } from 'ui'
import { Admonition } from 'ui-patterns'
+import { Markdown } from '@/components/interfaces/Markdown'
import type { ValidationFailure } from '@/data/replication/validate-destination-mutation'
interface ValidationFailuresSectionProps {
@@ -52,9 +53,9 @@ export const ValidationFailuresSection = ({
</p>
</AccordionTrigger>
<AccordionContent className="px-3">
- <p className="whitespace-pre-wrap text-sm">
- {failure.reason.replaceAll('\n\n', '\n')}
- </p>
+ <Markdown className="text-sm text-foreground-light [&>p]:mb-2!">
+ {failure.reason}
+ </Markdown>
</AccordionContent>
</AccordionItem>
))}
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ValidationWarningsDialog.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ValidationWarningsDialog.tsx
index ac9051a2848..818a41ce9c8 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ValidationWarningsDialog.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/ValidationWarningsDialog.tsx
@@ -24,27 +24,32 @@ export const ValidationWarningsDialog = ({
onOpenChange,
onConfirm,
}: ValidationWarningsDialogProps) => {
+ const hasWarnings = warningCount > 0
+
return (
<AlertDialog open={open} onOpenChange={onOpenChange}>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>
- Create destination with {warningCount} {warningCount === 1 ? 'warning' : 'warnings'}?
+ {hasWarnings
+ ? `Create destination with ${warningCount} ${warningCount === 1 ? 'warning' : 'warnings'}?`
+ : 'Confirm to create destination'}
</AlertDialogTitle>
<AlertDialogDescription>
- Replication can start, but the warnings listed above may affect how some changes are
- applied downstream. Review them before proceeding.
+ {hasWarnings
+ ? 'Replication can start, but the warnings listed above may affect how some changes are applied downstream. Review them before proceeding.'
+ : 'No validation issues were found. Confirm to create the destination and start replication.'}
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter>
<AlertDialogCancel disabled={isLoading}>Cancel</AlertDialogCancel>
<AlertDialogAction
- variant="warning"
+ variant={hasWarnings ? 'warning' : 'primary'}
disabled={isLoading}
loading={isLoading}
onClick={onConfirm}
>
- Proceed to create
+ {hasWarnings ? 'Proceed to create' : 'Create destination'}
</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx
index 198a35b2d3a..edc5e7b5256 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx
@@ -20,6 +20,7 @@ import { AdvancedSettings } from './AdvancedSettings'
import { CREATE_NEW_NAMESPACE } from './DestinationForm.constants'
import { DestinationPanelFormSchema as FormSchema } from './DestinationForm.schema'
import {
+ areValidationFailuresEqual,
buildDestinationConfig,
buildDestinationConfigForValidation,
getDucklakeValidationIssues,
@@ -181,11 +182,13 @@ export const DestinationForm = ({
const { mutateAsync: createDestinationPipeline, isPending: creatingDestinationPipeline } =
useCreateDestinationPipelineMutation({
onSuccess: () => form.reset(defaultValues),
+ onError: () => {},
})
const { mutateAsync: updateDestinationPipeline, isPending: updatingDestinationPipeline } =
useUpdateDestinationPipelineMutation({
onSuccess: () => form.reset(defaultValues),
+ onError: () => {},
})
const { mutateAsync: startPipeline, isPending: startingPipeline } = useStartPipelineMutation()
@@ -356,6 +359,10 @@ export const DestinationForm = ({
if (editMode) {
return existingDestination?.enabled ? 'Apply and restart' : 'Apply and start'
} else {
+ if (hasRunValidation && validationWarnings.length > 0 && !hasValidationFailures) {
+ return 'Create and start anyway'
+ }
+
return 'Create and start'
}
}
@@ -537,29 +544,35 @@ export const DestinationForm = ({
const onSubmit = async (data: z.infer<typeof FormSchema>) => {
if (!editMode) {
- if (!hasRunValidation || isValidating || hasValidationFailures) {
- const validationResult = await validateConfiguration(data)
- if (!validationResult.canContinue) {
- // Critical failures shown inline — stop so user can fix them
- return
- }
- if (validationResult.warnings.length > 0) {
- // Warnings shown inline — stop so user can review, then re-submit to confirm
- return
- }
- await submitPipeline(data)
+ const previousValidationFailures = allValidationFailures
+ const previousWarnings = previousValidationFailures.filter(
+ (f) => f.failure_type === 'warning'
+ )
+ const previousFailuresAreOnlyWarnings =
+ hasRunValidation &&
+ previousValidationFailures.length > 0 &&
+ previousValidationFailures.every((f) => f.failure_type === 'warning')
+
+ const validationResult = await validateConfiguration(data)
+ if (!validationResult.canContinue) {
+ // Critical failures shown inline — stop so user can fix them
return
}
- // Validation already passed; warnings are visible inline — ask user to confirm
- if (validationWarnings.length > 0) {
- setPendingFormValues(data)
- setShowValidationWarningsDialog(true)
+ const hasWarnings = validationResult.warnings.length > 0
+ const warningsUnchanged =
+ previousFailuresAreOnlyWarnings &&
+ areValidationFailuresEqual(previousWarnings, validationResult.warnings)
+
+ // Open the confirmation dialog when validation is clean, or when warnings are unchanged on
+ // resubmit. New/changed warnings are shown inline so the user can review and submit again.
+ if (hasWarnings) {
+ if (warningsUnchanged) {
+ setPendingFormValues(data)
+ setShowValidationWarningsDialog(true)
+ }
return
}
-
- await submitPipeline(data)
- return
}
await submitPipeline(data)
@@ -569,7 +582,6 @@ export const DestinationForm = ({
setShowValidationWarningsDialog(open)
if (!open) {
setPendingFormValues(null)
- setHasRunValidation(false)
}
}
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationTypeSelection.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationTypeSelection.tsx
index 14dfc1b8b0c..14541870793 100644
--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationTypeSelection.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationTypeSelection.tsx
@@ -144,12 +144,12 @@ export const DestinationTypeSelection = () => {
labelOptional="Destination type cannot be changed after creation"
description={
selectedOption?.isAlpha && (
- <p className="text-sm text-foreground-light mb-1">
+ <span className="text-sm text-foreground-light mb-1">
This destination type is in alpha and may change while we iterate.{' '}
<InlineLink href="https://github.com/orgs/supabase/discussions/39416">
Leave feedback
</InlineLink>
- </p>
+ </span>
)
}
>
diff --git a/apps/studio/components/interfaces/Database/Replication/ReadReplicas/ReadReplicaRow.tsx b/apps/studio/components/interfaces/Database/Replication/ReadReplicas/ReadReplicaRow.tsx
index 5df48c62f37..6838cdaa3b5 100644
--- a/apps/studio/components/interfaces/Database/Replication/ReadReplicas/ReadReplicaRow.tsx
+++ b/apps/studio/components/interfaces/Database/Replication/ReadReplicas/ReadReplicaRow.tsx
@@ -122,7 +122,7 @@ export const ReadReplicaRow = ({ replica, onUpdateReplica }: ReadReplicaRow) =>
</Link>
</Button>
<DropdownMenu>
- <DropdownMenuTrigger>
+ <DropdownMenuTrigger asChild>
<Button variant="default" icon={<MoreVertical />} className="w-7" />
</DropdownMenuTrigger>
<DropdownMenuContent align="end" className="w-52">