Skip to content

The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.

add aria label in Query Performance (#47678)

ChloeGarciaMillerandf29db88edd5e
diff --git a/apps/studio/components/interfaces/Integrations/CronJobs/CronJobTableCell.tsx b/apps/studio/components/interfaces/Integrations/CronJobs/CronJobTableCell.tsx
index 499697b15e5..7617544dfca 100644
--- a/apps/studio/components/interfaces/Integrations/CronJobs/CronJobTableCell.tsx
+++ b/apps/studio/components/interfaces/Integrations/CronJobs/CronJobTableCell.tsx
@@ -21,7 +21,6 @@ import {
DialogSection,
DialogSectionSeparator,
DialogTitle,
- DialogTrigger,
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
@@ -147,16 +146,21 @@ export const CronJobTableCell = ({
return (
<div className="flex items-center">
<DropdownMenu>
- <DropdownMenuTrigger asChild>
- <Button
- variant="text"
- aria-label="More actions"
- loading={isRunning}
- className="h-6 w-6"
- icon={<MoreVertical />}
- onClick={(e) => e.stopPropagation()}
- />
- </DropdownMenuTrigger>
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <DropdownMenuTrigger asChild>
+ <Button
+ variant="text"
+ loading={isRunning}
+ className="h-6 w-6"
+ icon={<MoreVertical />}
+ onClick={(e) => e.stopPropagation()}
+ aria-label={`${jobname} actions`}
+ />
+ </DropdownMenuTrigger>
+ </TooltipTrigger>
+ <TooltipContent side="bottom">{jobname} actions</TooltipContent>
+ </Tooltip>
<DropdownMenuContent align="end" className="w-44 space-y-1">
<Tooltip>
<TooltipTrigger className="w-full">
@@ -205,46 +209,50 @@ export const CronJobTableCell = ({
if (col.id === 'active') {
return (
- <Dialog open={showToggleModal} onOpenChange={setShowToggleModal}>
- <DialogTrigger asChild onClick={(e) => e.stopPropagation()}>
- <div className="flex items-center">
- <Switch
- id={`cron-job-active-${jobid}`}
- aria-label={`${active ? 'Disable' : 'Enable'} cron job`}
- size="medium"
- disabled={isToggling}
- checked={active}
- />
- </div>
- </DialogTrigger>
- <DialogContent
- onClick={(e) => e.stopPropagation()}
- dialogOverlayProps={{ onClick: (e) => e.stopPropagation() }}
- >
- <DialogHeader>
- <DialogTitle>{active ? 'Disable' : 'Enable'} cron job</DialogTitle>
- </DialogHeader>
- <DialogSectionSeparator />
- <DialogSection>
- <p className="text-sm">
- Are you sure you want to {active ? 'disable' : 'enable'} the cron job "{jobname}
- "?{' '}
- </p>
- </DialogSection>
- <DialogFooter>
- <Button variant="default" onClick={() => setShowToggleModal(false)}>
- Cancel
- </Button>
- <Button
- variant={active ? 'warning' : 'primary'}
- loading={isToggling}
- onClick={onConfirmToggle}
- >
- {active ? 'Disable' : 'Enable'}
- </Button>
- </DialogFooter>
- </DialogContent>
- </Dialog>
+ <>
+ <div className="flex items-center" onClick={(e) => e.stopPropagation()}>
+ <Switch
+ id={`cron-job-active-${jobid}`}
+ size="medium"
+ disabled={isToggling}
+ checked={active}
+ aria-label="Cron job active status"
+ onClick={(e) => {
+ e.stopPropagation()
+ setShowToggleModal(true)
+ }}
+ />
+ </div>
+ <Dialog open={showToggleModal} onOpenChange={setShowToggleModal}>
+ <DialogContent
+ onClick={(e) => e.stopPropagation()}
+ dialogOverlayProps={{ onClick: (e) => e.stopPropagation() }}
+ >
+ <DialogHeader>
+ <DialogTitle>{active ? 'Disable' : 'Enable'} cron job</DialogTitle>
+ </DialogHeader>
+ <DialogSectionSeparator />
+ <DialogSection>
+ <p className="text-sm">
+ Are you sure you want to {active ? 'disable' : 'enable'} the cron job "{jobname}
+ "?{' '}
+ </p>
+ </DialogSection>
+ <DialogFooter>
+ <Button variant="default" onClick={() => setShowToggleModal(false)}>
+ Cancel
+ </Button>
+ <Button
+ variant={active ? 'warning' : 'primary'}
+ loading={isToggling}
+ onClick={onConfirmToggle}
+ >
+ {active ? 'Disable' : 'Enable'}
+ </Button>
+ </DialogFooter>
+ </DialogContent>
+ </Dialog>
+ </>
)
}
diff --git a/apps/studio/components/interfaces/QueryPerformance/WithStatements/WithStatements.tsx b/apps/studio/components/interfaces/QueryPerformance/WithStatements/WithStatements.tsx
index 7d683a2bc7b..3c04b93c553 100644
--- a/apps/studio/components/interfaces/QueryPerformance/WithStatements/WithStatements.tsx
+++ b/apps/studio/components/interfaces/QueryPerformance/WithStatements/WithStatements.tsx
@@ -210,6 +210,7 @@ export const WithStatements = ({
side="top"
>
<Button
+ aria-label="Refresh"
variant="default"
size="tiny"
icon={<RefreshCw />}
@@ -223,6 +224,7 @@ export const WithStatements = ({
side="top"
>
<Button
+ aria-label="Reset report"
variant="default"
size="tiny"
icon={<RotateCcw />}