The Postgres development platform. Supabase gives you a dedicated Postgres database to build your web, mobile, and AI applications.
TypeScript aialternativeauthdatabasedenoembeddingsexamplefirebasenextjsoauth2pgvectorpostgispostgrespostgresqlpostgrestrealtimesupabasevectorswebsockets
ref(pipelines): Remove unnecessary restarts (#47732)
Riccardo Busettif45389138bc7
diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsxindex cba27702b7a..2f95430ab63 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsx+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsx@@ -20,6 +20,12 @@ import {import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'import { DestinationType } from '../DestinationPanel.types'+import {+ DEFAULT_CONNECTION_POOL_SIZE,+ DEFAULT_MAX_COPY_CONNECTIONS_PER_TABLE,+ DEFAULT_MAX_FILL_MS,+ DEFAULT_MAX_TABLE_SYNC_WORKERS,+} from './DestinationForm.constants'import { type DestinationPanelSchemaType } from './DestinationForm.schema'export const AdvancedSettings = ({@@ -76,7 +82,7 @@ export const AdvancedSettings = ({type="number"value={field.value ?? ''}onChange={handleNumberChange(field)}- placeholder="Default: 10000"+ placeholder={`Default: ${DEFAULT_MAX_FILL_MS}`}/><InputGroupAddon align="inline-end"><InputGroupText>milliseconds</InputGroupText>@@ -110,7 +116,7 @@ export const AdvancedSettings = ({type="number"value={field.value ?? ''}onChange={handleNumberChange(field)}- placeholder="Default: 4"+ placeholder={`Default: ${DEFAULT_MAX_TABLE_SYNC_WORKERS}`}/><InputGroupAddon align="inline-end"><InputGroupText>workers</InputGroupText>@@ -147,7 +153,7 @@ export const AdvancedSettings = ({type="number"value={field.value ?? ''}onChange={handleNumberChange(field)}- placeholder="Default: 2"+ placeholder={`Default: ${DEFAULT_MAX_COPY_CONNECTIONS_PER_TABLE}`}/><InputGroupAddon align="inline-end"><InputGroupText>connections</InputGroupText>@@ -220,7 +226,7 @@ export const AdvancedSettings = ({type="number"value={field.value ?? ''}onChange={handleNumberChange(field)}- placeholder="Default: 4"+ placeholder={`Default: ${DEFAULT_CONNECTION_POOL_SIZE}`}/><InputGroupAddon align="inline-end"><InputGroupText>connections</InputGroupText>diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AnalyticsBucket/Fields.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AnalyticsBucket/Fields.tsxindex 1c744ce031b..ad102265009 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AnalyticsBucket/Fields.tsx+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AnalyticsBucket/Fields.tsx@@ -58,12 +58,10 @@ const getS3AccessKeyTriggerLabel = ({export const AnalyticsBucketFields = ({form,editMode,- setIsFormInteracting,onSelectNewBucket,}: {form: UseFormReturn<DestinationPanelSchemaType>editMode: boolean- setIsFormInteracting: (value: boolean) => voidonSelectNewBucket: () => void}) => {const { warehouseName, s3AccessKeyId, namespace } = form.watch()@@ -151,7 +149,6 @@ export const AnalyticsBucketFields = ({if (value === 'new-bucket') {onSelectNewBucket()} else {- setIsFormInteracting(true)field.onChange(value)// [Joshen] Ideally should select the first namespace of the selected bucketform.setValue('namespace', '')@@ -216,10 +213,7 @@ export const AnalyticsBucketFields = ({<FormControl><Selectvalue={field.value}- onValueChange={(value) => {- setIsFormInteracting(true)- field.onChange(value)- }}+ onValueChange={field.onChange}disabled={!canSelectNamespace}><SelectTrigger>diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.constants.ts b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.constants.tsindex 8cadf85301e..182e5508729 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.constants.ts+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.constants.ts@@ -5,3 +5,13 @@ export const CREATE_NEW_KEY = 'create-new'export const CREATE_NEW_NAMESPACE = 'create-new-namespace'export const STORED_SECRET_PLACEHOLDER = '••••••••••••••••'++// Default values for the pipeline's advanced settings, applied when the backend hasn't returned+// an explicit override. Shared between the form's default values and the field placeholders so+// both stay in sync. These mirror the `etl` Rust backend's own defaults (crates/etl-config/src/shared/{pipeline,destination}.rs) —+// keep them aligned if the backend defaults ever change.+export const DEFAULT_MAX_FILL_MS = 10000+export const DEFAULT_MAX_TABLE_SYNC_WORKERS = 4+export const DEFAULT_MAX_COPY_CONNECTIONS_PER_TABLE = 4+export const DEFAULT_CONNECTION_POOL_SIZE = 4+export const DEFAULT_DUCKLAKE_POOL_SIZE = 4diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.utils.ts b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.utils.tsindex e866eb76fb2..dbbd98a2c0b 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.utils.ts+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.utils.ts@@ -3,7 +3,15 @@ import { snakeCase } from 'lodash'import z from 'zod'import { DestinationType } from '../DestinationPanel.types'-import { CREATE_NEW_KEY, CREATE_NEW_NAMESPACE } from './DestinationForm.constants'+import {+ CREATE_NEW_KEY,+ CREATE_NEW_NAMESPACE,+ DEFAULT_CONNECTION_POOL_SIZE,+ DEFAULT_DUCKLAKE_POOL_SIZE,+ DEFAULT_MAX_COPY_CONNECTIONS_PER_TABLE,+ DEFAULT_MAX_FILL_MS,+ DEFAULT_MAX_TABLE_SYNC_WORKERS,+} from './DestinationForm.constants'import {DestinationPanelFormSchema,type DestinationPanelSchemaType,@@ -85,9 +93,12 @@ export const generateDefaultValues = ({// Common fieldsname: destinationData?.name ?? '',publicationName: pipelineData?.config.publication_name ?? '',- maxFillMs: pipelineData?.config?.batch?.max_fill_ms ?? undefined,- maxTableSyncWorkers: pipelineData?.config?.max_table_sync_workers ?? undefined,- maxCopyConnectionsPerTable: pipelineData?.config?.max_copy_connections_per_table ?? undefined,+ maxFillMs: pipelineData?.config?.batch?.max_fill_ms ?? DEFAULT_MAX_FILL_MS,+ maxTableSyncWorkers:+ pipelineData?.config?.max_table_sync_workers ?? DEFAULT_MAX_TABLE_SYNC_WORKERS,+ maxCopyConnectionsPerTable:+ pipelineData?.config?.max_copy_connections_per_table ??+ DEFAULT_MAX_COPY_CONNECTIONS_PER_TABLE,invalidatedSlotBehavior:(pipelineData?.config as { invalidated_slot_behavior?: 'error' | 'recreate' } | undefined)?.invalidated_slot_behavior ?? undefined,@@ -97,7 +108,7 @@ export const generateDefaultValues = ({serviceAccountKey: isBigQueryConfig ? config.big_query.service_account_key : '',connectionPoolSize:(config as { big_query?: { connection_pool_size?: number } } | undefined)?.big_query- ?.connection_pool_size ?? undefined,+ ?.connection_pool_size ?? DEFAULT_CONNECTION_POOL_SIZE,maxStalenessMins: isBigQueryConfig ? config.big_query.max_staleness_mins : undefined, // Default: null// Analytics Bucket fieldswarehouseName: isIcebergConfig ? config.iceberg.supabase.warehouse_name : '',@@ -117,7 +128,7 @@ export const generateDefaultValues = ({ducklakeStorageBucket: '',ducklakeCatalogUrl: ducklakeConfig?.catalog_url ?? '',ducklakeDataPath: ducklakeConfig?.data_path ?? '',- ducklakePoolSize: ducklakeConfig?.pool_size,+ ducklakePoolSize: ducklakeConfig?.pool_size ?? DEFAULT_DUCKLAKE_POOL_SIZE,ducklakeS3AccessKeyId: ducklakeConfig?.s3_access_key_id ?? '',ducklakeS3SecretAccessKey: ducklakeConfig?.s3_secret_access_key ?? '',ducklakeS3Region: ducklakeConfig?.s3_region ?? '',diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DuckLake/Fields.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DuckLake/Fields.tsxindex 21c32a6ca44..b49b57ec47b 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DuckLake/Fields.tsx+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DuckLake/Fields.tsx@@ -26,7 +26,7 @@ import { Admonition } from 'ui-patterns/admonition'import { Input as PasswordInput } from 'ui-patterns/DataInputs/Input'import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'-import { STORED_SECRET_PLACEHOLDER } from '../DestinationForm.constants'+import { DEFAULT_DUCKLAKE_POOL_SIZE, STORED_SECRET_PLACEHOLDER } from '../DestinationForm.constants'import type { DestinationPanelSchemaType } from '../DestinationForm.schema'import {DUCKLAKE_MODE_CUSTOM,@@ -227,7 +227,7 @@ const DuckLakeSupabaseFields = ({ form }: { form: UseFormReturn<DestinationPanelmin={1}max={6}value={field.value ?? ''}- placeholder="Default: 4"+ placeholder={`Default: ${DEFAULT_DUCKLAKE_POOL_SIZE}`}onChange={(event) =>field.onChange(event.target.value === '' ? undefined : Number(event.target.value))}@@ -449,7 +449,7 @@ const DuckLakeCustomFields = ({min={1}max={6}value={field.value ?? ''}- placeholder="Default: 4"+ placeholder={`Default: ${DEFAULT_DUCKLAKE_POOL_SIZE}`}onChange={(event) =>field.onChange(event.target.value === '' ? undefined : Number(event.target.value)diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsxindex 6e5cfdefa76..8a89bbde4c3 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsx@@ -83,7 +83,6 @@ export const DestinationForm = ({const etlEnableSnowflake = useIsETLSnowflakePrivateAlpha()const { can: canReadAPIKeys } = useAsyncCheckPermissions(PermissionAction.SECRETS_READ, '*')- const [isFormInteracting, setIsFormInteracting] = useState(false)const [showValidationWarningsDialog, setShowValidationWarningsDialog] = useState(false)const [publicationPanelVisible, setPublicationPanelVisible] = useState(false)const [newBucketSheetVisible, setNewBucketSheetVisible] = useState(false)@@ -301,16 +300,8 @@ export const DestinationForm = ({}useEffect(() => {- if (editMode && destinationData && pipelineData && !isFormInteracting) {+ if (visible && !form.formState.isDirty) {form.reset(defaultValues)- }- }, [destinationData, pipelineData, editMode, defaultValues, form, isFormInteracting])-- // Ensure the form always reflects the freshest data whenever the panel opens- useEffect(() => {- if (visible) {- form.reset(defaultValues)- setIsFormInteracting(false)resetValidation()}}, [visible, defaultValues, form, resetValidation])@@ -381,7 +372,6 @@ export const DestinationForm = ({<AnalyticsBucketFieldsform={form}editMode={editMode}- setIsFormInteracting={setIsFormInteracting}onSelectNewBucket={() => setNewBucketSheetVisible(true)}/>) : selectedType === 'DuckLake' && etlEnableDucklake ? (diff --git a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/useDestinationForm.ts b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/useDestinationForm.tsindex 4455b0342bb..6f69c79eddb 100644--- a/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/useDestinationForm.ts+++ b/apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/useDestinationForm.ts@@ -14,7 +14,6 @@ import {useCreateDestinationPipelineMutation,type BatchConfig,} from '@/data/replication/create-destination-pipeline-mutation'-import { useRestartPipelineHelper } from '@/data/replication/restart-pipeline-helper'import { useReplicationSourcesQuery } from '@/data/replication/sources-query'import { useStartPipelineMutation } from '@/data/replication/start-pipeline-mutation'import { useUpdateDestinationPipelineMutation } from '@/data/replication/update-destination-pipeline-mutation'@@ -34,7 +33,6 @@ import { type ResponseError } from '@/types'export const useDestinationForm = ({ selectedType }: { selectedType: DestinationType }) => {const { ref: projectRef } = useParams()const { setRequestStatus } = usePipelineRequestStatus()- const { restartPipeline } = useRestartPipelineHelper()const [hasRunValidation, setHasRunValidation] = useState(false)const [destinationValidationFailures, setDestinationValidationFailures] = useState<@@ -238,13 +236,13 @@ export const useDestinationForm = ({ selectedType }: { selectedType: Destinationconst snapshot =existingDestination.statusName ?? (existingDestination.enabled ? 'started' : 'stopped')if (existingDestination.enabled) {+ // The pipeline restarts automatically on the backend when its config is updatedsetRequestStatus(existingDestination.pipelineId,PipelineStatusRequestStatus.RestartRequested,snapshot)toast.success('Settings applied. Restarting the pipeline...')- restartPipeline({ projectRef, pipelineId: existingDestination.pipelineId })} else {setRequestStatus(existingDestination.pipelineId,diff --git a/apps/studio/components/interfaces/Database/Replication/UpdateVersionModal.tsx b/apps/studio/components/interfaces/Database/Replication/UpdateVersionModal.tsxindex 70f79357082..49d07983737 100644--- a/apps/studio/components/interfaces/Database/Replication/UpdateVersionModal.tsx+++ b/apps/studio/components/interfaces/Database/Replication/UpdateVersionModal.tsx@@ -9,7 +9,6 @@ import { PipelineStatusName, STATUS_REFRESH_FREQUENCY_MS } from './Replication.cimport { useReplicationPipelineStatusQuery } from '@/data/replication/pipeline-status-query'import { useReplicationPipelineVersionQuery } from '@/data/replication/pipeline-version-query'import { Pipeline } from '@/data/replication/pipelines-query'-import { useRestartPipelineHelper } from '@/data/replication/restart-pipeline-helper'import { useUpdatePipelineVersionMutation } from '@/data/replication/update-pipeline-version-mutation'import {PipelineStatusRequestStatus,@@ -41,7 +40,9 @@ export const UpdateVersionModal = ({)const pipelineStatus = pipelineStatusData?.statusconst statusName = getStatusName(pipelineStatus)- const isStopped = statusName === PipelineStatusName.STOPPED+ // Treat an unresolved/unknown status as stopped so we don't optimistically claim a restart+ // for a pipeline whose active state hasn't been confirmed yet.+ const isStopped = statusName === undefined || statusName === PipelineStatusName.STOPPEDconst { data: versionData, isPending: isLoadingVersion } = useReplicationPipelineVersionQuery({projectRef,@@ -51,7 +52,6 @@ export const UpdateVersionModal = ({const newVersionName = versionData?.new_version?.nameconst { mutateAsync: updatePipelineVersion } = useUpdatePipelineVersionMutation()- const { restartPipeline } = useRestartPipelineHelper()const onConfirmUpdate = async () => {if (!projectRef || !pipeline?.id) return@@ -68,19 +68,10 @@ export const UpdateVersionModal = ({return}- // Step 2: Reflect optimistic restart (only if not stopped) and close any panels+ // Step 2: Reflect optimistic restart status (the pipeline restarts automatically on the backend)if (!isStopped) {setRequestStatus(pipeline.id, PipelineStatusRequestStatus.RestartRequested, statusName)-- // Step 3: Restart the pipeline (stop + start)- try {- await restartPipeline({ projectRef, pipelineId: pipeline.id })- toast.success('Pipeline successfully updated and is currently restarting')- } catch (e) {- // Clear optimistic state and surface a single concise error- setRequestStatus(pipeline.id, PipelineStatusRequestStatus.None)- toast.error(`Failed to restart pipeline: ${(e as ResponseError).message}`)- }+ toast.success('Pipeline successfully updated and is currently restarting')} else {toast.success('Pipeline successfully updated')}