An agentic skills framework & software development methodology that works.
Integrate testing-anti-patterns into test-driven-development
Jesse Vincent718ec45d3358
diff --git a/README.md b/README.mdindex 98436c9dc..c0223c208 100644--- a/README.md+++ b/README.md@@ -100,9 +100,8 @@ Fetch and follow instructions from https://raw.githubusercontent.com/obra/superp### Skills Library**Testing**-- **test-driven-development** - RED-GREEN-REFACTOR cycle+- **test-driven-development** - RED-GREEN-REFACTOR cycle (includes anti-patterns reference)- **condition-based-waiting** - Async test patterns-- **testing-anti-patterns** - Common pitfalls to avoid**Debugging**- **systematic-debugging** - 4-phase root cause processdiff --git a/skills/test-driven-development/SKILL.md b/skills/test-driven-development/SKILL.mdindex fa8004b16..b138985a4 100644--- a/skills/test-driven-development/SKILL.md+++ b/skills/test-driven-development/SKILL.md@@ -354,6 +354,13 @@ Bug found? Write failing test reproducing it. Follow TDD cycle. Test proves fixNever fix bugs without a test.+## Testing Anti-Patterns++When adding mocks or test utilities, read @testing-anti-patterns.md to avoid common pitfalls:+- Testing mock behavior instead of real behavior+- Adding test-only methods to production classes+- Mocking without understanding dependencies+## Final Rule```diff --git a/skills/testing-anti-patterns/SKILL.md b/skills/test-driven-development/testing-anti-patterns.mdsimilarity index 96%rename from skills/testing-anti-patterns/SKILL.mdrename to skills/test-driven-development/testing-anti-patterns.mdindex acf3a98b4..e77ab6b6d 100644--- a/skills/testing-anti-patterns/SKILL.md+++ b/skills/test-driven-development/testing-anti-patterns.md@@ -1,10 +1,7 @@-----name: testing-anti-patterns-description: Use when writing or changing tests, adding mocks, or tempted to add test-only methods to production code - prevents testing mock behavior, production pollution with test-only methods, and mocking without understanding dependencies-----# Testing Anti-Patterns+**Load this reference when:** writing or changing tests, adding mocks, or tempted to add test-only methods to production code.+## OverviewTests must verify real behavior, not mock behavior. Mocks are a means to isolate, not the thing being tested.