An agentic skills framework & software development methodology that works.
Scope spec reviewer to task diff and make reviewers read-only
Jesse Vincent8ed7c499b37c
diff --git a/skills/requesting-code-review/code-reviewer.md b/skills/requesting-code-review/code-reviewer.mdindex eb3ad887b..e6089c9eb 100644--- a/skills/requesting-code-review/code-reviewer.md+++ b/skills/requesting-code-review/code-reviewer.md@@ -30,6 +30,10 @@ Subagent (general-purpose):git diff {BASE_SHA}..{HEAD_SHA}```+ ## Read-Only Review++ Your review is read-only on this checkout. Do not mutate the working tree, the index, HEAD, or branch state in any way. Use tools like `git show`, `git diff`, and `git log` to inspect history. If you need a working copy of a different revision, check it out into a separate temporary directory (e.g. `git worktree add /tmp/review-{SHA} {SHA}`) — never move HEAD on this checkout.+## What to Check**Plan alignment:**diff --git a/skills/subagent-driven-development/spec-reviewer-prompt.md b/skills/subagent-driven-development/spec-reviewer-prompt.mdindex 4ac2d7b47..1cc84a76a 100644--- a/skills/subagent-driven-development/spec-reviewer-prompt.md+++ b/skills/subagent-driven-development/spec-reviewer-prompt.md@@ -18,6 +18,22 @@ Subagent (general-purpose):[From implementer's report]+ ## Git Range to Review++ **Base:** [BASE_SHA — commit before this task]+ **Head:** [HEAD_SHA — current commit]++ ```bash+ git diff --stat [BASE_SHA]..[HEAD_SHA]+ git diff [BASE_SHA]..[HEAD_SHA]+ ```++ Only read files in this diff. Do not crawl the broader codebase.++ ## Read-Only Review++ Your review is read-only on this checkout. Do not mutate the working tree, the index, HEAD, or branch state in any way. Use tools like `git show`, `git diff`, and `git log` to inspect history. If you need a working copy of a different revision, check it out into a separate temporary directory (e.g. `git worktree add /tmp/review-[SHA] [SHA]`) — never move HEAD on this checkout.+## CRITICAL: Do Not Trust the ReportThe implementer finished suspiciously quickly. Their report may be incomplete,