An agentic skills framework & software development methodology that works.
fix(sdd): write artifacts to working-tree .superpowers/sdd, not .git/ (#1780)
Jesse Vincent93b8444b51ae
diff --git a/skills/subagent-driven-development/SKILL.md b/skills/subagent-driven-development/SKILL.mdindex 267604300..b3dfb6f9a 100644--- a/skills/subagent-driven-development/SKILL.md+++ b/skills/subagent-driven-development/SKILL.md@@ -251,7 +251,7 @@ sequences — the single most expensive failure observed. Track progress ina ledger file, not only in todos.- At skill start, check for a ledger:- `cat "$(git rev-parse --git-path sdd)/progress.md"`. Tasks listed there+ `cat "$(git rev-parse --show-toplevel)/.superpowers/sdd/progress.md"`. Tasks listed thereas complete are DONE — do not re-dispatch them; resume at the first tasknot marked complete.- When a task's review comes back clean, append one line to the ledger indiff --git a/skills/subagent-driven-development/scripts/review-package b/skills/subagent-driven-development/scripts/review-packageindex 88a00224d..33bb20f73 100755--- a/skills/subagent-driven-development/scripts/review-package+++ b/skills/subagent-driven-development/scripts/review-package@@ -5,9 +5,8 @@# tasks intact.## Usage: review-package BASE HEAD [OUTFILE]-# Default OUTFILE: <git-dir>/sdd/review-<base7>..<head7>.diff — unique per-# repo instance and per range, so concurrent sessions cannot collide and a-# re-review after fixes always gets a distinctly named fresh file.+# Default OUTFILE: <repo-root>/.superpowers/sdd/review-<base7>..<head7>.diff+# (named per range, so a re-review after fixes gets a distinct fresh file).set -euo pipefailif [ $# -lt 2 ] || [ $# -gt 3 ]; then@@ -24,9 +23,7 @@ git rev-parse --verify --quiet "$head" >/dev/null || { echo "bad HEAD: $head" >&if [ $# -eq 3 ]; thenout=$3else- dir=$(git rev-parse --git-path sdd)- mkdir -p "$dir"- dir=$(cd "$dir" && pwd)+ dir=$("$(cd "$(dirname "$0")" && pwd)/sdd-workspace")out="$dir/review-$(git rev-parse --short "$base")..$(git rev-parse --short "$head").diff"fidiff --git a/skills/subagent-driven-development/scripts/task-brief b/skills/subagent-driven-development/scripts/task-briefindex b046a2bb1..247a76701 100755--- a/skills/subagent-driven-development/scripts/task-brief+++ b/skills/subagent-driven-development/scripts/task-brief@@ -4,8 +4,8 @@# through the controller's context.## Usage: task-brief PLAN_FILE TASK_NUMBER [OUTFILE]-# Default OUTFILE: <git-dir>/sdd/task-<N>-brief.md — unique per repo-# instance, so concurrent sessions cannot collide.+# Default OUTFILE: <repo-root>/.superpowers/sdd/task-<N>-brief.md+# (per worktree; concurrent runs in the same working tree share it).set -euo pipefailif [ $# -lt 2 ] || [ $# -gt 3 ]; then@@ -20,9 +20,7 @@ n=$2if [ $# -eq 3 ]; thenout=$3else- dir=$(git rev-parse --git-path sdd)- mkdir -p "$dir"- dir=$(cd "$dir" && pwd)+ dir=$("$(cd "$(dirname "$0")" && pwd)/sdd-workspace")out="$dir/task-${n}-brief.md"fidiff --git a/tests/claude-code/test-sdd-workspace.sh b/tests/claude-code/test-sdd-workspace.shindex 06ce2fff5..d367f14a5 100755--- a/tests/claude-code/test-sdd-workspace.sh+++ b/tests/claude-code/test-sdd-workspace.sh@@ -71,6 +71,42 @@ main() {echo " staged: $staged"fi+ cat > "$repo/plan.md" <<'PLAN'+# Plan++## Task 1: First thing++Do the first thing.+PLAN++ local brief_out brief_path+ brief_out="$(cd "$repo" && "$SDD_SCRIPTS/task-brief" plan.md 1)"+ brief_path="$(printf '%s\n' "$brief_out" | sed -n 's/^wrote \(.*\): [0-9][0-9]* lines$/\1/p')"+ case "$brief_path" in+ "$repo/.superpowers/sdd/"*) pass "task-brief writes its brief under the workspace" ;;+ *)+ fail "task-brief writes its brief under the workspace"+ echo " got: $brief_path"+ ;;+ esac++ local git_id=(-c [email protected] -c user.name=t -c commit.gpgsign=false)+ ( cd "$repo" \+ && git add plan.md \+ && git "${git_id[@]}" commit -qm c1 \+ && printf 'y\n' > f && git add f \+ && git "${git_id[@]}" commit -qm c2 )+ local rp_out rp_path+ rp_out="$(cd "$repo" && "$SDD_SCRIPTS/review-package" HEAD~1 HEAD)"+ rp_path="$(printf '%s\n' "$rp_out" | sed -n 's/^wrote \(.*\): [0-9].*$/\1/p')"+ case "$rp_path" in+ "$repo/.superpowers/sdd/"*) pass "review-package writes its diff under the workspace" ;;+ *)+ fail "review-package writes its diff under the workspace"+ echo " got: $rp_path"+ ;;+ esac+echo ""if [[ "$FAILURES" -ne 0 ]]; thenecho "FAILED: $FAILURES assertion(s)."