An agentic skills framework & software development methodology that works.
Address adversarial review findings
Jesse Vincenta32510650245
diff --git a/CLAUDE.md b/CLAUDE.mdindex d83679f3a..3e389f4ac 100644--- a/CLAUDE.md+++ b/CLAUDE.md@@ -101,7 +101,7 @@ Skills are not prose — they are code that shapes agent behavior. If you modify## Eval harness-Skill-behavior evals live at `evals/` — see `evals/README.md`. Drill (the harness) drives real tmux sessions of Claude Code / Codex / Gemini CLI / Copilot CLI and judges skill compliance with an LLM verifier. Plugin-infrastructure tests still live at `tests/`.+Skill-behavior evals live at `evals/` — see `evals/README.md`. Drill (the harness) drives real tmux sessions of Claude Code / Codex / Gemini CLI and judges skill compliance with an LLM verifier. Plugin-infrastructure tests still live at `tests/`.## Understand the Project Before Contributingdiff --git a/docs/testing.md b/docs/testing.mdindex fa504dfbd..ac5a00502 100644--- a/docs/testing.md+++ b/docs/testing.md@@ -3,7 +3,7 @@Superpowers has two distinct kinds of tests, each in its own directory:- **`tests/`** — does the plugin's non-LLM code work? Bash + node + python integration tests for brainstorm-server JS, OpenCode plugin loading, codex-plugin sync, and analysis utilities.-- **`evals/`** — do agents behave correctly on real LLM sessions? Python harness driving real tmux sessions of Claude Code / Codex / Gemini CLI / Copilot CLI, with an LLM actor and verifier judging skill compliance.+- **`evals/`** — do agents behave correctly on real LLM sessions? Python harness driving real tmux sessions of Claude Code / Codex / Gemini CLI, with an LLM actor and verifier judging skill compliance.## Plugin testsdiff --git a/evals/CLAUDE.md b/evals/CLAUDE.mdindex 43cce6a05..e80b39ca6 100644--- a/evals/CLAUDE.md+++ b/evals/CLAUDE.md@@ -4,7 +4,7 @@ Superpowers skill compliance benchmark. Python 3.11+, managed with uv.## Commands-- **install**: `uv sync --dev`+- **install**: `uv sync --extra dev`- **test**: `uv run pytest`- **test single**: `uv run pytest tests/test_engine.py -x -q`- **lint**: `uv run ruff check`diff --git a/evals/README.md b/evals/README.mdindex 1e9fab2f3..1791dd4a1 100644--- a/evals/README.md+++ b/evals/README.md@@ -15,7 +15,7 @@ correctly.## Setup```bash-uv sync --dev+uv sync --extra dev```Required environment:diff --git a/tests/claude-code/README.md b/tests/claude-code/README.mdindex 473f1f28e..90f1fe1ae 100644--- a/tests/claude-code/README.md+++ b/tests/claude-code/README.md@@ -115,17 +115,12 @@ Full workflow execution test (~10-30 minutes):- Subagents follow the skill correctly- Final code is functional and tested-#### test-requesting-code-review.sh-Behavioral test for the code reviewer subagent (~5 minutes):-- Builds a tiny project with a baseline commit-- Adds a second commit that plants two real bugs (SQL injection, plaintext password handling)-- Dispatches the code reviewer via the requesting-code-review skill-- Verifies the reviewer flags the planted bugs at Critical/Important severity and refuses to approve--**What it tests:**-- The skill actually dispatches a working code reviewer subagent-- The reviewer template produces reviewers that catch obvious security bugs-- The reviewer is not sycophantic — it does not approve a diff with planted Critical issues+#### test-worktree-native-preference.sh+RED-GREEN-REFACTOR validation for the using-git-worktrees skill (~5 minutes):+- RED: skill without Step 1a — agent should use `git worktree add`+- GREEN: skill with Step 1a — agent should use the native EnterWorktree tool+- PRESSURE: same as GREEN under urgency framing with pre-existing `.worktrees/`+- Drill scenario `worktree-creation-under-pressure.yaml` covers the PRESSURE phase only## Adding New Testsdiff --git a/tests/claude-code/run-skill-tests.sh b/tests/claude-code/run-skill-tests.shindex 023e97940..3e339fd3d 100755--- a/tests/claude-code/run-skill-tests.sh+++ b/tests/claude-code/run-skill-tests.sh@@ -79,7 +79,6 @@ tests=(# Integration tests (slow, full execution)integration_tests=("test-subagent-driven-development-integration.sh"- "test-requesting-code-review.sh")# Add integration tests if requested