An agentic skills framework & software development methodology that works.
fix: auto-foreground brainstorm server on Windows/Git Bash
jessec6a2b1b57633
diff --git a/CHANGELOG.md b/CHANGELOG.mdnew file mode 100644index 000000000..c011c5f37--- /dev/null+++ b/CHANGELOG.md@@ -0,0 +1,11 @@+# Changelog++## Unreleased++### Fixed++- **Brainstorm server on Windows**: Auto-detect Windows/Git Bash (`OSTYPE=msys*`, `MSYSTEM`) and switch to foreground mode, fixing silent server failure caused by `nohup`/`disown` process reaping. Applies to all Windows shells (CMD, PowerShell, Git Bash) since they all route through Git Bash. (fixes #737, based on #740)++### Known Issues++- **`BRAINSTORM_OWNER_PID` on Windows (main branch only)**: The main branch's `server.js` uses `process.kill(OWNER_PID, 0)` for lifecycle checks, but receives MSYS2 PIDs which are invisible to Node.js (different PID namespace). This causes the server to self-terminate after 60 seconds. Fix: resolve `OWNER_PID` via `/proc/$PPID/winpid` to get the Windows-native PID. The dev branch's `index.js` does not have this issue since it has no OWNER_PID lifecycle check.diff --git a/skills/brainstorming/scripts/start-server.sh b/skills/brainstorming/scripts/start-server.shindex b5f5a75f7..cb62a6d99 100755--- a/skills/brainstorming/scripts/start-server.sh+++ b/skills/brainstorming/scripts/start-server.sh@@ -64,6 +64,16 @@ if [[ -n "${CODEX_CI:-}" && "$FOREGROUND" != "true" && "$FORCE_BACKGROUND" != "tFOREGROUND="true"fi+# Windows/Git Bash reaps nohup background processes. Auto-foreground when detected.+if [[ "$FOREGROUND" != "true" && "$FORCE_BACKGROUND" != "true" ]]; then+ case "${OSTYPE:-}" in+ msys*|cygwin*|mingw*) FOREGROUND="true" ;;+ esac+ if [[ -n "${MSYSTEM:-}" ]]; then+ FOREGROUND="true"+ fi+fi+# Generate unique session directorySESSION_ID="$$-$(date +%s)"diff --git a/skills/brainstorming/visual-companion.md b/skills/brainstorming/visual-companion.mdindex a25e85aa1..2c35d5d7f 100644--- a/skills/brainstorming/visual-companion.md+++ b/skills/brainstorming/visual-companion.md@@ -61,6 +61,14 @@ scripts/start-server.sh --project-dir /path/to/projectscripts/start-server.sh --project-dir /path/to/project```+**Windows (Git Bash / CMD / PowerShell):**+```bash+# Windows/Git Bash reaps nohup background processes. The script auto-detects+# this via OSTYPE/MSYSTEM and switches to foreground mode automatically.+# No extra flags needed — all Windows shells route through Git Bash.+scripts/start-server.sh --project-dir /path/to/project+```+**Gemini CLI:**```bash# Use --foreground and set is_background: true on your shell tool call