Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Potential fix for pull request finding 'CodeQL / Loop bound injection'

Andrii Romasiun263c2161764c
diff --git a/backend/apps/cloud/src/project/project.controller.ts b/backend/apps/cloud/src/project/project.controller.ts
index 60e300983..29273bf6d 100644
--- a/backend/apps/cloud/src/project/project.controller.ts
+++ b/backend/apps/cloud/src/project/project.controller.ts
@@ -117,6 +117,7 @@ import { PendingInvitationType } from '../pending-invitation/pending-invitation.
import { PlanCode } from '../user/entities/user.entity'
const PROJECTS_MAXIMUM = 50
+const BLACKLIST_ITEMS_MAXIMUM = 1000
const isValidShareDTO = (share: ShareDTO): boolean => {
return !_isEmpty(_trim(share.email)) && _includes(roles, share.role)
@@ -1788,9 +1789,13 @@ export class ProjectController {
}
if (projectDTO.ipBlacklist !== undefined) {
- project.ipBlacklist = projectDTO.ipBlacklist
- ? (_map(projectDTO.ipBlacklist, _trim) as string[])
- : null
+ project.ipBlacklist =
+ Array.isArray(projectDTO.ipBlacklist) && projectDTO.ipBlacklist.length > 0
+ ? (_map(
+ projectDTO.ipBlacklist.slice(0, BLACKLIST_ITEMS_MAXIMUM),
+ _trim,
+ ) as string[])
+ : null
}
if (projectDTO.countryBlacklist !== undefined) {