📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!
TypeScript chartsclickhousedockergdprgoogle-analyticsmetricsmonitoringmysqlnestjsprivacyredisself-hostedselfhostedstatisticstailwindcssweb-analyticswebanalyticswebsite
fix potential security issues & code quality improvements
Blue Mouse2b9e2815e2c4
diff --git a/backend/apps/cloud/src/experiment/bayesian.ts b/backend/apps/cloud/src/experiment/bayesian.tsindex 9fee80f76..a7e83931c 100644--- a/backend/apps/cloud/src/experiment/bayesian.ts+++ b/backend/apps/cloud/src/experiment/bayesian.ts@@ -45,7 +45,6 @@ function seedFromVariants(.sort((a, b) => a.key.localeCompare(b.key)).map(v => `${v.key}:${v.exposures}:${v.conversions}`).join('|')- // Mix in simulations so changing it changes output deterministically.return (fnv1a32(normalized) ^ (simulations >>> 0)) >>> 0}@@ -58,7 +57,6 @@ function seedFromVariants(* Then X / (X + Y) ~ Beta(alpha, beta)*/function sampleGamma(shape: number, random: RandomFn): number {- // For shape >= 1, use Marsaglia and Tsang's methodif (shape >= 1) {const d = shape - 1 / 3const c = 1 / Math.sqrt(9 * d)@@ -68,7 +66,6 @@ function sampleGamma(shape: number, random: RandomFn): number {let v: numberdo {- // Generate standard normal using Box-Mullerconst u1 = Math.max(random(), Number.EPSILON)const u2 = random()x = Math.sqrt(-2 * Math.log(u1)) * Math.cos(2 * Math.PI * u2)@@ -88,9 +85,6 @@ function sampleGamma(shape: number, random: RandomFn): number {}}- // For shape < 1, use the transformation:- // If X ~ Gamma(shape + 1, 1), then X * U^(1/shape) ~ Gamma(shape, 1)- // where U ~ Uniform(0, 1)const sample = sampleGamma(shape + 1, random)const u = random()return sample * Math.pow(u, 1 / shape)@@ -129,10 +123,8 @@ export function calculateBayesianProbabilities(return new Map()}- // Sanitize simulations: ensure it's a positive integer to avoid division by zero and invalid seedssimulations = Math.max(1, Math.floor(simulations))- // Sanitize variant data: clamp exposures and conversions to valid rangesconst sanitizedVariants = variants.map(v => {const exposures = Math.max(0, Math.floor(v.exposures))const conversions = Math.min(@@ -146,40 +138,30 @@ export function calculateBayesianProbabilities(return new Map([[sanitizedVariants[0].key, 1]])}- // Check if we have any data at all (recompute from sanitized values)const totalExposures = sanitizedVariants.reduce((sum, v) => sum + v.exposures,0,)if (totalExposures === 0) {- // No data yet - equal probability for all variantsconst prob = 1 / sanitizedVariants.lengthreturn new Map(sanitizedVariants.map(v => [v.key, prob]))}- // Count wins for each variantconst wins = new Map<string, number>()for (const v of sanitizedVariants) {wins.set(v.key, 0)}- // Use deterministic PRNG so the same input always produces the same output.- // This prevents slight "drift" between the table value and the last chart point.const random = mulberry32(seedFromVariants(sanitizedVariants, simulations))- // Run Monte Carlo simulationfor (let i = 0; i < simulations; i++) {let bestRate = -1let bestKey = ''for (const variant of sanitizedVariants) {- // Calculate Beta distribution parameters- // alpha = conversions + 1 (prior success)- // beta = exposures - conversions + 1 (prior failure)const alpha = variant.conversions + 1const beta = Math.max(1, variant.exposures - variant.conversions + 1)- // Sample from the Beta distributionconst rate = sampleBeta(alpha, beta, random)if (rate > bestRate) {@@ -188,11 +170,9 @@ export function calculateBayesianProbabilities(}}- // Increment win count for the best variant in this simulationwins.set(bestKey, (wins.get(bestKey) || 0) + 1)}- // Convert wins to probabilitiesconst probabilities = new Map<string, number>()for (const [key, winCount] of wins) {probabilities.set(key, winCount / simulations)diff --git a/backend/apps/cloud/src/experiment/dto/experiment.dto.ts b/backend/apps/cloud/src/experiment/dto/experiment.dto.tsindex 74811c8f2..e5f80ebca 100644--- a/backend/apps/cloud/src/experiment/dto/experiment.dto.ts+++ b/backend/apps/cloud/src/experiment/dto/experiment.dto.ts@@ -11,6 +11,8 @@ import {Max,MaxLength,IsUUID,+ IsNotEmpty,+ Matches,} from 'class-validator'import { Type } from 'class-transformer'import {@@ -19,6 +21,7 @@ import {MultipleVariantHandling,FeatureFlagMode,} from '../entity/experiment.entity'+import { PID_REGEX } from '../../common/constants'export class ExperimentVariantDto {@ApiProperty()@@ -49,8 +52,12 @@ export class ExperimentVariantDto {}export class CreateExperimentDto {- @ApiProperty()- @IsString()+ @ApiProperty({+ description: 'The project ID',+ example: 'aHbCdEfGhIjK',+ })+ @IsNotEmpty()+ @Matches(PID_REGEX, { message: 'The provided Project ID (pid) is incorrect' })pid: string@ApiProperty()@@ -70,7 +77,6 @@ export class CreateExperimentDto {@MaxLength(500)hypothesis?: string- // Exposure criteria@ApiPropertyOptional({ enum: ExposureTrigger })@IsOptional()@IsEnum(ExposureTrigger)@@ -92,7 +98,6 @@ export class CreateExperimentDto {@IsBoolean()filterInternalUsers?: boolean- // Feature flag configuration@ApiPropertyOptional({ enum: FeatureFlagMode })@IsOptional()@IsEnum(FeatureFlagMode)@@ -140,7 +145,6 @@ export class UpdateExperimentDto {@MaxLength(500)hypothesis?: string- // Exposure criteria@ApiPropertyOptional({ enum: ExposureTrigger })@IsOptional()@IsEnum(ExposureTrigger)@@ -162,7 +166,6 @@ export class UpdateExperimentDto {@IsBoolean()filterInternalUsers?: boolean- // Feature flag configuration@ApiPropertyOptional({ enum: FeatureFlagMode })@IsOptional()@IsEnum(FeatureFlagMode)@@ -208,7 +211,6 @@ export class ExperimentDto {@ApiProperty({ enum: ExperimentStatus })status: ExperimentStatus- // Exposure criteria@ApiProperty({ enum: ExposureTrigger })exposureTrigger: ExposureTrigger@@ -221,7 +223,6 @@ export class ExperimentDto {@ApiProperty()filterInternalUsers: boolean- // Feature flag configuration@ApiProperty({ enum: FeatureFlagMode })featureFlagMode: FeatureFlagMode@@ -273,7 +274,7 @@ export class VariantResultDto {probabilityOfBeingBest: number@ApiProperty()- improvement: number // % improvement over control+ improvement: number}export class ExperimentChartDataDto {@@ -312,7 +313,7 @@ export class ExperimentResultsDto {winnerKey: string | null@ApiProperty()- confidenceLevel: number // e.g., 95 for 95% confidence+ confidenceLevel: number@ApiPropertyOptional({ type: ExperimentChartDataDto })chart?: ExperimentChartDataDtodiff --git a/backend/apps/cloud/src/experiment/entity/experiment.entity.ts b/backend/apps/cloud/src/experiment/entity/experiment.entity.tsindex e468c72dc..35b919d64 100644--- a/backend/apps/cloud/src/experiment/entity/experiment.entity.ts+++ b/backend/apps/cloud/src/experiment/entity/experiment.entity.ts@@ -21,22 +21,19 @@ export enum ExperimentStatus {COMPLETED = 'completed',}-// Exposure trigger type - determines how users are considered exposed to the experimentexport enum ExposureTrigger {- FEATURE_FLAG = 'feature_flag', // Default: When $feature_flag_called event is recorded- CUSTOM_EVENT = 'custom_event', // Custom: When a specific custom event is recorded+ FEATURE_FLAG = 'feature_flag',+ CUSTOM_EVENT = 'custom_event',}-// How to handle users exposed to multiple variantsexport enum MultipleVariantHandling {- EXCLUDE = 'exclude', // Exclude from analysis (recommended)- FIRST_EXPOSURE = 'first_exposure', // Use first exposure only+ EXCLUDE = 'exclude',+ FIRST_EXPOSURE = 'first_exposure',}-// Feature flag mode - create new or link existingexport enum FeatureFlagMode {- CREATE = 'create', // Create a new feature flag for this experiment- LINK = 'link', // Link an existing multivariate feature flag+ CREATE = 'create',+ LINK = 'link',}@Entity()@@ -65,7 +62,6 @@ export class Experiment {})status: ExperimentStatus- // Exposure criteria@ApiProperty()@Column({type: 'enum',@@ -90,7 +86,6 @@ export class Experiment {@Column('boolean', { default: true })filterInternalUsers: boolean- // Feature flag configuration@ApiProperty()@Column({type: 'enum',diff --git a/backend/apps/cloud/src/experiment/experiment.controller.ts b/backend/apps/cloud/src/experiment/experiment.controller.tsindex 4d5aace8d..fc601d9c2 100644--- a/backend/apps/cloud/src/experiment/experiment.controller.ts+++ b/backend/apps/cloud/src/experiment/experiment.controller.ts@@ -13,6 +13,8 @@ import {HttpException,HttpStatus,ParseIntPipe,+ Headers,+ Ip,} from '@nestjs/common'import {ApiTags,@@ -37,6 +39,7 @@ import {} from '../analytics/analytics.service'import { Auth } from '../auth/decorators'import { CurrentUserId } from '../auth/decorators/current-user-id.decorator'+import { checkRateLimit, getIPFromHeaders } from '../common/utils'import {Experiment,ExperimentStatus,@@ -156,9 +159,15 @@ export class ExperimentController {async createExperiment(@Body() experimentDto: CreateExperimentDto,@CurrentUserId() uid: string,+ @Headers() headers: Record<string, string>,+ @Ip() reqIP: string,) {this.logger.log({ uid, pid: experimentDto.pid }, 'POST /experiment')+ const ip = getIPFromHeaders(headers) || reqIP+ await checkRateLimit(ip, 'experiment-create', 20, 3600)+ await checkRateLimit(uid, 'experiment-create', 20, 3600)+const user = await this.userService.findOne({where: { id: uid },relations: ['projects'],@@ -210,7 +219,6 @@ export class ExperimentController {)}- // Validate variantsif (!experimentDto.variants || experimentDto.variants.length < 2) {throw new BadRequestException('An experiment must have at least 2 variants',@@ -233,7 +241,6 @@ export class ExperimentController {)}- // Get goal if providedlet goal = nullif (experimentDto.goalId) {goal = await this.goalService.findOne({@@ -244,7 +251,6 @@ export class ExperimentController {}}- // Validate exposure criteriaif (experimentDto.exposureTrigger === ExposureTrigger.CUSTOM_EVENT &&!experimentDto.customEventName?.trim()@@ -254,7 +260,6 @@ export class ExperimentController {)}- // Handle feature flag modelet existingFeatureFlag: FeatureFlag | null = nullif (experimentDto.featureFlagMode === FeatureFlagMode.LINK) {if (!experimentDto.existingFeatureFlagId) {@@ -279,7 +284,6 @@ export class ExperimentController {}try {- // Create the experimentconst experiment = new Experiment()experiment.name = experimentDto.nameexperiment.description = experimentDto.description || null@@ -288,7 +292,6 @@ export class ExperimentController {experiment.project = projectexperiment.goal = goal- // Exposure criteriaexperiment.exposureTrigger =experimentDto.exposureTrigger || ExposureTrigger.FEATURE_FLAGexperiment.customEventName = experimentDto.customEventName || null@@ -297,13 +300,11 @@ export class ExperimentController {experiment.filterInternalUsers =experimentDto.filterInternalUsers !== false- // Feature flag configurationexperiment.featureFlagMode =experimentDto.featureFlagMode || FeatureFlagMode.CREATEexperiment.featureFlagKey = experimentDto.featureFlagKey || nullexperiment.featureFlag = existingFeatureFlag- // Create variantsexperiment.variants = experimentDto.variants.map(v => {const variant = new ExperimentVariant()variant.name = v.name@@ -316,7 +317,6 @@ export class ExperimentController {const newExperiment = await this.experimentService.create(experiment)- // If linking existing flag, update it with experiment IDif (existingFeatureFlag) {await this.featureFlagService.update(existingFeatureFlag.id, {experimentId: newExperiment.id,@@ -344,9 +344,15 @@ export class ExperimentController {@Param('id') id: string,@Body() experimentDto: UpdateExperimentDto,@CurrentUserId() uid: string,+ @Headers() headers: Record<string, string>,+ @Ip() reqIP: string,) {this.logger.log({ id, uid }, 'PUT /experiment/:id')+ const ip = getIPFromHeaders(headers) || reqIP+ await checkRateLimit(ip, 'experiment-update', 30, 3600)+ await checkRateLimit(uid, 'experiment-update', 30, 3600)+const experiment = await this.experimentService.findOneWithRelations(id)if (_isEmpty(experiment)) {@@ -359,19 +365,16 @@ export class ExperimentController {'You are not allowed to manage this experiment',)- // Cannot update running experiments (except for pausing)if (experiment.status === ExperimentStatus.RUNNING) {throw new BadRequestException('Cannot update a running experiment. Pause it first.',)}- // Cannot update completed experimentsif (experiment.status === ExperimentStatus.COMPLETED) {throw new BadRequestException('Cannot update a completed experiment')}- // Update goal if providedlet goal = experiment.goalif (experimentDto.goalId !== undefined) {if (experimentDto.goalId) {@@ -389,7 +392,6 @@ export class ExperimentController {}}- // Update variants if providedif (experimentDto.variants) {if (experimentDto.variants.length < 2) {throw new BadRequestException(@@ -413,7 +415,6 @@ export class ExperimentController {)}- // Delete old variants and create new onesawait this.experimentService.deleteVariantsByExperiment(id)for (const v of experimentDto.variants) {@@ -428,7 +429,6 @@ export class ExperimentController {}}- // Validate exposure criteriaconst exposureTrigger =experimentDto.exposureTrigger ?? experiment.exposureTriggerconst customEventName =@@ -442,7 +442,6 @@ export class ExperimentController {)}- // Handle feature flag mode changeslet featureFlag = experiment.featureFlagif (experimentDto.featureFlagMode !== undefined &&@@ -468,13 +467,11 @@ export class ExperimentController {'This feature flag is already linked to another experiment',)}- // Unlink old flag if existsif (experiment.featureFlag) {await this.featureFlagService.update(experiment.featureFlag.id, {experimentId: null,})}- // Link new flagawait this.featureFlagService.update(existingFlag.id, {experimentId: id,})@@ -498,7 +495,6 @@ export class ExperimentController {featureFlag,}- // Remove undefined valuesObject.keys(updatePayload).forEach(key => {if (updatePayload[key] === undefined) {delete updatePayload[key]@@ -529,9 +525,15 @@ export class ExperimentController {async deleteExperiment(@Param('id') id: string,@CurrentUserId() uid: string,+ @Headers() headers: Record<string, string>,+ @Ip() reqIP: string,) {this.logger.log({ id, uid }, 'DELETE /experiment/:id')+ const ip = getIPFromHeaders(headers) || reqIP+ await checkRateLimit(ip, 'experiment-delete', 20, 3600)+ await checkRateLimit(uid, 'experiment-delete', 20, 3600)+const experiment = await this.experimentService.findOneWithRelations(id)if (_isEmpty(experiment)) {@@ -544,13 +546,10 @@ export class ExperimentController {'You are not allowed to manage this experiment',)- // Handle feature flag - delete if created for this experiment, unlink if linkedif (experiment.featureFlag) {if (experiment.featureFlagMode === FeatureFlagMode.CREATE) {- // Delete the flag that was created specifically for this experimentawait this.featureFlagService.delete(experiment.featureFlag.id)} else {- // Just unlink the flag, don't delete itawait this.featureFlagService.update(experiment.featureFlag.id, {experimentId: null,})@@ -565,9 +564,18 @@ export class ExperimentController {@Auth()@ApiResponse({ status: 200, type: ExperimentDto })@ApiOperation({ summary: 'Start an experiment' })- async startExperiment(@Param('id') id: string, @CurrentUserId() uid: string) {+ async startExperiment(+ @Param('id') id: string,+ @CurrentUserId() uid: string,+ @Headers() headers: Record<string, string>,+ @Ip() reqIP: string,+ ) {this.logger.log({ id, uid }, 'POST /experiment/:id/start')+ const ip = getIPFromHeaders(headers) || reqIP+ await checkRateLimit(ip, 'experiment-lifecycle', 30, 3600)+ await checkRateLimit(uid, 'experiment-lifecycle', 30, 3600)+const experiment = await this.experimentService.findOneWithRelations(id)if (_isEmpty(experiment)) {@@ -594,17 +602,13 @@ export class ExperimentController {)}- // Create or update the feature flag for this experimentlet featureFlag = experiment.featureFlagif (!featureFlag) {- // Only create new flag if mode is CREATE (not LINK)if (experiment.featureFlagMode === FeatureFlagMode.CREATE) {- // Use custom key if provided, otherwise generate oneconst flagKey =experiment.featureFlagKey?.trim() ||`experiment_${experiment.id.replace(/-/g, '_').substring(0, 20)}`- // Check if key already existsconst existingFlag = await this.featureFlagService.findOne({where: { key: flagKey, project: { id: experiment.project.id } },})@@ -618,7 +622,7 @@ export class ExperimentController {featureFlag.key = flagKeyfeatureFlag.description = `Feature flag for experiment: ${experiment.name}`featureFlag.flagType = FeatureFlagType.ROLLOUT- featureFlag.rolloutPercentage = 100 // We control distribution via variants+ featureFlag.rolloutPercentage = 100featureFlag.enabled = truefeatureFlag.project = experiment.projectfeatureFlag.experimentId = experiment.id@@ -629,7 +633,6 @@ export class ExperimentController {)}} else {- // Enable the existing flagawait this.featureFlagService.update(featureFlag.id, { enabled: true })}@@ -655,9 +658,18 @@ export class ExperimentController {@Auth()@ApiResponse({ status: 200, type: ExperimentDto })@ApiOperation({ summary: 'Pause an experiment' })- async pauseExperiment(@Param('id') id: string, @CurrentUserId() uid: string) {+ async pauseExperiment(+ @Param('id') id: string,+ @CurrentUserId() uid: string,+ @Headers() headers: Record<string, string>,+ @Ip() reqIP: string,+ ) {this.logger.log({ id, uid }, 'POST /experiment/:id/pause')+ const ip = getIPFromHeaders(headers) || reqIP+ await checkRateLimit(ip, 'experiment-lifecycle', 30, 3600)+ await checkRateLimit(uid, 'experiment-lifecycle', 30, 3600)+const experiment = await this.experimentService.findOneWithRelations(id)if (_isEmpty(experiment)) {@@ -674,7 +686,6 @@ export class ExperimentController {throw new BadRequestException('Can only pause a running experiment')}- // Disable the feature flagif (experiment.featureFlag) {await this.featureFlagService.update(experiment.featureFlag.id, {enabled: false,@@ -704,9 +715,15 @@ export class ExperimentController {async completeExperiment(@Param('id') id: string,@CurrentUserId() uid: string,+ @Headers() headers: Record<string, string>,+ @Ip() reqIP: string,) {this.logger.log({ id, uid }, 'POST /experiment/:id/complete')+ const ip = getIPFromHeaders(headers) || reqIP+ await checkRateLimit(ip, 'experiment-lifecycle', 30, 3600)+ await checkRateLimit(uid, 'experiment-lifecycle', 30, 3600)+const experiment = await this.experimentService.findOneWithRelations(id)if (_isEmpty(experiment)) {@@ -728,7 +745,6 @@ export class ExperimentController {)}- // Disable the feature flagif (experiment.featureFlag) {await this.featureFlagService.update(experiment.featureFlag.id, {enabled: false,@@ -783,7 +799,6 @@ export class ExperimentController {const safeTimezone = this.analyticsService.getSafeTimezone(timezone)- // Handle "all" period like analytics controllerlet timeBucket =timeBucketParam || getLowestPossibleTimeBucket(period, from, to)let allowedTimeBucketForPeriodAll: string[] | undefined@@ -813,7 +828,6 @@ export class ExperimentController {diff,)- // Get exposures per variant from ClickHouseconst exposuresQuery = `SELECTvariantKey,@@ -845,8 +859,6 @@ export class ExperimentController {this.logger.warn({ err }, 'Failed to get experiment exposures')}- // Get conversions per variant- // We need to join exposures with goal conversionslet conversionsData: { variantKey: string; conversions: number }[] = []if (experiment.goal) {const goalType = experiment.goal.type@@ -854,7 +866,6 @@ export class ExperimentController {const matchColumn = goalType === 'custom_event' ? 'ev' : 'pg'const goalValue = experiment.goal.value || ''- // Build match condition based on goal match typelet matchCondition = ''if (experiment.goal.matchType === 'exact') {matchCondition = `c.${matchColumn} = {goalValue:String}`@@ -862,8 +873,6 @@ export class ExperimentController {matchCondition = `c.${matchColumn} ILIKE concat('%', {goalValue:String}, '%')`}- // Build metadata filters condition (e.g. currency = EUR)- // ClickHouse stores metadata as Nested(key String, value String)let metaCondition = ''const metaParams: Record<string, string> = {}const metadataFilters = experiment.goal.metadataFilters@@ -921,7 +930,6 @@ export class ExperimentController {}}- // Build variant resultsconst exposuresMap = new Map(exposuresData.map(e => [e.variantKey, Number(e.exposures)]),)@@ -929,7 +937,6 @@ export class ExperimentController {conversionsData.map(c => [c.variantKey, Number(c.conversions)]),)- // Find control variantconst controlVariant = experiment.variants.find(v => v.isControl)const controlExposures = controlVariant? exposuresMap.get(controlVariant.key) || 0@@ -940,17 +947,14 @@ export class ExperimentController {const controlRate =controlExposures > 0 ? controlConversions / controlExposures : 0- // Prepare data for Bayesian calculationconst variantData = experiment.variants.map(v => ({key: v.key,exposures: exposuresMap.get(v.key) || 0,conversions: conversionsMap.get(v.key) || 0,}))- // Calculate Bayesian probabilitiesconst probabilities = calculateBayesianProbabilities(variantData)- // Build variant resultsconst variantResults: VariantResultDto[] = experiment.variants.map(v => {const exposures = exposuresMap.get(v.key) || 0const conversions = conversionsMap.get(v.key) || 0@@ -978,7 +982,6 @@ export class ExperimentController {}})- // Determine if there's a winner (>95% probability)const totalExposures = _sum(variantResults.map(v => v.exposures))const totalConversions = _sum(variantResults.map(v => v.conversions))const highestProbVariant = variantResults.reduce((a, b) =>@@ -986,7 +989,6 @@ export class ExperimentController {)const hasWinner = highestProbVariant.probabilityOfBeingBest >= 95- // Generate chart data with win probability over timelet chart:| { x: string[]; winProbability: Record<string, number[]> }| undefined@@ -1031,7 +1033,6 @@ export class ExperimentController {groupToUTC: string,safeTimezone: string,): Promise<{ x: string[]; winProbability: Record<string, number[]> }> {- // Generate X axis based on time bucketconst { xShifted } = this.analyticsService.generateXAxis(timeBucket as any,groupFrom,@@ -1051,7 +1052,6 @@ export class ExperimentController {'firstCreated',)- // Query exposures grouped by time bucket and variant (first exposure per profile)const exposuresQuery = `SELECT${exposuresDateColumnsSelect},@@ -1091,7 +1091,6 @@ export class ExperimentController {this.logger.warn({ err }, 'Failed to get time-bucketed exposures')}- // Query conversions grouped by time bucket and variant (if goal exists)let conversionsData: any[] = []if (experiment.goal) {const goalType = experiment.goal.type@@ -1103,7 +1102,6 @@ export class ExperimentController {'firstConversion',)- // Build match condition based on goal match typelet matchCondition = ''if (experiment.goal.matchType === 'exact') {matchCondition = `c.${matchColumn} = {goalValue:String}`@@ -1111,7 +1109,6 @@ export class ExperimentController {matchCondition = `c.${matchColumn} ILIKE concat('%', {goalValue:String}, '%')`}- // Build metadata filters conditionlet metaCondition = ''const metaParams: Record<string, string> = {}const metadataFilters = experiment.goal.metadataFilters@@ -1169,16 +1166,13 @@ export class ExperimentController {}}- // Build cumulative data per variant per time bucketconst variantKeys = experiment.variants.map(v => v.key)const winProbability: Record<string, number[]> = {}- // Initialize arrays for each variantfor (const key of variantKeys) {winProbability[key] = Array(xShifted.length).fill(0)}- // Track cumulative exposures and conversions per variantconst cumulativeExposures: Record<string, number> = {}const cumulativeConversions: Record<string, number> = {}@@ -1187,7 +1181,6 @@ export class ExperimentController {cumulativeConversions[key] = 0}- // Index bucket deltas for O(buckets * variants) processingconst exposuresByBucket: Record<string, Record<string, number>> = {}for (const row of exposuresData) {const rowDate = this.generateDateStringFromRow(row, timeBucket)@@ -1206,11 +1199,9 @@ export class ExperimentController {conversionsByBucket[rowDate][key] = Number(row.conversions) || 0}- // Process each time bucketfor (let i = 0; i < xShifted.length; i++) {const bucketDate = xShifted[i]- // Add exposures for this bucketconst exposuresDelta = exposuresByBucket[bucketDate]if (exposuresDelta) {for (const [key, value] of Object.entries(exposuresDelta)) {@@ -1220,7 +1211,6 @@ export class ExperimentController {}}- // Add conversions for this bucketconst conversionsDelta = conversionsByBucket[bucketDate]if (conversionsDelta) {for (const [key, value] of Object.entries(conversionsDelta)) {@@ -1230,7 +1220,6 @@ export class ExperimentController {}}- // Calculate Bayesian probabilities for this point in timeconst variantData = variantKeys.map(key => ({key,exposures: cumulativeExposures[key],@@ -1239,7 +1228,6 @@ export class ExperimentController {const probabilities = calculateBayesianProbabilities(variantData)- // Store probabilities for each variantfor (const key of variantKeys) {winProbability[key][i] = _round((probabilities.get(key) || 0) * 100, 2)}diff --git a/backend/apps/cloud/src/feature-flag/evaluation.ts b/backend/apps/cloud/src/feature-flag/evaluation.tsindex 392288669..6665c1dba 100644--- a/backend/apps/cloud/src/feature-flag/evaluation.ts+++ b/backend/apps/cloud/src/feature-flag/evaluation.ts@@ -54,12 +54,10 @@ export function evaluateFlag(profileId: string,attributes?: Record<string, string>,): boolean {- // If flag is disabled, always return falseif (!flag.enabled) {return false}- // Check targeting rules if any existif (flag.targetingRules && flag.targetingRules.length > 0) {const matchesTargeting = matchesTargetingRules(flag.targetingRules,@@ -70,12 +68,10 @@ export function evaluateFlag(}}- // For boolean flags, return true if enabled and targeting matchesif (flag.flagType === FeatureFlagType.BOOLEAN) {return true}- // For rollout flags, use percentage-based rolloutif (flag.flagType === FeatureFlagType.ROLLOUT) {return isInRolloutPercentage(flag.key, flag.rolloutPercentage, profileId)}@@ -92,31 +88,23 @@ function matchesTargetingRules(attributes?: Record<string, string>,): boolean {if (!attributes) {- // If no attributes provided, we can't match any rules- // Return true to be permissive (flag will be shown)return true}for (const rule of rules) {const attributeValue = attributes[rule.column]- // Check if we have the attributeif (attributeValue === undefined) {- // If attribute not provided, skip this rule (be permissive)continue}const matches = matchesRule(attributeValue, rule.filter)- // If isExclusive (exclude), we want the rule to NOT match- // If not isExclusive (include), we want the rule to matchif (rule.isExclusive) {- // Exclude: if it matches, targeting failsif (matches) {return false}} else {- // Include: if it doesn't match, targeting failsif (!matches) {return false}@@ -131,7 +119,6 @@ function matchesTargetingRules(* Supports case-insensitive matching*/function matchesRule(attributeValue: string, filterValue: string): boolean {- // Case-insensitive exact matchreturn attributeValue.toLowerCase() === filterValue.toLowerCase()}@@ -151,17 +138,13 @@ function isInRolloutPercentage(return false}- // Create a consistent hash based on flag key and profile ID- // Using SHA-256 for better cryptographic propertiesconst hash = crypto.createHash('sha256').update(`${flagKey}:${profileId}`).digest('hex')- // Convert first 8 hex characters to a number (0 to 2^32-1)const hashValue = parseInt(hash.substring(0, 8), 16)- // Normalize to 0-100 rangeconst normalizedValue = (hashValue / 0xffffffff) * 100return normalizedValue < percentage@@ -193,19 +176,15 @@ export function getExperimentVariant(return null}- // Create a consistent hash based on experiment ID and profile IDconst hash = crypto.createHash('sha256').update(`experiment:${experimentId}:${profileId}`).digest('hex')- // Convert first 8 hex characters to a number (0 to 2^32-1)const hashValue = parseInt(hash.substring(0, 8), 16)- // Normalize to 0-100 rangeconst normalizedValue = (hashValue / 0xffffffff) * 100- // Assign to variant based on cumulative percentageslet cumulativePercentage = 0for (const variant of variants) {cumulativePercentage += variant.rolloutPercentage@@ -214,6 +193,5 @@ export function getExperimentVariant(}}- // Fallback to last variant (shouldn't happen if percentages sum to 100)return variants[variants.length - 1].key}