Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Better validation

Blue Mouse3335e71589cd
diff --git a/backend/apps/cloud/src/revenue/dto/log-revenue.dto.ts b/backend/apps/cloud/src/revenue/dto/log-revenue.dto.ts
index 8bcb21639..5d9c33b8d 100644
--- a/backend/apps/cloud/src/revenue/dto/log-revenue.dto.ts
+++ b/backend/apps/cloud/src/revenue/dto/log-revenue.dto.ts
@@ -77,6 +77,9 @@ export class LogRevenueDto {
@Transform(({ value }) =>
typeof value === 'string' ? value.toUpperCase() : value,
)
+ @Matches(/^[A-Z]{3}$/, {
+ message: 'currency must be a 3-letter ISO 4217 code',
+ })
currency: string
@ApiPropertyOptional({
diff --git a/backend/apps/cloud/src/revenue/revenue.controller.ts b/backend/apps/cloud/src/revenue/revenue.controller.ts
index b22d14a19..fb1951007 100644
--- a/backend/apps/cloud/src/revenue/revenue.controller.ts
+++ b/backend/apps/cloud/src/revenue/revenue.controller.ts
@@ -473,8 +473,9 @@ export class RevenueAnalyticsController {
})
}
- const targetCurrency =
- project.revenueCurrency || (isFirstCall ? dto.currency : 'USD')
+ const targetCurrency = isFirstCall
+ ? dto.currency
+ : project.revenueCurrency || 'USD'
const originalCurrency = dto.currency.toUpperCase()
const originalAmount = dto.amount