Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

fix: Don't expose CAPTCHA secret key on public projects

Blue Mouse489b61375484
diff --git a/backend/apps/cloud/src/project/project.controller.ts b/backend/apps/cloud/src/project/project.controller.ts
index f21112366..9a0d18b60 100644
--- a/backend/apps/cloud/src/project/project.controller.ts
+++ b/backend/apps/cloud/src/project/project.controller.ts
@@ -1882,6 +1882,9 @@ export class ProjectController {
}
}
+ const isManagerRole = role === 'owner' || role === 'admin'
+ const isViewerRole = role === 'viewer'
+
return {
..._omit(project, [
'admin',
@@ -1892,7 +1895,8 @@ export class ProjectController {
'gscTokenExpiry',
'gscScope',
'gscAccountEmail',
- role !== 'owner' && role !== 'admin' && 'share',
+ !isManagerRole && !isViewerRole && 'share',
+ !isManagerRole && 'captchaSecretKey',
]),
isAccessConfirmed,
isLocked: !!project.admin?.dashboardBlockReason,
diff --git a/backend/apps/cloud/src/project/project.service.ts b/backend/apps/cloud/src/project/project.service.ts
index b81f953da..726596ed0 100644
--- a/backend/apps/cloud/src/project/project.service.ts
+++ b/backend/apps/cloud/src/project/project.service.ts
@@ -1545,6 +1545,7 @@ export class ProjectService {
role,
passwordHash: undefined,
admin: undefined,
+ captchaSecretKey: undefined,
}
})
diff --git a/backend/apps/community/src/project/project.controller.ts b/backend/apps/community/src/project/project.controller.ts
index 5ddca3a6e..447fc2b09 100644
--- a/backend/apps/community/src/project/project.controller.ts
+++ b/backend/apps/community/src/project/project.controller.ts
@@ -302,7 +302,7 @@ export class ProjectController {
: undefined
return {
- ..._omit(project, ['passwordHash']),
+ ..._omit(project, ['passwordHash', 'captchaSecretKey']),
share: projectShare,
funnels: funnelsMap[project.id],
isDataExists: _includes(pidsWithData, project?.id),
@@ -1210,12 +1210,15 @@ export class ProjectController {
? Boolean(userShare.confirmed)
: true
+ const isManagerRole = role === 'owner' || role === 'admin'
+
return this.projectService.formatFromClickhouse({
..._omit(project, [
'passwordHash',
- role !== 'owner' && role !== 'admin' && 'share',
+ !isManagerRole && 'share',
+ !isManagerRole && 'captchaSecretKey',
]),
- share: role === 'owner' || role === 'admin' ? share : undefined,
+ share: isManagerRole ? share : undefined,
funnels: this.projectService.formatFunnelsFromClickhouse(funnels),
isDataExists,
isErrorDataExists,