📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!
TypeScript chartsclickhousedockergdprgoogle-analyticsmetricsmonitoringmysqlnestjsprivacyredisself-hostedselfhostedstatisticstailwindcssweb-analyticswebanalyticswebsite
fix: Restrict endpoint to the data-import namespace
Blue Mouse49ffbdfdcdaf
diff --git a/web/app/routes/api.data-import.ts b/web/app/routes/api.data-import.tsindex 0bac4d4bc..ee495b826 100644--- a/web/app/routes/api.data-import.ts+++ b/web/app/routes/api.data-import.ts@@ -7,14 +7,39 @@ import {import { serverFetch } from '~/api/api.server'import { createHeadersWithCookies } from '~/utils/session.server'+function validateEndpoint(raw: string | null): string | null {+ if (!raw) return null++ const trimmed = raw.replace(/^\/+/, '')++ if (+ trimmed !== 'data-import' &&+ !trimmed.startsWith('data-import/')+ ) {+ return null+ }++ if (trimmed.includes('..')) return null++ if (/^[a-z]+:\/\//i.test(trimmed)) return null++ return trimmed+}+export async function loader({ request }: LoaderFunctionArgs) {const url = new URL(request.url)- const endpoint = url.searchParams.get('endpoint')+ const raw = url.searchParams.get('endpoint')- if (!endpoint) {+ if (!raw) {return data({ error: 'endpoint param is required' }, { status: 400 })}+ const endpoint = validateEndpoint(raw)++ if (!endpoint) {+ return data({ error: 'Invalid endpoint' }, { status: 400 })+ }+const result = await serverFetch(request, endpoint)if (result.error) {@@ -31,12 +56,18 @@ export async function loader({ request }: LoaderFunctionArgs) {export async function action({ request }: ActionFunctionArgs) {const url = new URL(request.url)- const endpoint = url.searchParams.get('endpoint')+ const raw = url.searchParams.get('endpoint')- if (!endpoint) {+ if (!raw) {return data({ error: 'endpoint param is required' }, { status: 400 })}+ const endpoint = validateEndpoint(raw)++ if (!endpoint) {+ return data({ error: 'Invalid endpoint' }, { status: 400 })+ }+if (request.method === 'DELETE') {const result = await serverFetch(request, endpoint, { method: 'DELETE' })