Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

move the isPerformance check outside of loop to slightly improve efficiency

Blue Mouse56a7bbc8469b
diff --git a/apps/production/src/analytics/analytics.service.ts b/apps/production/src/analytics/analytics.service.ts
index 34cac9b64..c1a0214f2 100644
--- a/apps/production/src/analytics/analytics.service.ts
+++ b/apps/production/src/analytics/analytics.service.ts
@@ -779,18 +779,21 @@ export class AnalyticsService {
params[col] = {}
const size = _size(res)
- for (let j = 0; j < size; ++j) {
- const key = res[j][col]
- if (isPerformance) {
+ if (isPerformance) {
+ for (let j = 0; j < size; ++j) {
+ const key = res[j][col]
params[col][key] = _round(
millisecondsToSeconds(res[j]['avg(pageLoad)']),
2,
)
- continue
}
-
- params[col][key] = res[j]['count()']
+ } else {
+ for (let j = 0; j < size; ++j) {
+ console.log(`iteration #${j} for ${col}`)
+ const key = res[j][col]
+ params[col][key] = res[j]['count()']
+ }
}
})
diff --git a/apps/selfhosted/src/analytics/analytics.service.ts b/apps/selfhosted/src/analytics/analytics.service.ts
index fcca8efea..09dd091b3 100644
--- a/apps/selfhosted/src/analytics/analytics.service.ts
+++ b/apps/selfhosted/src/analytics/analytics.service.ts
@@ -758,18 +758,21 @@ export class AnalyticsService {
params[col] = {}
const size = _size(res)
- for (let j = 0; j < size; ++j) {
- const key = res[j][col]
- if (isPerformance) {
+ if (isPerformance) {
+ for (let j = 0; j < size; ++j) {
+ const key = res[j][col]
params[col][key] = _round(
millisecondsToSeconds(res[j]['avg(pageLoad)']),
2,
)
- continue
}
-
- params[col][key] = res[j]['count()']
+ } else {
+ for (let j = 0; j < size; ++j) {
+ console.log(`iteration #${j} for ${col}`)
+ const key = res[j][col]
+ params[col][key] = res[j]['count()']
+ }
}
})