Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

fix: 500 error when requesting errors with unsuppored filters

Blue Mouse61fa345e89b7
diff --git a/backend/apps/cloud/src/analytics/analytics.controller.ts b/backend/apps/cloud/src/analytics/analytics.controller.ts
index 60637d313..55b9114e3 100644
--- a/backend/apps/cloud/src/analytics/analytics.controller.ts
+++ b/backend/apps/cloud/src/analytics/analytics.controller.ts
@@ -1600,7 +1600,7 @@ export class AnalyticsController {
}
const [filtersQuery, filtersParams, appliedFilters] =
- this.analyticsService.getFiltersQuery(filters, DataType.ANALYTICS)
+ this.analyticsService.getFiltersQuery(filters, DataType.ERRORS, true)
const safeTimezone = this.analyticsService.getSafeTimezone(timezone)
const { groupFromUTC, groupToUTC } = this.analyticsService.getGroupFromTo(
diff --git a/backend/apps/cloud/src/analytics/analytics.service.ts b/backend/apps/cloud/src/analytics/analytics.service.ts
index be95b72de..28d47fe39 100644
--- a/backend/apps/cloud/src/analytics/analytics.service.ts
+++ b/backend/apps/cloud/src/analytics/analytics.service.ts
@@ -308,6 +308,7 @@ export enum DataType {
ANALYTICS = 'analytics',
PERFORMANCE = 'performance',
CAPTCHA = 'captcha',
+ ERRORS = 'errors',
}
const isValidOrigin = (origins: string[], origin: string) => {
@@ -506,6 +507,10 @@ export class AnalyticsService {
return PERFORMANCE_COLUMNS
}
+ if (dataType === DataType.ERRORS) {
+ return ERROR_COLUMNS
+ }
+
return CAPTCHA_COLUMNS
}
@@ -954,9 +959,7 @@ export class AnalyticsService {
!_includes(TRAFFIC_METAKEY_COLUMNS, column) &&
!_startsWith(column, 'tag:key:')
) {
- throw new UnprocessableEntityException(
- `The provided filter (${column}) is not supported`,
- )
+ return prev
}
const res = []
diff --git a/backend/apps/cloud/src/common/constants.ts b/backend/apps/cloud/src/common/constants.ts
index e9272c122..de6a23d7e 100644
--- a/backend/apps/cloud/src/common/constants.ts
+++ b/backend/apps/cloud/src/common/constants.ts
@@ -116,6 +116,9 @@ const TRAFFIC_COLUMNS = [
const TRAFFIC_METAKEY_COLUMNS = ['tag:key', 'tag:value']
+const ALL_COLUMNS = [...TRAFFIC_COLUMNS, 'ev']
+const CAPTCHA_COLUMNS = ['cc', 'br', 'os', 'dv']
+const PERFORMANCE_COLUMNS = ['cc', 'rg', 'ct', 'host', 'pg', 'dv', 'br', 'brv']
const ERROR_COLUMNS = [
'host',
'pg',
@@ -130,11 +133,6 @@ const ERROR_COLUMNS = [
'ct',
]
-const ALL_COLUMNS = [...TRAFFIC_COLUMNS, 'ev']
-
-const CAPTCHA_COLUMNS = ['cc', 'br', 'os', 'dv']
-const PERFORMANCE_COLUMNS = ['cc', 'rg', 'ct', 'host', 'pg', 'dv', 'br', 'brv']
-
const sentryIgnoreErrors: (string | RegExp)[] = [
'BadRequestException',
'UnauthorizedException',
diff --git a/backend/apps/community/src/analytics/analytics.controller.ts b/backend/apps/community/src/analytics/analytics.controller.ts
index b0d1b639d..b1b99fd14 100644
--- a/backend/apps/community/src/analytics/analytics.controller.ts
+++ b/backend/apps/community/src/analytics/analytics.controller.ts
@@ -1535,7 +1535,7 @@ export class AnalyticsController {
}
const [filtersQuery, filtersParams, appliedFilters] =
- this.analyticsService.getFiltersQuery(filters, DataType.ANALYTICS)
+ this.analyticsService.getFiltersQuery(filters, DataType.ERRORS, true)
const safeTimezone = this.analyticsService.getSafeTimezone(timezone)
const { groupFromUTC, groupToUTC } = this.analyticsService.getGroupFromTo(
diff --git a/backend/apps/community/src/analytics/analytics.service.ts b/backend/apps/community/src/analytics/analytics.service.ts
index 3519ee037..9fe1d2493 100644
--- a/backend/apps/community/src/analytics/analytics.service.ts
+++ b/backend/apps/community/src/analytics/analytics.service.ts
@@ -295,6 +295,7 @@ const generateParamsQuery = (
export enum DataType {
ANALYTICS = 'analytics',
PERFORMANCE = 'performance',
+ ERRORS = 'errors',
}
const isValidOrigin = (origins: string[], origin: string) => {
@@ -485,6 +486,10 @@ export class AnalyticsService {
return TRAFFIC_COLUMNS
}
+ if (dataType === DataType.ERRORS) {
+ return ERROR_COLUMNS
+ }
+
return PERFORMANCE_COLUMNS
}
@@ -935,9 +940,7 @@ export class AnalyticsService {
!_includes(TRAFFIC_METAKEY_COLUMNS, column) &&
!_startsWith(column, 'tag:key:')
) {
- throw new UnprocessableEntityException(
- `The provided filter (${column}) is not supported`,
- )
+ return prev
}
const res = []