Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Native 'Go back' support for errors

Blue Mouse692b13386381
diff --git a/web/app/pages/Project/View/ViewProject.tsx b/web/app/pages/Project/View/ViewProject.tsx
index 13587c5e6..abd1b35cc 100644
--- a/web/app/pages/Project/View/ViewProject.tsx
+++ b/web/app/pages/Project/View/ViewProject.tsx
@@ -392,7 +392,9 @@ const ViewProject = () => {
const [activeError, setActiveError] = useState<any>(null)
const [errorLoading, setErrorLoading] = useState(false)
const [errorStatusUpdating, setErrorStatusUpdating] = useState(false)
- const [activeEID, setActiveEID] = useState<string | null>(null)
+ const activeEID = useMemo(() => {
+ return searchParams.get('eid')
+ }, [searchParams])
const [activeFunnel, setActiveFunnel] = useState<Funnel | null>(null)
const [funnelToEdit, setFunnelToEdit] = useState<Funnel | undefined>(undefined)
@@ -1414,22 +1416,6 @@ const ViewProject = () => {
setSessionLoading(false)
}
- useEffect(() => {
- if (authLoading) {
- return
- }
-
- const tab = searchParams.get('tab') as string
-
- if (tab === PROJECT_TABS.errors) {
- const eid = searchParams.get('eid') as string
-
- if (eid) {
- setActiveEID(eid)
- }
- }
- }, [authLoading])
-
useEffect(() => {
if (!activePSID) {
return
@@ -3645,13 +3631,7 @@ const ViewProject = () => {
resetActiveTabFilters={resetActiveTabFilters}
/>
) : null}
- <Errors
- errors={errors}
- onClick={(eidToLoad) => {
- setActiveEID(eidToLoad)
- setErrorLoading(true)
- }}
- />
+ <Errors errors={errors} />
{canLoadMoreErrors ? (
<button
type='button'
@@ -3677,9 +3657,9 @@ const ViewProject = () => {
type='button'
onClick={() => {
setActiveError(null)
- setActiveEID(null)
- searchParams.delete('eid')
- setSearchParams(searchParams)
+ const newSearchParams = new URLSearchParams(searchParams.toString())
+ newSearchParams.delete('eid')
+ setSearchParams(newSearchParams)
}}
className='mx-auto mt-2 mb-4 flex items-center font-mono text-sm text-gray-900 underline decoration-dashed hover:decoration-solid lg:mx-0 lg:mt-0 dark:text-gray-100'
>
diff --git a/web/app/pages/Project/View/components/Errors.tsx b/web/app/pages/Project/View/components/Errors.tsx
index 4bb9aba68..7bbe83b10 100644
--- a/web/app/pages/Project/View/components/Errors.tsx
+++ b/web/app/pages/Project/View/components/Errors.tsx
@@ -14,12 +14,10 @@ import { SwetrixError } from '../interfaces/error'
interface ErrorsProps {
errors: SwetrixError[]
- onClick: (psid: string) => void
}
interface ErrorItemProps {
error: SwetrixError
- onClick: (psid: string) => void
}
interface SeparatorProps {
@@ -32,7 +30,7 @@ const Separator = ({ className }: SeparatorProps) => (
</svg>
)
-const ErrorItem = ({ error, onClick }: ErrorItemProps) => {
+const ErrorItem = ({ error }: ErrorItemProps) => {
const {
t,
i18n: { language },
@@ -69,16 +67,7 @@ const ErrorItem = ({ error, onClick }: ErrorItemProps) => {
const stringifiedUrl = eidUrl.toString()
return (
- <Link
- onClick={(e: React.MouseEvent<HTMLAnchorElement>) => {
- e.preventDefault()
- e.stopPropagation()
- window.history.pushState({}, '', stringifiedUrl)
-
- onClick(error.eid)
- }}
- to={stringifiedUrl}
- >
+ <Link to={stringifiedUrl}>
<li className='relative mb-4 flex cursor-pointer justify-between gap-x-6 rounded-lg bg-gray-200/60 px-4 py-4 font-mono hover:bg-gray-200 sm:px-6 dark:bg-[#162032] dark:hover:bg-slate-800'>
<div className='flex min-w-0 gap-x-4'>
<div className='min-w-0 flex-auto'>
@@ -122,7 +111,7 @@ const ErrorItem = ({ error, onClick }: ErrorItemProps) => {
)
}
-export const Errors = ({ errors, onClick }: ErrorsProps) => {
+export const Errors = ({ errors }: ErrorsProps) => {
return (
<ClientOnly
fallback={
@@ -134,7 +123,7 @@ export const Errors = ({ errors, onClick }: ErrorsProps) => {
{() => (
<ul className='mt-4'>
{_map(errors, (error) => (
- <ErrorItem key={error.eid} error={error} onClick={onClick} />
+ <ErrorItem key={error.eid} error={error} />
))}
</ul>
)}