Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

fix: race condition -> feature flags page always redirects to the main page

Blue Mouse71054ae1e47d
diff --git a/web/app/routes/feature-flags.tsx b/web/app/routes/feature-flags.tsx
index a0b579a4c..5849cea0a 100644
--- a/web/app/routes/feature-flags.tsx
+++ b/web/app/routes/feature-flags.tsx
@@ -2,7 +2,6 @@ import { Switch } from '@headlessui/react'
import cx from 'clsx'
import { useEffect, useState } from 'react'
import { useTranslation } from 'react-i18next'
-import { useNavigate } from 'react-router'
import { toast } from 'sonner'
import { setFeatureFlags } from '~/api'
@@ -10,28 +9,21 @@ import { withAuthentication, auth } from '~/hoc/protected'
import { FeatureFlag } from '~/lib/models/User'
import { useAuth } from '~/providers/AuthProvider'
import Loader from '~/ui/Loader'
-import routes from '~/utils/routes'
const FeatureFlagsPage = () => {
const { t } = useTranslation('common')
const { user, isLoading, mergeUser } = useAuth()
const [flags, setFlags] = useState<FeatureFlag[]>([])
const [initialised, setInitialised] = useState(false)
- const navigate = useNavigate()
useEffect(() => {
- if (isLoading || initialised) {
+ if (isLoading || initialised || !user) {
return
}
- if (user) {
- setFlags(user.featureFlags ?? [])
- setInitialised(true)
- return
- }
-
- navigate(routes.main)
- }, [isLoading, user, navigate, initialised])
+ setFlags(user.featureFlags ?? [])
+ setInitialised(true)
+ }, [isLoading, user, initialised])
const handleToggle = async (flag: FeatureFlag) => {
try {