Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

added validation of extension creation

Yevhenii Kulisidi94d44e785231
diff --git a/src/marketplace/extensions/dtos/create-extension.dto.ts b/src/marketplace/extensions/dtos/create-extension.dto.ts
index e0770816d..ea67f80cb 100644
--- a/src/marketplace/extensions/dtos/create-extension.dto.ts
+++ b/src/marketplace/extensions/dtos/create-extension.dto.ts
@@ -1,6 +1,23 @@
-// TODO: Add validation
+import {
+ IsNotEmpty,
+ IsNumberString,
+ IsOptional,
+ IsString,
+ Length,
+} from 'class-validator'
+
export class CreateExtensionBodyDto {
+ @IsNotEmpty()
+ @IsString()
+ @Length(1, 255)
readonly name: string
+
+ @IsOptional()
+ @IsString()
+ @Length(1, 1024)
readonly description?: string
- readonly price?: number
+
+ @IsOptional()
+ @IsNumberString()
+ readonly price?: string
}
diff --git a/src/marketplace/extensions/extensions.controller.ts b/src/marketplace/extensions/extensions.controller.ts
index 7f850258f..d6246ffc6 100644
--- a/src/marketplace/extensions/extensions.controller.ts
+++ b/src/marketplace/extensions/extensions.controller.ts
@@ -450,7 +450,7 @@ export class ExtensionsController {
)
files: CreateExtensionFilesType,
@CurrentUserId() userId: string,
- ): Promise<unknown> {
+ ): Promise<Extension> {
return await this.extensionsService.createExtension({
ownerId: userId,
...body,
diff --git a/src/marketplace/extensions/extensions.service.ts b/src/marketplace/extensions/extensions.service.ts
index af034de58..708d31117 100644
--- a/src/marketplace/extensions/extensions.service.ts
+++ b/src/marketplace/extensions/extensions.service.ts
@@ -177,7 +177,7 @@ export class ExtensionsService {
status: extension.files.extensionScript
? ExtensionStatus.PENDING
: ExtensionStatus.NO_EXTENSION_UPLOADED,
- price: extension.price,
+ price: extension.price && Number(extension.price),
mainImage:
extension.files.mainImage &&
(
diff --git a/src/marketplace/extensions/types/create-extension.type.ts b/src/marketplace/extensions/types/create-extension.type.ts
index 853c62319..26ee50a52 100644
--- a/src/marketplace/extensions/types/create-extension.type.ts
+++ b/src/marketplace/extensions/types/create-extension.type.ts
@@ -8,6 +8,6 @@ export type CreateExtensionType = {
ownerId: string
name: string
description?: string
- price?: number
+ price?: string
files: CreateExtensionFilesType
}