Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

some prop-types related improvements

Blue Mouse9cf9fe734d60
diff --git a/src/pages/Project/Settings/People/People.jsx b/src/pages/Project/Settings/People/People.jsx
index 65661b0bb..b434f41d8 100644
--- a/src/pages/Project/Settings/People/People.jsx
+++ b/src/pages/Project/Settings/People/People.jsx
@@ -145,21 +145,14 @@ const UsersList = ({
}
UsersList.propTypes = {
- // eslint-disable-next-line react/forbid-prop-types
- share: PropTypes.arrayOf(PropTypes.object).isRequired,
- // eslint-disable-next-line react/forbid-prop-types
- data: PropTypes.object.isRequired,
+ share: PropTypes.arrayOf(PropTypes.object).isRequired, // eslint-disable-line react/forbid-prop-types
+ data: PropTypes.object.isRequired, // eslint-disable-line react/forbid-prop-types
pid: PropTypes.string.isRequired,
- onRemove: PropTypes.func,
- updateProjectFailed: PropTypes.func,
+ onRemove: PropTypes.func.isRequired,
+ updateProjectFailed: PropTypes.func.isRequired,
language: PropTypes.string.isRequired,
}
-UsersList.defaultProps = {
- onRemove: () => { },
- updateProjectFailed: (e) => console.log(e),
-}
-
const People = ({
project, updateProjectFailed, setProjectShareData,
}) => {
@@ -279,7 +272,6 @@ const People = ({
) : (
<div className='mt-3 flex flex-col'>
<div className='-my-2 -mx-4 overflow-x-auto md:overflow-x-visible sm:-mx-6 lg:-mx-8'>
- {/* md:overflow-scroll */}
<div className='inline-block min-w-full py-2 md:px-6 lg:px-8'>
<div className='shadow ring-1 ring-black ring-opacity-5 md:rounded-lg'>
<table className='min-w-full divide-y divide-gray-300 dark:divide-gray-600'>
diff --git a/src/pages/UserSettings/UserSettings.jsx b/src/pages/UserSettings/UserSettings.jsx
index 8109cfc89..d89261e57 100644
--- a/src/pages/UserSettings/UserSettings.jsx
+++ b/src/pages/UserSettings/UserSettings.jsx
@@ -101,18 +101,13 @@ const ProjectList = ({
}
ProjectList.propTypes = {
- // eslint-disable-next-line react/forbid-prop-types
- item: PropTypes.object.isRequired,
+ item: PropTypes.object.isRequired, // eslint-disable-line react/forbid-prop-types
t: PropTypes.func.isRequired,
- deleteProjectFailed: PropTypes.func,
+ deleteProjectFailed: PropTypes.func.isRequired,
removeProject: PropTypes.func.isRequired,
removeShareProject: PropTypes.func.isRequired,
}
-ProjectList.defaultProps = {
- deleteProjectFailed: (e) => console.log(e),
-}
-
const NoSharedProjects = ({ t }) => (
<div className='flex flex-col py-6 sm:px-6 lg:px-8'>
<div className='max-w-7xl w-full mx-auto text-gray-900 dark:text-gray-50'>
@@ -422,7 +417,7 @@ UserSettings.propTypes = {
onEmailConfirm: PropTypes.func.isRequired,
onExport: PropTypes.func.isRequired,
onDelete: PropTypes.func.isRequired,
- deleteProjectFailed: PropTypes.func,
+ deleteProjectFailed: PropTypes.func.isRequired,
t: PropTypes.func.isRequired,
onDeleteProjectCache: PropTypes.func.isRequired,
removeProject: PropTypes.func.isRequired,
@@ -432,8 +427,4 @@ UserSettings.propTypes = {
language: PropTypes.string.isRequired,
}
-UserSettings.defaultProps = {
- deleteProjectFailed: (e) => console.log(e),
-}
-
export default memo(UserSettings)