📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!
TypeScript chartsclickhousedockergdprgoogle-analyticsmetricsmonitoringmysqlnestjsprivacyredisself-hostedselfhostedstatisticstailwindcssweb-analyticswebanalyticswebsite
fix: Uncontrolled data used in path expression
Blue Mouseb20fff192f8d
diff --git a/backend/apps/cloud/src/data-import/data-import.controller.ts b/backend/apps/cloud/src/data-import/data-import.controller.tsindex ab021b21a..74e353cb7 100644--- a/backend/apps/cloud/src/data-import/data-import.controller.ts+++ b/backend/apps/cloud/src/data-import/data-import.controller.ts@@ -33,6 +33,7 @@ import { getMapper, SUPPORTED_PROVIDERS } from './mappers'import { DataImportJobData, DATA_IMPORT_QUEUE } from './data-import.processor'const MAX_FILE_SIZE = 100 * 1024 * 1024 // 100 MB+const IMPORT_TMP_DIR = path.resolve(os.tmpdir(), 'swetrix-imports')@ApiTags('Data Import')@UseGuards(AuthenticationGuard)@@ -65,9 +66,8 @@ export class DataImportController {limits: { fileSize: MAX_FILE_SIZE },storage: diskStorage({destination: (_req, _file, cb) => {- const dir = path.join(os.tmpdir(), 'swetrix-imports')- fs.mkdirSync(dir, { recursive: true })- cb(null, dir)+ fs.mkdirSync(IMPORT_TMP_DIR, { recursive: true })+ cb(null, IMPORT_TMP_DIR)},filename: (_req, file, cb) => {const ext = path.extname(file.originalname).toLowerCase()@@ -207,8 +207,22 @@ export class DataImportController {private cleanupFile(filePath: string): void {try {- if (fs.existsSync(filePath)) {- fs.unlinkSync(filePath)+ const resolvedPath = path.resolve(filePath)+ const relativePath = path.relative(IMPORT_TMP_DIR, resolvedPath)+ const isImportTempFile =+ relativePath !== '' &&+ !relativePath.startsWith('..') &&+ !path.isAbsolute(relativePath)++ if (!isImportTempFile) {+ this.logger.warn(+ `Skipped cleanup outside import temp dir: ${resolvedPath}`,+ )+ return+ }++ if (fs.existsSync(resolvedPath) && fs.lstatSync(resolvedPath).isFile()) {+ fs.unlinkSync(resolvedPath)}} catch {//diff --git a/backend/apps/cloud/src/data-import/data-import.processor.ts b/backend/apps/cloud/src/data-import/data-import.processor.tsindex 488b060b1..14eba24a1 100644--- a/backend/apps/cloud/src/data-import/data-import.processor.ts+++ b/backend/apps/cloud/src/data-import/data-import.processor.ts@@ -1,4 +1,6 @@import * as fs from 'fs'+import * as os from 'os'+import * as path from 'path'import { Processor, WorkerHost } from '@nestjs/bullmq'import { Logger } from '@nestjs/common'import { Job } from 'bullmq'@@ -10,6 +12,7 @@ import { clickhouse } from '../common/integrations/clickhouse'const CLICKHOUSE_DB = process.env.CLICKHOUSE_DATABASE || 'analytics'const BATCH_SIZE = 5000+const IMPORT_TMP_DIR = path.resolve(os.tmpdir(), 'swetrix-imports')export const DATA_IMPORT_QUEUE = 'data-import'@@ -152,8 +155,22 @@ export class DataImportProcessor extends WorkerHost {private cleanupFile(filePath: string): void {try {- if (fs.existsSync(filePath)) {- fs.unlinkSync(filePath)+ const resolvedPath = path.resolve(filePath)+ const relativePath = path.relative(IMPORT_TMP_DIR, resolvedPath)+ const isImportTempFile =+ relativePath !== '' &&+ !relativePath.startsWith('..') &&+ !path.isAbsolute(relativePath)++ if (!isImportTempFile) {+ this.logger.warn(+ `Skipped cleanup outside import temp dir: ${resolvedPath}`,+ )+ return+ }++ if (fs.existsSync(resolvedPath) && fs.lstatSync(resolvedPath).isFile()) {+ fs.unlinkSync(resolvedPath)}} catch {this.logger.warn(`Failed to clean up temp file: ${filePath}`)diff --git a/backend/apps/community/src/data-import/data-import.controller.ts b/backend/apps/community/src/data-import/data-import.controller.tsindex 213bf5aa0..009634af3 100644--- a/backend/apps/community/src/data-import/data-import.controller.ts+++ b/backend/apps/community/src/data-import/data-import.controller.ts@@ -31,6 +31,7 @@ import { getMapper, SUPPORTED_PROVIDERS } from './mappers'import { DataImportJobData, DATA_IMPORT_QUEUE } from './data-import.processor'const MAX_FILE_SIZE = 100 * 1024 * 1024 // 100 MB+const IMPORT_TMP_DIR = path.resolve(os.tmpdir(), 'swetrix-imports')@ApiTags('Data Import')@Controller('data-import')@@ -61,9 +62,8 @@ export class DataImportController {limits: { fileSize: MAX_FILE_SIZE },storage: diskStorage({destination: (_req, _file, cb) => {- const dir = path.join(os.tmpdir(), 'swetrix-imports')- fs.mkdirSync(dir, { recursive: true })- cb(null, dir)+ fs.mkdirSync(IMPORT_TMP_DIR, { recursive: true })+ cb(null, IMPORT_TMP_DIR)},filename: (_req, file, cb) => {const ext = path.extname(file.originalname).toLowerCase()@@ -198,8 +198,22 @@ export class DataImportController {private cleanupFile(filePath: string): void {try {- if (fs.existsSync(filePath)) {- fs.unlinkSync(filePath)+ const resolvedPath = path.resolve(filePath)+ const relativePath = path.relative(IMPORT_TMP_DIR, resolvedPath)+ const isImportTempFile =+ relativePath !== '' &&+ !relativePath.startsWith('..') &&+ !path.isAbsolute(relativePath)++ if (!isImportTempFile) {+ this.logger.warn(+ `Skipped cleanup outside import temp dir: ${resolvedPath}`,+ )+ return+ }++ if (fs.existsSync(resolvedPath) && fs.lstatSync(resolvedPath).isFile()) {+ fs.unlinkSync(resolvedPath)}} catch {//diff --git a/backend/apps/community/src/data-import/data-import.processor.ts b/backend/apps/community/src/data-import/data-import.processor.tsindex 5b8d0b0cf..50c321096 100644--- a/backend/apps/community/src/data-import/data-import.processor.ts+++ b/backend/apps/community/src/data-import/data-import.processor.ts@@ -1,4 +1,6 @@import * as fs from 'fs'+import * as os from 'os'+import * as path from 'path'import { Processor, WorkerHost } from '@nestjs/bullmq'import { Logger } from '@nestjs/common'import { Job } from 'bullmq'@@ -9,6 +11,7 @@ import { clickhouse } from '../common/integrations/clickhouse'const CLICKHOUSE_DB = process.env.CLICKHOUSE_DATABASE || 'analytics'const BATCH_SIZE = 5000+const IMPORT_TMP_DIR = path.resolve(os.tmpdir(), 'swetrix-imports')export const DATA_IMPORT_QUEUE = 'data-import'@@ -155,8 +158,22 @@ export class DataImportProcessor extends WorkerHost {private cleanupFile(filePath: string): void {try {- if (fs.existsSync(filePath)) {- fs.unlinkSync(filePath)+ const resolvedPath = path.resolve(filePath)+ const relativePath = path.relative(IMPORT_TMP_DIR, resolvedPath)+ const isImportTempFile =+ relativePath !== '' &&+ !relativePath.startsWith('..') &&+ !path.isAbsolute(relativePath)++ if (!isImportTempFile) {+ this.logger.warn(+ `Skipped cleanup outside import temp dir: ${resolvedPath}`,+ )+ return+ }++ if (fs.existsSync(resolvedPath) && fs.lstatSync(resolvedPath).isFile()) {+ fs.unlinkSync(resolvedPath)}} catch {this.logger.warn(`Failed to clean up temp file: ${filePath}`)