Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

move more stuff to ErrorsView.tsx

Blue Mouseb63a7c8d57d1
diff --git a/web/app/pages/Project/Errors/View/ErrorsView.tsx b/web/app/pages/Project/Errors/View/ErrorsView.tsx
index eeb108a4a..cfa3e3e6f 100644
--- a/web/app/pages/Project/Errors/View/ErrorsView.tsx
+++ b/web/app/pages/Project/Errors/View/ErrorsView.tsx
@@ -61,6 +61,7 @@ import { ErrorDetails } from '../../View/components/ErrorDetails'
import Filters from '../../View/components/Filters'
import NoErrorDetails from '../../View/components/NoErrorDetails'
import NoEvents from '../../View/components/NoEvents'
+import WaitingForAnError from '../../View/components/WaitingForAnError'
import { Panel, MetadataPanel } from '../../View/Panels'
import { ERROR_FILTERS_MAPPING } from '../../View/utils/filters'
@@ -368,7 +369,7 @@ const ErrorItem = ({ error }: ErrorItemProps) => {
</div>
</div>
<div className='flex shrink-0 items-center gap-x-4'>
- <div className='hidden sm:flex sm:flex-col sm:items-end'>
+ <div className='hidden gap-1 sm:flex sm:flex-col sm:items-end'>
<div className='flex items-center gap-x-3 text-sm leading-6 text-gray-900 dark:text-gray-50'>
<span className='flex items-center' title={t('dashboard.xOccurrences', { x: error.count })}>
<AlertTriangleIcon className='mr-1 size-4' strokeWidth={1.5} /> {error.count}
@@ -392,7 +393,7 @@ const ErrorItem = ({ error }: ErrorItemProps) => {
const ERRORS_TAKE = 30
const ErrorsView = () => {
- const { id, allowedToManage } = useCurrentProject()
+ const { id, allowedToManage, project } = useCurrentProject()
const projectPassword = useProjectPassword(id)
const { timeBucket, timeFormat, period, dateRange, timezone, filters, size } = useViewProjectContext()
const {
@@ -759,6 +760,11 @@ const ErrorsView = () => {
[t],
)
+ // Show waiting for error data state
+ if (typeof project?.isErrorDataExists === 'boolean' && !project.isErrorDataExists) {
+ return <WaitingForAnError />
+ }
+
// If viewing error detail
if (activeEID) {
return (
diff --git a/web/app/pages/Project/View/ViewProject.tsx b/web/app/pages/Project/View/ViewProject.tsx
index 24825f363..1c624cf49 100644
--- a/web/app/pages/Project/View/ViewProject.tsx
+++ b/web/app/pages/Project/View/ViewProject.tsx
@@ -198,7 +198,6 @@ import { TrafficChart } from './components/TrafficChart'
import { UserDetails } from './components/UserDetails'
import UserFlow from './components/UserFlow'
import { Users, UsersFilter } from './components/Users'
-import WaitingForAnError from './components/WaitingForAnError'
import WaitingForAnEvent from './components/WaitingForAnEvent'
import {
Customs,
@@ -3066,44 +3065,6 @@ const ViewProjectContent = () => {
)
}
- if (
- typeof project.isErrorDataExists === 'boolean' && // to prevent flickering
- !project.isErrorDataExists &&
- activeTab === PROJECT_TABS.errors
- ) {
- return (
- <>
- {!isEmbedded ? <Header /> : null}
- <div
- className={cx('flex bg-gray-50 dark:bg-slate-900', {
- 'min-h-including-header': !isEmbedded,
- 'min-h-[100vh]': isEmbedded,
- })}
- >
- {/* Desktop Sidebar */}
- <div className='h-including-header sticky top-0 hidden md:block'>
- <ProjectSidebar
- tabs={tabs}
- activeTab={activeTab}
- onTabChange={setDashboardTab}
- projectId={id}
- projectName={project.name}
- dataLoading={dataLoading}
- searchParams={searchParams}
- allowedToManage={allowedToManage}
- />
- </div>
- {/* Main Content */}
- <div className='flex flex-1 flex-col px-4 py-2 sm:px-6 lg:px-8'>
- <MobileTabSelector />
- <WaitingForAnError />
- </div>
- </div>
- {!isEmbedded ? <Footer /> : null}
- </>
- )
- }
-
return (
<ClientOnly>
{() => (