Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Remove legacy session salt mechanism

Blue Mouseb9a8cf3ae72e
diff --git a/backend/apps/cloud/src/common/constants.ts b/backend/apps/cloud/src/common/constants.ts
index 8a16bfe5a..78b950fb9 100644
--- a/backend/apps/cloud/src/common/constants.ts
+++ b/backend/apps/cloud/src/common/constants.ts
@@ -50,7 +50,6 @@ const getRedisUserCountKey = (uid: string) => `user_c_${uid}`
const getRedisUserUsageInfoKey = (uid: string) => `user_ui_${uid}`
const getRedisCaptchaKey = (token: string) => `captcha_${hash(token)}`
-const REDIS_SESSION_SALT_KEY = 'log_salt' // legacy key, kept for backward compatibility
const REDIS_USERS_COUNT_KEY = 'stats:users_count'
const REDIS_TRIALS_COUNT_KEY = 'stats:trials_count'
const REDIS_PROJECTS_COUNT_KEY = 'stats:projects_count'
@@ -180,7 +179,6 @@ export {
UNIQUE_SESSION_LIFE_TIME,
getRedisUserCountKey,
redisProjectCountCacheTimeout,
- REDIS_SESSION_SALT_KEY,
REDIS_USERS_COUNT_KEY,
REDIS_TRIALS_COUNT_KEY,
REDIS_PROJECTS_COUNT_KEY,
diff --git a/backend/apps/cloud/src/task-manager/task-manager.service.ts b/backend/apps/cloud/src/task-manager/task-manager.service.ts
index 108b3ee4c..9ec1af618 100644
--- a/backend/apps/cloud/src/task-manager/task-manager.service.ts
+++ b/backend/apps/cloud/src/task-manager/task-manager.service.ts
@@ -3,7 +3,6 @@ import { Cron, CronExpression } from '@nestjs/schedule'
import { IsNull, LessThan, In, Not, Between, MoreThan, Like } from 'typeorm'
import { ConfigService } from '@nestjs/config'
import Paypal from '@paypal/payouts-sdk'
-import bcrypt from 'bcrypt'
import dayjs from 'dayjs'
import utc from 'dayjs/plugin/utc'
import _isEmpty from 'lodash/isEmpty'
@@ -45,7 +44,6 @@ import {
} from '../user/entities/user.entity'
import {
redis,
- REDIS_SESSION_SALT_KEY,
SEND_WARNING_AT_PERC,
PROJECT_INVITE_EXPIRE,
JWT_REFRESH_TOKEN_LIFETIME,
@@ -690,13 +688,6 @@ export class TaskManagerService {
)
}
- // Legacy global salt rotation (kept for backward compatibility with older clients)
- @Cron(CronExpression.EVERY_DAY_AT_MIDNIGHT)
- async generateSessionSalt() {
- const salt = await bcrypt.genSalt(10)
- await redis.set(REDIS_SESSION_SALT_KEY, salt, 'EX', 87000)
- }
-
// Ensure global salts exist for all rotation periods (daily/weekly/monthly)
// Salts auto-expire via Redis TTL, this just ensures they're regenerated if missing
@Cron(CronExpression.EVERY_HOUR)
diff --git a/backend/apps/community/src/common/constants.ts b/backend/apps/community/src/common/constants.ts
index 8e8b9c782..8f05ae88a 100644
--- a/backend/apps/community/src/common/constants.ts
+++ b/backend/apps/community/src/common/constants.ts
@@ -51,7 +51,6 @@ const isValidPID = (pid: string) => PID_REGEX.test(pid)
// redis keys
const getRedisProjectKey = (pid: string) => `pid_${pid}`
-const REDIS_SESSION_SALT_KEY = 'log_salt' // legacy key, kept for backward compatibility
const REDIS_OIDC_SESSION_KEY = 'oidc:session'
// 3600 sec -> 1 hour
@@ -114,7 +113,6 @@ export {
redisProjectCacheTimeout,
UNIQUE_SESSION_LIFE_TIME,
TRAFFIC_METAKEY_COLUMNS,
- REDIS_SESSION_SALT_KEY,
IP_REGEX,
ORIGINS_REGEX,
isDevelopment,
diff --git a/backend/apps/community/src/task-manager/task-manager.service.ts b/backend/apps/community/src/task-manager/task-manager.service.ts
index 92bc31d84..fa718d273 100644
--- a/backend/apps/community/src/task-manager/task-manager.service.ts
+++ b/backend/apps/community/src/task-manager/task-manager.service.ts
@@ -1,13 +1,12 @@
import { Injectable } from '@nestjs/common'
import { Cron, CronExpression } from '@nestjs/schedule'
-import bcrypt from 'bcrypt'
import dayjs from 'dayjs'
import utc from 'dayjs/plugin/utc'
import _size from 'lodash/size'
import _map from 'lodash/map'
import _now from 'lodash/now'
-import { redis, REDIS_SESSION_SALT_KEY } from '../common/constants'
+import { redis } from '../common/constants'
import { clickhouse } from '../common/integrations/clickhouse'
import { AppLoggerService } from '../logger/logger.service'
import { SaltService } from '../analytics/salt.service'
@@ -21,13 +20,6 @@ export class TaskManagerService {
private readonly saltService: SaltService,
) {}
- // Legacy global salt rotation (kept for backward compatibility with older clients)
- @Cron(CronExpression.EVERY_DAY_AT_MIDNIGHT)
- async generateSessionSalt() {
- const salt = await bcrypt.genSalt(10)
- await redis.set(REDIS_SESSION_SALT_KEY, salt, 'EX', 87000)
- }
-
// Ensure global salts exist for all rotation periods (daily/weekly/monthly)
// Salts auto-expire via Redis TTL, this just ensures they're regenerated if missing
@Cron(CronExpression.EVERY_HOUR)