Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

(feature) Account deletion feedback (#187)

Andrii Romasiunba6fc69856c6
diff --git a/apps/production/src/user/dto/delete-self.dto.ts b/apps/production/src/user/dto/delete-self.dto.ts
new file mode 100644
index 000000000..674b2823e
--- /dev/null
+++ b/apps/production/src/user/dto/delete-self.dto.ts
@@ -0,0 +1,12 @@
+import { ApiProperty } from '@nestjs/swagger'
+import { IsString, IsOptional } from 'class-validator'
+
+export class DeleteSelfDTO {
+ @ApiProperty({
+ example: 'I want to delete my account because ... and ...',
+ required: false,
+ })
+ @IsOptional()
+ @IsString()
+ feedback: string
+}
diff --git a/apps/production/src/user/entities/delete-feedback.entity.ts b/apps/production/src/user/entities/delete-feedback.entity.ts
new file mode 100644
index 000000000..aaa008b54
--- /dev/null
+++ b/apps/production/src/user/entities/delete-feedback.entity.ts
@@ -0,0 +1,12 @@
+import { Column, Entity, PrimaryGeneratedColumn } from 'typeorm'
+
+@Entity()
+export class DeleteFeedback {
+ @PrimaryGeneratedColumn('uuid')
+ id: string
+
+ @Column('text', {
+ nullable: true,
+ })
+ feedback: string
+}
diff --git a/apps/production/src/user/user.controller.ts b/apps/production/src/user/user.controller.ts
index f6808b406..250be9203 100644
--- a/apps/production/src/user/user.controller.ts
+++ b/apps/production/src/user/user.controller.ts
@@ -63,6 +63,7 @@ import { AuthService } from '../auth/auth.service'
import { LetterTemplate } from '../mailer/letter'
import { AppLoggerService } from '../logger/logger.service'
import { UserProfileDTO } from './dto/user.dto'
+import { DeleteSelfDTO } from './dto/delete-self.dto'
import {
checkRateLimit,
getGeoDetails,
@@ -287,7 +288,10 @@ export class UserController {
@HttpCode(204)
@UseGuards(JwtAccessTokenGuard, RolesGuard)
@Roles(UserType.CUSTOMER, UserType.ADMIN)
- async deleteSelf(@CurrentUserId() id: string): Promise<any> {
+ async deleteSelf(
+ @CurrentUserId() id: string,
+ @Body() deleteSelfDTO: DeleteSelfDTO,
+ ): Promise<any> {
this.logger.log({ id }, 'DELETE /user')
const user = await this.userService.findOne(id, {
@@ -313,12 +317,24 @@ export class UserController {
}
await this.actionTokensService.deleteMultiple(`userId="${id}"`)
await this.userService.delete(id)
-
- return 'accountDeleted'
} catch (e) {
this.logger.error(e)
throw new BadRequestException('accountDeleteError')
}
+
+ try {
+ if (deleteSelfDTO.feedback) {
+ await this.userService.saveDeleteFeedback(deleteSelfDTO.feedback)
+ }
+ } catch (reason) {
+ this.logger.error(
+ '[ERROR] Failed to save account deletion feedback:',
+ reason,
+ )
+ this.logger.error('DeleteSelfDTO: ', deleteSelfDTO)
+ }
+
+ return 'accountDeleted'
}
@Delete('/share/:shareId')
diff --git a/apps/production/src/user/user.module.ts b/apps/production/src/user/user.module.ts
index ebc36563a..faabf717c 100644
--- a/apps/production/src/user/user.module.ts
+++ b/apps/production/src/user/user.module.ts
@@ -11,11 +11,12 @@ import { AuthModule } from '../auth/auth.module'
import { AppLoggerModule } from '../logger/logger.module'
import { ProjectModule } from '../project/project.module'
import { RefreshToken } from './entities/refresh-token.entity'
+import { DeleteFeedback } from './entities/delete-feedback.entity'
import { Message } from '../integrations/telegram/entities/message.entity'
@Module({
imports: [
- TypeOrmModule.forFeature([User, RefreshToken, Message]),
+ TypeOrmModule.forFeature([User, RefreshToken, DeleteFeedback, Message]),
ActionTokensModule,
MailerModule,
forwardRef(() => AuthModule),
diff --git a/apps/production/src/user/user.service.ts b/apps/production/src/user/user.service.ts
index 7c1766be4..6b1ec9429 100644
--- a/apps/production/src/user/user.service.ts
+++ b/apps/production/src/user/user.service.ts
@@ -21,6 +21,7 @@ import {
} from './entities/user.entity'
import { UserProfileDTO } from './dto/user.dto'
import { RefreshToken } from './entities/refresh-token.entity'
+import { DeleteFeedback } from './entities/delete-feedback.entity'
import { UserGoogleDTO } from './dto/user-google.dto'
import { UserGithubDTO } from './dto/user-github.dto'
@@ -87,6 +88,8 @@ export class UserService {
private usersRepository: Repository<User>,
@InjectRepository(RefreshToken)
private readonly refreshTokenRepository: Repository<RefreshToken>,
+ @InjectRepository(DeleteFeedback)
+ private readonly deleteFeedbackRepository: Repository<DeleteFeedback>,
) {}
async create(
@@ -251,6 +254,20 @@ export class UserService {
return this.usersRepository.update({ id }, user)
}
+ public async saveDeleteFeedback(feedback: string) {
+ return this.deleteFeedbackRepository.save({
+ feedback,
+ })
+ }
+
+ public async findDeleteFeedback(id: string) {
+ return this.deleteFeedbackRepository.findOne({ id })
+ }
+
+ public async deleteDeleteFeedback(id: string) {
+ await this.deleteFeedbackRepository.delete({ id })
+ }
+
public async saveRefreshToken(userId: string, refreshToken: string) {
return this.refreshTokenRepository.save({
userId,
diff --git a/migrations/mysql/2023_09_08.sql b/migrations/mysql/2023_09_08.sql
new file mode 100644
index 000000000..051f45765
--- /dev/null
+++ b/migrations/mysql/2023_09_08.sql
@@ -0,0 +1,5 @@
+CREATE TABLE IF NOT EXISTS `delete_feedback` (
+ `id` varchar(36) NOT NULL,
+ `feedback` text,
+ PRIMARY KEY (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;