Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Throw on incorrect filters

Blue Mousec09e0d8fbc17
diff --git a/backend/apps/cloud/src/project/gsc.service.ts b/backend/apps/cloud/src/project/gsc.service.ts
index bc04531f1..14ad72654 100644
--- a/backend/apps/cloud/src/project/gsc.service.ts
+++ b/backend/apps/cloud/src/project/gsc.service.ts
@@ -357,11 +357,11 @@ export class GSCService {
try {
filters = JSON.parse(filtersStr)
} catch {
- return undefined
+ throw new BadRequestException('Invalid filters parameter')
}
if (!Array.isArray(filters) || filters.length > MAX_FILTERS) {
- return undefined
+ throw new BadRequestException('Invalid filters parameter')
}
const mappedFilters: Array<{
@@ -371,7 +371,9 @@ export class GSCService {
}> = []
for (const filter of filters) {
- if (typeof filter !== 'object' || filter === null) continue
+ if (typeof filter !== 'object' || filter === null) {
+ throw new BadRequestException('Invalid filters parameter')
+ }
const {
column,
@@ -385,7 +387,9 @@ export class GSCService {
isContains?: unknown
}
- if (typeof column !== 'string' || typeof value !== 'string') continue
+ if (typeof column !== 'string' || typeof value !== 'string') {
+ throw new BadRequestException('Invalid filters parameter')
+ }
if (value.length > MAX_FILTER_EXPRESSION_LENGTH) continue
let dimension: string | undefined