Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

fix incorrect experiment results calculation

Blue Mousecbbac5cc6b81
diff --git a/backend/apps/cloud/src/experiment/experiment.controller.ts b/backend/apps/cloud/src/experiment/experiment.controller.ts
index f12e29fe9..68c359cf9 100644
--- a/backend/apps/cloud/src/experiment/experiment.controller.ts
+++ b/backend/apps/cloud/src/experiment/experiment.controller.ts
@@ -1194,25 +1194,25 @@ export class ExperimentController {
experiment.multipleVariantHandling ===
MultipleVariantHandling.FIRST_EXPOSURE ||
experiment.multipleVariantHandling === MultipleVariantHandling.EXCLUDE
- ? 'argMin(variantKey, tuple(created, variantKey))'
- : 'any(variantKey)'
+ ? 'argMin(ee.variantKey, tuple(ee.created, ee.variantKey))'
+ : 'any(ee.variantKey)'
const multiVariantFilter =
experiment.multipleVariantHandling === MultipleVariantHandling.EXCLUDE
- ? 'HAVING uniqExact(variantKey) = 1'
+ ? 'HAVING uniqExact(ee.variantKey) = 1'
: ''
return `
SELECT
- pid,
- profileId,
+ ee.pid as pid,
+ ee.profileId as profileId,
${variantSelector} as variantKey,
- min(created) as exposureCreated
- FROM experiment_exposures
+ min(ee.created) as exposureCreated
+ FROM experiment_exposures ee
WHERE
- pid = {pid:FixedString(12)}
- AND experimentId = {experimentId:String}
- AND created BETWEEN {groupFrom:String} AND {groupTo:String}
- GROUP BY pid, profileId
+ ee.pid = {pid:FixedString(12)}
+ AND ee.experimentId = {experimentId:String}
+ AND ee.created BETWEEN {groupFrom:String} AND {groupTo:String}
+ GROUP BY ee.pid, ee.profileId
${multiVariantFilter}
`
}
diff --git a/backend/apps/community/src/experiment/experiment.controller.ts b/backend/apps/community/src/experiment/experiment.controller.ts
index c4599ab52..362b32c27 100644
--- a/backend/apps/community/src/experiment/experiment.controller.ts
+++ b/backend/apps/community/src/experiment/experiment.controller.ts
@@ -1065,24 +1065,25 @@ export class ExperimentController {
}
private getExposureAttributionSubquery(experiment: Experiment): string {
- const variantSelector = 'argMin(variantKey, tuple(created, variantKey))'
+ const variantSelector =
+ 'argMin(ee.variantKey, tuple(ee.created, ee.variantKey))'
const multiVariantFilter =
experiment.multipleVariantHandling === MultipleVariantHandling.EXCLUDE
- ? 'HAVING uniqExact(variantKey) = 1'
+ ? 'HAVING uniqExact(ee.variantKey) = 1'
: ''
return `
SELECT
- pid,
- profileId,
+ ee.pid as pid,
+ ee.profileId as profileId,
${variantSelector} as variantKey,
- min(created) as exposureCreated
- FROM experiment_exposures
+ min(ee.created) as exposureCreated
+ FROM experiment_exposures ee
WHERE
- pid = {pid:FixedString(12)}
- AND experimentId = {experimentId:String}
- AND created BETWEEN {groupFrom:String} AND {groupTo:String}
- GROUP BY pid, profileId
+ ee.pid = {pid:FixedString(12)}
+ AND ee.experimentId = {experimentId:String}
+ AND ee.created BETWEEN {groupFrom:String} AND {groupTo:String}
+ GROUP BY ee.pid, ee.profileId
${multiVariantFilter}
`
}