Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

remove obsolete TODOs

Blue Moused065ba5a8aa0
diff --git a/src/analytics/analytics.controller.ts b/src/analytics/analytics.controller.ts
index f5ee606f1..e929e05eb 100644
--- a/src/analytics/analytics.controller.ts
+++ b/src/analytics/analytics.controller.ts
@@ -291,7 +291,6 @@ export class AnalyticsController {
await this.analyticsService.checkProjectAccess(pid, uid)
let queryCustoms = `SELECT ev, count() FROM customEV WHERE pid = {pid:FixedString(12)} ${filtersQuery} AND created BETWEEN {groupFrom:String} AND {groupTo:String} GROUP BY ev`
- // TODO: Refactor
let subQuery = `FROM ${
isCaptcha ? 'captcha' : 'analytics'
} WHERE pid = {pid:FixedString(12)} ${filtersQuery} AND created BETWEEN {groupFrom:String} AND {groupTo:String}`
diff --git a/src/project/project.controller.ts b/src/project/project.controller.ts
index 17df5b8b1..0973cc1e0 100644
--- a/src/project/project.controller.ts
+++ b/src/project/project.controller.ts
@@ -1380,10 +1380,6 @@ export class ProjectController {
)
}
- // TODO: Discuss.
- // I'm not sure if we should select 'share' from project too.
- // If we select share - this means that the share project admins would be able to delete other people from project share too
- // (as the allowedToManage method would pass for them).
const project = await this.projectService.findOneWhere(
{ id: pid },
{