Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Remove 'unique' params I overlooked

Blue Moused1b60c291e7a
diff --git a/backend/apps/production/src/analytics/analytics.controller.ts b/backend/apps/production/src/analytics/analytics.controller.ts
index 46b461399..3813547b2 100644
--- a/backend/apps/production/src/analytics/analytics.controller.ts
+++ b/backend/apps/production/src/analytics/analytics.controller.ts
@@ -1339,7 +1339,6 @@ export class AnalyticsController {
region,
city,
logDTO.meta,
- Number(unique),
)
let perfTransformed = null
@@ -1433,7 +1432,7 @@ export class AnalyticsController {
await this.analyticsService.validate(logDTO, origin, ip)
- const [unique, psid] = await this.analyticsService.isUnique(
+ const [, psid] = await this.analyticsService.isUnique(
logDTO.pid,
userAgent,
ip,
@@ -1471,7 +1470,6 @@ export class AnalyticsController {
region,
city,
null,
- Number(unique),
)
try {
diff --git a/backend/apps/production/src/analytics/analytics.service.ts b/backend/apps/production/src/analytics/analytics.service.ts
index a6f68884c..6022c8972 100644
--- a/backend/apps/production/src/analytics/analytics.service.ts
+++ b/backend/apps/production/src/analytics/analytics.service.ts
@@ -2475,12 +2475,11 @@ export class AnalyticsService {
${selector},
avgOrNull(session_durations.duration) as sdur,
count() as pageviews,
- sum(unique) as uniques
+ count(DISTINCT psid) as uniques
FROM (
SELECT
pid,
psid,
- unique,
${timeBucketFunc}(toTimeZone(created, '${safeTimezone}')) as tz_created
FROM analytics
PREWHERE pid = {pid:FixedString(12)}
diff --git a/backend/apps/production/src/analytics/utils/transformers.ts b/backend/apps/production/src/analytics/utils/transformers.ts
index 9056d3740..e14fa85ab 100644
--- a/backend/apps/production/src/analytics/utils/transformers.ts
+++ b/backend/apps/production/src/analytics/utils/transformers.ts
@@ -43,7 +43,6 @@ export const trafficTransformer = (
rg: string | null,
ct: string | null,
meta: Record<string, string> | null,
- unique: number,
) => {
return {
psid,
@@ -65,7 +64,6 @@ export const trafficTransformer = (
rg: rg || null,
ct: ct || null,
...processMetaKV(meta),
- unique,
created: dayjs.utc().format('YYYY-MM-DD HH:mm:ss'),
}
}
diff --git a/backend/apps/selfhosted/src/analytics/analytics.controller.ts b/backend/apps/selfhosted/src/analytics/analytics.controller.ts
index 023207bcd..bde436065 100644
--- a/backend/apps/selfhosted/src/analytics/analytics.controller.ts
+++ b/backend/apps/selfhosted/src/analytics/analytics.controller.ts
@@ -1057,7 +1057,6 @@ export class AnalyticsController {
region,
city,
logDTO.meta,
- Number(unique),
)
let perfTransformed = null
@@ -1150,7 +1149,7 @@ export class AnalyticsController {
await this.analyticsService.validate(logDTO, origin, ip)
- const [unique, psid] = await this.analyticsService.isUnique(
+ const [, psid] = await this.analyticsService.isUnique(
logDTO.pid,
userAgent,
ip,
@@ -1189,7 +1188,6 @@ export class AnalyticsController {
region,
city,
null,
- Number(unique),
)
try {
diff --git a/backend/apps/selfhosted/src/analytics/analytics.service.ts b/backend/apps/selfhosted/src/analytics/analytics.service.ts
index a0117fc7b..6e923dd26 100644
--- a/backend/apps/selfhosted/src/analytics/analytics.service.ts
+++ b/backend/apps/selfhosted/src/analytics/analytics.service.ts
@@ -2089,7 +2089,6 @@ export class AnalyticsService {
SELECT
pid,
psid,
- unique,
${timeBucketFunc}(toTimeZone(created, '${safeTimezone}')) as tz_created
FROM analytics
PREWHERE pid = {pid:FixedString(12)}
diff --git a/backend/apps/selfhosted/src/analytics/utils/transformers.ts b/backend/apps/selfhosted/src/analytics/utils/transformers.ts
index 9056d3740..e14fa85ab 100644
--- a/backend/apps/selfhosted/src/analytics/utils/transformers.ts
+++ b/backend/apps/selfhosted/src/analytics/utils/transformers.ts
@@ -43,7 +43,6 @@ export const trafficTransformer = (
rg: string | null,
ct: string | null,
meta: Record<string, string> | null,
- unique: number,
) => {
return {
psid,
@@ -65,7 +64,6 @@ export const trafficTransformer = (
rg: rg || null,
ct: ct || null,
...processMetaKV(meta),
- unique,
created: dayjs.utc().format('YYYY-MM-DD HH:mm:ss'),
}
}