Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Better step validation

Blue Moused6b5cf767168
diff --git a/backend/apps/cloud/src/analytics/analytics.controller.ts b/backend/apps/cloud/src/analytics/analytics.controller.ts
index f038c6cda..36152d32e 100644
--- a/backend/apps/cloud/src/analytics/analytics.controller.ts
+++ b/backend/apps/cloud/src/analytics/analytics.controller.ts
@@ -513,8 +513,10 @@ export class AnalyticsController {
pid,
)
- if (step > pagesArr.length) {
- throw new BadRequestException('Step exceeds the number of funnel steps')
+ if (step < 1 || step > pagesArr.length) {
+ throw new BadRequestException(
+ 'Step must be between 1 and the number of funnel steps',
+ )
}
const take = this.analyticsService.getSafeNumber(data.take, 30)
diff --git a/backend/apps/community/src/analytics/analytics.controller.ts b/backend/apps/community/src/analytics/analytics.controller.ts
index adbc715e2..68f47cbc2 100644
--- a/backend/apps/community/src/analytics/analytics.controller.ts
+++ b/backend/apps/community/src/analytics/analytics.controller.ts
@@ -499,8 +499,10 @@ export class AnalyticsController {
pid,
)
- if (step > pagesArr.length) {
- throw new BadRequestException('Step exceeds the number of funnel steps')
+ if (step < 1 || step > pagesArr.length) {
+ throw new BadRequestException(
+ 'Step must be between 1 and the number of funnel steps',
+ )
}
const take = this.analyticsService.getSafeNumber(data.take, 30)