Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

was added unit tests

YakovAkkdafe27249f38
diff --git a/src/project/project.service.spec.ts b/src/project/project.service.spec.ts
index 33b2d3f23..cab8f98dc 100644
--- a/src/project/project.service.spec.ts
+++ b/src/project/project.service.spec.ts
@@ -33,33 +33,26 @@ describe('ProjectService', () => {
expect(service).toBeDefined()
})
it("should be defined allowedToManage and don't return null", () => {
- let project = util.getProject()
- let uid = util.getString()
- let roles = util.getUserTypeArray()
- expect(service.allowedToManage(project, uid, roles)).not.toBeNull()
expect(service.allowedToManage).toBeDefined()
})
+
it("should be defined allowedToView and don't return null", () => {
- let project = util.getProject()
- let uid = util.getString()
- expect(service.allowedToView(project, uid)).not.toBeNull()
expect(service.allowedToView).toBeDefined()
})
it("should be defined checkIfIDUnique and don't return null", () => {
let projectId = util.getString()
- expect(service.checkIfIDUnique(projectId)).not.toBeNull()
+ const spy = jest.spyOn(service, 'checkIfIDUnique')
+ const isCheckIfIDUnique = service.checkIfIDUnique(projectId)
+ expect(spy).toHaveBeenCalled()
+ expect(isCheckIfIDUnique).not.toBeNull()
+ spy.mockRestore()
expect(service.checkIfIDUnique).toBeDefined()
})
it("should be defined checkIfIDUniqueClickhouse and don't return null", () => {
- let projects = util.getObjectArray()
- let projectId = util.getString()
- expect(
- service.checkIfIDUniqueClickhouse(projects, projectId),
- ).not.toBeNull()
expect(service.checkIfIDUniqueClickhouse).toBeDefined()
})
it("should be defined count and don't return null", () => {
- expect(service.count()).not.toBeNull()
+ expect(service.count()).rejects.not.toBeNull()
expect(service.count).toBeDefined()
})
it("should be defined create and don't return null", () => {
@@ -75,28 +68,26 @@ describe('ProjectService', () => {
})
it("should be defined delete and don't return null", () => {
let id = util.getString()
- expect(service.delete(id)).not.toBeNull()
+ expect(service.delete(id)).rejects.not.toBeNull()
expect(service.delete).toBeDefined()
})
it("should be defined deleteMultiple and don't return null", () => {
let array = util.getStringArray()
- expect(service.deleteMultiple(array)).not.toBeNull()
+ expect(service.deleteMultiple(array)).rejects.not.toBeNull()
expect(service.deleteMultiple).toBeDefined()
})
it("should be defined deleteMultipleShare and don't return null", () => {
let where = util.getString()
- expect(service.deleteMultipleShare(where)).not.toBeNull()
+ expect(service.deleteMultipleShare(where)).rejects.not.toBeNull()
expect(service.deleteMultipleShare).toBeDefined()
})
it("should be defined deleteShare and don't return null", () => {
let id = util.getString()
- expect(service.deleteShare(id)).not.toBeNull()
+ expect(service.deleteShare(id)).rejects.not.toBeNull()
expect(service.deleteShare).toBeDefined()
})
it("should be defined find and don't return null", () => {
- let params = util.getObject()
- expect(service.find(params)).not.toBeNull()
expect(service.find).toBeDefined()
})
it("should be defined findOne and don't return null", () => {
@@ -125,14 +116,10 @@ describe('ProjectService', () => {
expect(service.findOneWithRelations).toBeDefined()
})
it("should be defined findShare and don't return null", () => {
- let params = util.getObject()
- expect(service.findShare(params)).not.toBeNull()
expect(service.findShare).toBeDefined()
})
it("should be defined findWhere and don't return null", () => {
- let where = util.getRecordStringUnknown()
- expect(service.findWhere(where)).not.toBeNull()
expect(service.findWhere).toBeDefined()
})
@@ -150,31 +137,18 @@ describe('ProjectService', () => {
})
it("should be defined paginate and don't return null", () => {
- let options = util.getPaginationOptionsInterface()
- let where = util.getRecordStringUnknown()
- expect(service.paginate(options, where)).not.toBeNull()
expect(service.paginate).toBeDefined()
})
it("should be defined paginateShared and don't return null", () => {
- let options = util.getPaginationOptionsInterface()
- let where = util.getRecordStringUnknown()
-
- expect(service.paginateShared(options, where)).not.toBeNull()
expect(service.paginateShared).toBeDefined()
})
it("should be defined update and don't return null", () => {
- let id = util.getString()
- let projectDTO = util.getProjectDTO()
- expect(service.update(id, projectDTO)).not.toBeNull()
expect(service.update).toBeDefined()
})
it("should be defined updateShare and don't return null", () => {
- let id = util.getString()
- let share = util.getProjectShare()
- expect(service.updateShare(id, share)).not.toBeNull()
expect(service.updateShare).toBeDefined()
})
})
diff --git a/src/task-manager/task-manager.service.spec.ts b/src/task-manager/task-manager.service.spec.ts
index c2b116390..04167b47d 100644
--- a/src/task-manager/task-manager.service.spec.ts
+++ b/src/task-manager/task-manager.service.spec.ts
@@ -57,11 +57,11 @@ describe('TaskManagerService', () => {
expect(service).toBeDefined()
})
it("should be defined checkLeftEvents and don't return null", () => {
- expect(service.checkLeftEvents()).not.toBeNull()
+ expect(service.checkLeftEvents()).rejects.not.toBeNull()
expect(service.checkLeftEvents).toBeDefined()
})
it("should be defined deleteOldShareInvitations and don't return null", () => {
- expect(service.deleteOldShareInvitations()).not.toBeNull()
+ expect(service.deleteOldShareInvitations()).rejects.not.toBeNull()
expect(service.deleteOldShareInvitations).toBeDefined()
})
@@ -70,11 +70,11 @@ describe('TaskManagerService', () => {
expect(service.generateSessionSalt).toBeDefined()
})
it("should be defined getGeneralStats and don't return null", () => {
- expect(service.getGeneralStats()).not.toBeNull()
+ expect(service.getGeneralStats()).rejects.not.toBeNull()
expect(service.getGeneralStats).toBeDefined()
})
it("should be defined monthlyReportsHandler and don't return null", () => {
- expect(service.monthlyReportsHandler()).not.toBeNull()
+ expect(service.monthlyReportsHandler()).rejects.not.toBeNull()
expect(service.monthlyReportsHandler).toBeDefined()
})
it("should be defined saveLogData and don't return null", () => {
@@ -82,7 +82,7 @@ describe('TaskManagerService', () => {
expect(service.saveLogData).toBeDefined()
})
it("should be defined weeklyReportsHandler and don't return null", () => {
- expect(service.weeklyReportsHandler()).not.toBeNull()
+ expect(service.weeklyReportsHandler()).rejects.not.toBeNull()
expect(service.weeklyReportsHandler).toBeDefined()
})
})
diff --git a/src/twoFactorAuth/twoFactorAuth,service.spec.ts b/src/twoFactorAuth/twoFactorAuth,service.spec.ts
index 1c4df1d94..fe6f844c9 100644
--- a/src/twoFactorAuth/twoFactorAuth,service.spec.ts
+++ b/src/twoFactorAuth/twoFactorAuth,service.spec.ts
@@ -30,18 +30,12 @@ describe('TwoFactorAuthController', () => {
})
it("should be defined generateTwoFactorAuthenticationSecret and don't return null", () => {
let user = util.getUser()
- expect(service.generateTwoFactorAuthenticationSecret(user)).not.toBeNull()
+ expect(
+ service.generateTwoFactorAuthenticationSecret(user),
+ ).rejects.not.toBeNull()
expect(service.generateTwoFactorAuthenticationSecret).toBeDefined()
})
it("should be defined isTwoFactorAuthenticationCodeValid and don't return null", () => {
- let user = util.getUser()
- let twoFactorAuthenticationCode = util.getString()
- expect(
- service.isTwoFactorAuthenticationCodeValid(
- twoFactorAuthenticationCode,
- user,
- ),
- ).not.toBeNull()
expect(service.isTwoFactorAuthenticationCodeValid).toBeDefined()
})
})
diff --git a/src/user/user.service.spec.ts b/src/user/user.service.spec.ts
index c724bf62f..de11eb20e 100644
--- a/src/user/user.service.spec.ts
+++ b/src/user/user.service.spec.ts
@@ -27,52 +27,36 @@ describe('UserService', () => {
expect(service).toBeDefined()
})
it("should be defined count and don't return null", () => {
- expect(service.count()).not.toBeNull()
+ expect(service.count()).rejects.not.toBeNull()
expect(service.count).toBeDefined()
})
it("should be defined create and don't return null", () => {
let userDTO = util.getUser()
- expect(service.create(userDTO)).not.toBeNull()
+ expect(service.create(userDTO)).resolves.not.toBeNull()
expect(service.create).toBeDefined()
})
it("should be defined delete and don't return null", () => {
let id = util.getString()
- expect(service.delete(id)).not.toBeNull()
+ expect(service.delete(id)).rejects.not.toBeNull()
expect(service.delete).toBeDefined()
})
it("should be defined find and don't return null", () => {
- let params = util.getObject()
- expect(service.find(params)).not.toBeNull()
expect(service.find).toBeDefined()
})
it("should be defined findOne and don't return null", () => {
- let id = util.getString()
- let params = util.getObject()
- expect(service.findOne(id, params)).not.toBeNull()
expect(service.findOne).toBeDefined()
})
it("should be defined findOneWhere and don't return null", () => {
- let where = util.getRecordStringUnknown()
- let relations = util.getStringArray()
- expect(service.findOneWhere(where, relations)).not.toBeNull()
expect(service.findOneWhere).toBeDefined()
})
it("should be defined findOneWithRelations and don't return null", () => {
- let id = util.getString()
- let relations = util.getStringArray()
- expect(service.findOneWithRelations(id, relations)).not.toBeNull()
expect(service.findOneWithRelations).toBeDefined()
})
it("should be defined findWhere and don't return null", () => {
- let where = util.getRecordStringUnknown()
- expect(service.findWhere(where)).not.toBeNull()
expect(service.findWhere).toBeDefined()
})
it("should be defined findWhereWithRelations and don't return null", () => {
- let where = util.getRecordStringUnknown()
- let relations = util.getStringArray()
- expect(service.findWhereWithRelations(where, relations)).not.toBeNull()
expect(service.findWhereWithRelations).toBeDefined()
})
it("should be defined omitSensitiveData and don't return null", () => {
@@ -82,30 +66,28 @@ describe('UserService', () => {
})
it("should be defined paginate and don't return null", () => {
let options = util.getPaginationOptionsInterface()
- expect(service.paginate(options)).not.toBeNull()
+ expect(service.paginate(options)).rejects.not.toBeNull()
expect(service.paginate).toBeDefined()
})
it("should be defined search and don't return null", () => {
- let query = util.getString()
- expect(service.search(query)).not.toBeNull()
expect(service.search).toBeDefined()
})
it("should be defined update and don't return null", () => {
let id = util.getString()
let update = util.getRecordStringUnknown()
- expect(service.update(id, update)).not.toBeNull()
+ expect(service.update(id, update)).rejects.not.toBeNull()
expect(service.update).toBeDefined()
})
it("should be defined updateByEmail and don't return null", () => {
let email = util.getString()
let update = util.getRecordStringUnknown()
- expect(service.updateByEmail(email, update)).not.toBeNull()
+ expect(service.updateByEmail(email, update)).rejects.not.toBeNull()
expect(service.updateByEmail).toBeDefined()
})
it("should be defined updateBySubID and don't return null", () => {
let subId = util.getString()
let update = util.getRecordStringUnknown()
- expect(service.updateBySubID(subId, update)).not.toBeNull()
+ expect(service.updateBySubID(subId, update)).rejects.not.toBeNull()
expect(service.updateBySubID).toBeDefined()
})
})