Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

updatePreferences fix

Blue Mousee0592007d49c
diff --git a/web/app/pages/Captcha/View/ViewCaptcha.tsx b/web/app/pages/Captcha/View/ViewCaptcha.tsx
index 923754fb0..abb391e2b 100644
--- a/web/app/pages/Captcha/View/ViewCaptcha.tsx
+++ b/web/app/pages/Captcha/View/ViewCaptcha.tsx
@@ -520,6 +520,7 @@ const ViewCaptcha = ({ ssrTheme }: ViewCaptchaProps) => {
updatePreferences({
period: newPeriod.period,
timeBucket: tb,
+ rangeDate: undefined,
})
setPeriod(newPeriod.period)
setDateRange(null)
diff --git a/web/app/pages/Project/View/ViewProject.tsx b/web/app/pages/Project/View/ViewProject.tsx
index 3fb4381e0..a081d1d1f 100644
--- a/web/app/pages/Project/View/ViewProject.tsx
+++ b/web/app/pages/Project/View/ViewProject.tsx
@@ -2504,6 +2504,7 @@ const ViewProject = () => {
updatePreferences({
period: newPeriod.period,
timeBucket: tb,
+ rangeDate: undefined,
})
setPeriod(newPeriod.period)
diff --git a/web/app/pages/Project/View/providers/CurrentProjectProvider.tsx b/web/app/pages/Project/View/providers/CurrentProjectProvider.tsx
index 2cb721a6d..ef458d24b 100644
--- a/web/app/pages/Project/View/providers/CurrentProjectProvider.tsx
+++ b/web/app/pages/Project/View/providers/CurrentProjectProvider.tsx
@@ -125,22 +125,7 @@ const useProjectPreferences = (id: string) => {
const updatePreferences = useCallback(
(prefs: ProjectPreferences) => {
setPreferences((prev) => {
- const { period, timeBucket, rangeDate, ...rest } = prefs
-
- // This bullshit is needed for backward compatibility with the old Redux state preferences
- // One day I'll refactor the code properly, until then, here's a TODO so I don't forget
- const viewPrefs = rangeDate
- ? {
- period,
- timeBucket,
- rangeDate,
- }
- : {
- period,
- timeBucket,
- }
-
- const newPrefs = { ...prev, ...viewPrefs, ...rest }
+ const newPrefs = { ...prev, ...prefs }
setProjectPreferences(id, newPrefs)
return newPrefs
})