Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Random sid generation

Blue Mousee8237e2c18ca
diff --git a/backend/apps/cloud/src/analytics/analytics.service.ts b/backend/apps/cloud/src/analytics/analytics.service.ts
index 6bd535e3d..0631c73eb 100644
--- a/backend/apps/cloud/src/analytics/analytics.service.ts
+++ b/backend/apps/cloud/src/analytics/analytics.service.ts
@@ -2397,13 +2397,8 @@ export class AnalyticsService {
return `ses:${psid}`
}
- private generateSid(psid: string): string {
- return crypto
- .createHash('sha256')
- .update(`${psid}:${Date.now()}:${crypto.randomBytes(16).toString('hex')}`)
- .digest()
- .readBigUInt64BE(0)
- .toString()
+ private generateSid(): string {
+ return crypto.randomBytes(8).readBigUInt64BE(0).toString()
}
async getSessionId(
@@ -2417,7 +2412,7 @@ export class AnalyticsService {
const sid = (await sessionScripts.swetrixPeekSession(
sessionKey,
- this.generateSid(psid),
+ this.generateSid(),
UNIQUE_SESSION_LIFE_TIME,
LEGACY_SESSION_FLAG,
)) as string
@@ -2436,7 +2431,7 @@ export class AnalyticsService {
const [sid, isNewFlag] = (await sessionScripts.swetrixResolveSession(
sessionKey,
- this.generateSid(psid),
+ this.generateSid(),
UNIQUE_SESSION_LIFE_TIME,
LEGACY_SESSION_FLAG,
)) as [string, string]
diff --git a/backend/apps/community/src/analytics/analytics.service.ts b/backend/apps/community/src/analytics/analytics.service.ts
index b06e1cec4..2674fe8a6 100644
--- a/backend/apps/community/src/analytics/analytics.service.ts
+++ b/backend/apps/community/src/analytics/analytics.service.ts
@@ -2041,13 +2041,8 @@ export class AnalyticsService {
return `ses:${psid}`
}
- private generateSid(psid: string): string {
- return crypto
- .createHash('sha256')
- .update(`${psid}:${Date.now()}:${crypto.randomBytes(16).toString('hex')}`)
- .digest()
- .readBigUInt64BE(0)
- .toString()
+ private generateSid(): string {
+ return crypto.randomBytes(8).readBigUInt64BE(0).toString()
}
async getSessionId(
@@ -2061,7 +2056,7 @@ export class AnalyticsService {
const sid = (await sessionScripts.swetrixPeekSession(
sessionKey,
- this.generateSid(psid),
+ this.generateSid(),
UNIQUE_SESSION_LIFE_TIME,
LEGACY_SESSION_FLAG,
)) as string
@@ -2080,7 +2075,7 @@ export class AnalyticsService {
const [sid, isNewFlag] = (await sessionScripts.swetrixResolveSession(
sessionKey,
- this.generateSid(psid),
+ this.generateSid(),
UNIQUE_SESSION_LIFE_TIME,
LEGACY_SESSION_FLAG,
)) as [string, string]