Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

fix: new eslint warnings

Blue Mouseeb00e6511e77
diff --git a/web/app/components/DangerouslySetInnerHTML.tsx b/web/app/components/DangerouslySetInnerHTML.tsx
index 0440b2e1c..8d79f4be4 100644
--- a/web/app/components/DangerouslySetInnerHTML.tsx
+++ b/web/app/components/DangerouslySetInnerHTML.tsx
@@ -26,5 +26,6 @@ export const DangerouslySetHtmlContent = ({
divRef.current.appendChild(slotHtml) // Append the new content
}, [html, divRef, allowRerender])
+ // eslint-disable-next-line react-hooks/refs -- Passing ref to DOM element is safe
return createElement('div', { ...rest, ref: divRef })
}
diff --git a/web/app/components/EventsRunningOutBanner.tsx b/web/app/components/EventsRunningOutBanner.tsx
index 1ed4de584..2a018e300 100644
--- a/web/app/components/EventsRunningOutBanner.tsx
+++ b/web/app/components/EventsRunningOutBanner.tsx
@@ -1,5 +1,5 @@
import { ExclamationTriangleIcon, XMarkIcon } from '@heroicons/react/24/outline'
-import { memo, useEffect, useState } from 'react'
+import { memo, useMemo, useState } from 'react'
import { useTranslation } from 'react-i18next'
import { LOW_EVENTS_WARNING, SHOW_BANNER_AT_PERC } from '~/lib/constants'
@@ -11,27 +11,27 @@ import { secondsTillNextMonth } from '~/utils/generic'
const EventsRunningOutBanner = () => {
const { t } = useTranslation('common')
- const [shouldShowBanner, setShouldShowBanner] = useState(false)
const [showMoreInfoModal, setShowMoreInfoModal] = useState(false)
+ const [isBannerClosed, setIsBannerClosed] = useState(false)
const { user, totalMonthlyEvents } = useAuth()
- useEffect(() => {
- if (!user) {
- return
+ const shouldShowBanner = useMemo(() => {
+ if (!user || isBannerClosed) {
+ return false
}
const { maxEventsCount } = user
if (!totalMonthlyEvents || !maxEventsCount) {
- return
+ return false
}
- setShouldShowBanner(shouldShowLowEventsBanner(totalMonthlyEvents, maxEventsCount))
- }, [user, totalMonthlyEvents])
+ return shouldShowLowEventsBanner(totalMonthlyEvents, maxEventsCount)
+ }, [user, totalMonthlyEvents, isBannerClosed])
const closeHandler = () => {
- setShouldShowBanner(false)
+ setIsBannerClosed(true)
const maxAge = secondsTillNextMonth() + 86400
setCookie(LOW_EVENTS_WARNING, 1, maxAge)
diff --git a/web/app/components/ExitIntentPopup.tsx b/web/app/components/ExitIntentPopup.tsx
index 890fd780a..59a2d7a8d 100644
--- a/web/app/components/ExitIntentPopup.tsx
+++ b/web/app/components/ExitIntentPopup.tsx
@@ -28,6 +28,7 @@ export default function ExitIntentPopup({ isStandalone = false }: ExitIntentPopu
const dismissed = getCookie(COOKIE_NAME)
if (dismissed) {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Reading cookie once on mount
setIsDismissed(true)
return
}
diff --git a/web/app/components/pricing/BillingPricing.tsx b/web/app/components/pricing/BillingPricing.tsx
index b2e3efd18..413f6e86d 100644
--- a/web/app/components/pricing/BillingPricing.tsx
+++ b/web/app/components/pricing/BillingPricing.tsx
@@ -65,6 +65,7 @@ const BillingPricing = ({ lastEvent }: BillingPricingProps) => {
const urlParams = new URLSearchParams(window.location.search)
const legacyParam = urlParams.get('__ENABLE_LEGACY_PLANS')
if (legacyParam === 'true') {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Reading URL param once on mount
setEnableLegacyPlans(true)
}
}, [])
diff --git a/web/app/modals/NewFunnel.tsx b/web/app/modals/NewFunnel.tsx
index 1cb4448a4..541b0a200 100644
--- a/web/app/modals/NewFunnel.tsx
+++ b/web/app/modals/NewFunnel.tsx
@@ -45,7 +45,7 @@ const NewFunnel = ({ onClose, onSubmit, isOpened, funnel, loading }: NewFunnelPr
return
}
- setName(funnel?.name || '')
+ setName(funnel?.name || '') // eslint-disable-line react-hooks/set-state-in-effect -- Resetting form state when modal opens
setSteps(
funnel?.steps
? funnel.steps.map((s) => ({ type: s?.startsWith('/') ? 'page' : 'event', value: s }))
diff --git a/web/app/pages/Auth/ChangeEmail/index.tsx b/web/app/pages/Auth/ChangeEmail/index.tsx
index 9a101ecf7..deb311510 100644
--- a/web/app/pages/Auth/ChangeEmail/index.tsx
+++ b/web/app/pages/Auth/ChangeEmail/index.tsx
@@ -15,6 +15,7 @@ const ChangeEmail = () => {
const [error, setError] = useState('')
useEffect(() => {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Async email verification flow
setLoading(true)
if (!_isString(id)) {
diff --git a/web/app/pages/Auth/Signin/Signin.tsx b/web/app/pages/Auth/Signin/Signin.tsx
index 99650f13d..2a8ad6560 100644
--- a/web/app/pages/Auth/Signin/Signin.tsx
+++ b/web/app/pages/Auth/Signin/Signin.tsx
@@ -75,6 +75,7 @@ const Signin = () => {
}
useEffect(() => {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Form validation on input change
validate()
}, [form]) // eslint-disable-line
diff --git a/web/app/pages/Project/ProjectProtectedPassword/index.tsx b/web/app/pages/Project/ProjectProtectedPassword/index.tsx
index bcabd9eb0..b637dd305 100644
--- a/web/app/pages/Project/ProjectProtectedPassword/index.tsx
+++ b/web/app/pages/Project/ProjectProtectedPassword/index.tsx
@@ -59,6 +59,7 @@ const ProjectProtectedPassword = () => {
}
useEffect(() => {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Form validation on input change
validate()
}, [form]) // eslint-disable-line
diff --git a/web/app/pages/Project/View/Panels.tsx b/web/app/pages/Project/View/Panels.tsx
index da0691545..f95a9b340 100644
--- a/web/app/pages/Project/View/Panels.tsx
+++ b/web/app/pages/Project/View/Panels.tsx
@@ -1534,6 +1534,7 @@ const MetadataPanel = ({ metadata }: MetadataPanelProps) => {
const sizeKeys = _size(metadata)
if (currentIndex > sizeKeys) {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Reset page when metadata size changes
setPage(_floor(sizeKeys / ENTRIES_PER_PANEL))
}
}, [currentIndex, metadata])
diff --git a/web/app/pages/Project/View/components/AddAViewModal.tsx b/web/app/pages/Project/View/components/AddAViewModal.tsx
index ccc034371..814727c5f 100644
--- a/web/app/pages/Project/View/components/AddAViewModal.tsx
+++ b/web/app/pages/Project/View/components/AddAViewModal.tsx
@@ -217,6 +217,7 @@ const AddAViewModal = ({ onSubmit, showModal, setShowModal, tnMapping, defaultVi
}
if (defaultView.filters) {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Syncing form state with defaultView prop
setActiveFilters(defaultView.filters)
}
@@ -232,6 +233,7 @@ const AddAViewModal = ({ onSubmit, showModal, setShowModal, tnMapping, defaultVi
return
}
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Fetching filter list when modal opens
getFiltersList(filterType)
}, [filterType, showModal, getFiltersList])
diff --git a/web/app/pages/Project/View/components/RefreshStatsButton.tsx b/web/app/pages/Project/View/components/RefreshStatsButton.tsx
index 3d7e13d0f..62ba431a8 100644
--- a/web/app/pages/Project/View/components/RefreshStatsButton.tsx
+++ b/web/app/pages/Project/View/components/RefreshStatsButton.tsx
@@ -20,6 +20,7 @@ export const RefreshStatsButton = ({ onRefresh }: RefreshStatsButtonProps) => {
const { t } = useTranslation('common')
const [progress, setProgress] = useState(0)
const [isRefreshing, setIsRefreshing] = useState(false)
+ // eslint-disable-next-line react-hooks/purity -- Initial timestamp is intentionally set once
const startTimeRef = useRef(Date.now())
const hasTriggeredRefresh = useRef(false)
diff --git a/web/app/pages/Project/View/components/SearchFilters.tsx b/web/app/pages/Project/View/components/SearchFilters.tsx
index f7a74e318..f8bd71985 100644
--- a/web/app/pages/Project/View/components/SearchFilters.tsx
+++ b/web/app/pages/Project/View/components/SearchFilters.tsx
@@ -114,6 +114,7 @@ const SearchFilters = ({ showModal, setShowModal, tnMapping, filters, type }: Se
return
}
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Fetching filter list when modal opens
getFiltersList(filterType)
}, [filterType, showModal, getFiltersList])
diff --git a/web/app/pages/Unsubscribe/index.tsx b/web/app/pages/Unsubscribe/index.tsx
index 52ff2268c..6b9628c33 100644
--- a/web/app/pages/Unsubscribe/index.tsx
+++ b/web/app/pages/Unsubscribe/index.tsx
@@ -21,6 +21,7 @@ const Unsubscribe = ({ type }: UnsubscribeProps) => {
const [error, setError] = useState('')
useEffect(() => {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Async unsubscribe flow
setLoading(true)
if (!_isString(token)) {
diff --git a/web/app/providers/CurrentProjectProvider.tsx b/web/app/providers/CurrentProjectProvider.tsx
index 602627896..c1b6179c2 100644
--- a/web/app/providers/CurrentProjectProvider.tsx
+++ b/web/app/providers/CurrentProjectProvider.tsx
@@ -184,6 +184,7 @@ const useLiveVisitors = (project: Project | null) => {
return
}
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Initial fetch and interval subscription
updateLiveVisitors()
const interval = setInterval(async () => {
diff --git a/web/app/routes/_index.tsx b/web/app/routes/_index.tsx
index 3bbbc300a..d55128f31 100644
--- a/web/app/routes/_index.tsx
+++ b/web/app/routes/_index.tsx
@@ -737,9 +737,9 @@ const PerformancePreview = () => {
</ul>
)
- const metric = (label: string, value: number, _change: number) => {
- const isUp = Math.random() > 0.5
- const pct = Math.floor(Math.random() * 20) + 1 // 1-20%
+ const metric = (label: string, value: number, prevValue: number) => {
+ const isUp = value >= prevValue
+ const pct = prevValue > 0 ? Math.abs(Math.round(((value - prevValue) / prevValue) * 100)) : 0
return (
<div className='min-w-0 flex-1 rounded-md bg-white px-2.5 py-1.5 text-[11px] text-slate-900 ring-1 ring-black/5 dark:bg-slate-900 dark:text-gray-50 dark:ring-white/10'>
<div className='text-lg font-bold'>{fmt(value)}</div>
@@ -1022,7 +1022,7 @@ const AlertsPreview = () => {
}
if (it.kind === 'online') {
- const online = 10 + Math.floor(Math.random() * 10)
+ const online = 15 // Demo value
return (
<div className='rounded-2xl bg-white p-3 ring-1 ring-black/5 dark:bg-slate-900 dark:ring-white/10'>
diff --git a/web/app/routes/feature-flags.tsx b/web/app/routes/feature-flags.tsx
index c1ce5037f..e41d0fcf7 100644
--- a/web/app/routes/feature-flags.tsx
+++ b/web/app/routes/feature-flags.tsx
@@ -36,7 +36,7 @@ const FeatureFlagsPage = () => {
return
}
- setFlags(user.featureFlags ?? [])
+ setFlags(user.featureFlags ?? []) // eslint-disable-line react-hooks/set-state-in-effect -- Initializing flags from user data once
setInitialised(true)
}, [isLoading, user, initialised])
diff --git a/web/app/routes/gsc-connected.tsx b/web/app/routes/gsc-connected.tsx
index 73f60ca7a..79881d2ec 100644
--- a/web/app/routes/gsc-connected.tsx
+++ b/web/app/routes/gsc-connected.tsx
@@ -39,6 +39,7 @@ export default function GscConnected() {
// Prevent duplicate callback processing in React 18 StrictMode (dev) or other double-invocation scenarios
const processedKey = state ? `gsc_processed:${state}` : null
if (processedKey && sessionStorage.getItem(processedKey) === '1') {
+ // eslint-disable-next-line react-hooks/set-state-in-effect -- Checking sessionStorage for duplicate processing
setLoading(false)
return
}
diff --git a/web/app/ui/Datepicker.tsx b/web/app/ui/Datepicker.tsx
index 2e8ff4bb1..da89d6014 100644
--- a/web/app/ui/Datepicker.tsx
+++ b/web/app/ui/Datepicker.tsx
@@ -102,7 +102,7 @@ const DatePicker = forwardRef<DatePickerHandle, DatePickerProps>(function DatePi
// Sync with external value
useEffect(() => {
if (!_isEmpty(value)) {
- setStart(value[0] ? startOfDay(value[0]) : null)
+ setStart(value[0] ? startOfDay(value[0]) : null) // eslint-disable-line react-hooks/set-state-in-effect -- Syncing internal state with controlled value prop
setEnd(value[1] ? startOfDay(value[1]) : null)
if (value[0]) setAnchorMonth(startOfDay(value[0]))
}